From: Thierry Reding <thierry.reding@gmail.com>
To: Akhil R <akhilrajeev@nvidia.com>
Cc: dmaengine@vger.kernel.org, jonathanh@nvidia.com,
ldewangan@nvidia.com, linux-kernel@vger.kernel.org,
linux-tegra@vger.kernel.org, p.zabel@pengutronix.de,
vkoul@kernel.org, robh+dt@kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v2 1/3] dt-bindings: dmaengine: Add compatible for Tegra234
Date: Fri, 8 Jul 2022 16:35:35 +0200 [thread overview]
Message-ID: <YshAt5WAG9zUkrpy@orome> (raw)
In-Reply-To: <20220707145729.41876-2-akhilrajeev@nvidia.com>
[-- Attachment #1: Type: text/plain, Size: 1063 bytes --]
On Thu, Jul 07, 2022 at 08:27:27PM +0530, Akhil R wrote:
> Document the compatible string used by GPCDMA controller for Tegra234.
>
> Signed-off-by: Akhil R <akhilrajeev@nvidia.com>
> ---
> .../devicetree/bindings/dma/nvidia,tegra186-gpc-dma.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/dma/nvidia,tegra186-gpc-dma.yaml b/Documentation/devicetree/bindings/dma/nvidia,tegra186-gpc-dma.yaml
> index 9dd1476d1849..81f3badbc8ec 100644
> --- a/Documentation/devicetree/bindings/dma/nvidia,tegra186-gpc-dma.yaml
> +++ b/Documentation/devicetree/bindings/dma/nvidia,tegra186-gpc-dma.yaml
> @@ -23,6 +23,7 @@ properties:
> oneOf:
> - const: nvidia,tegra186-gpcdma
> - items:
> + - const: nvidia,tegra234-gpcdma
> - const: nvidia,tegra194-gpcdma
> - const: nvidia,tegra186-gpcdma
I don't think this works because it will now fail to validate Tegra194
device trees. You'll need to create a separate set of items for
Tegra234.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2022-07-08 14:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-07 14:57 [PATCH v2 0/3] Add compatible for Tegra234 GPCDMA Akhil R
2022-07-07 14:57 ` [PATCH v2 1/3] dt-bindings: dmaengine: Add compatible for Tegra234 Akhil R
2022-07-08 14:35 ` Thierry Reding [this message]
2022-07-08 16:10 ` Akhil R
2022-07-08 17:48 ` Thierry Reding
2022-07-07 14:57 ` [PATCH v2 2/3] dmaengine: tegra: Add terminate() " Akhil R
2022-07-07 14:57 ` [PATCH v2 3/3] arm64: tegra: Update compatible for Tegra234 GPCDMA Akhil R
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YshAt5WAG9zUkrpy@orome \
--to=thierry.reding@gmail.com \
--cc=akhilrajeev@nvidia.com \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=jonathanh@nvidia.com \
--cc=ldewangan@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).