From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC472C43334 for ; Sun, 10 Jul 2022 10:13:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229591AbiGJKNk (ORCPT ); Sun, 10 Jul 2022 06:13:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33412 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229558AbiGJKNh (ORCPT ); Sun, 10 Jul 2022 06:13:37 -0400 Received: from mailrelay4-1.pub.mailoutpod1-cph3.one.com (mailrelay4-1.pub.mailoutpod1-cph3.one.com [46.30.210.185]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C1EAB25E7 for ; Sun, 10 Jul 2022 03:13:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ravnborg.org; s=rsa1; h=in-reply-to:content-transfer-encoding:content-type:mime-version:references: message-id:subject:cc:to:from:date:from; bh=rEJybCJet2Hivh6qA8E5QBR15vMK+Pp+penGzDCE/gA=; b=b0/nmvN7DqiX0kkiYxY04bD70tMgShZfdVC9ZJajky7kFm6oMYGrw9ktIezVyQs2+8E4/UZfrKTZY EgAn0iCUHct+pl3z5C8FcUpzhgINhlhnEb0lf20zi9BLshv9OYSLNtm3XVvBe7zNHQ4G1KmOAIi1LS NwnSWdozaKCagsnN85fpy4NWwNyJWxz01jdMaHPDzUm6pvUQ2+58/pmRZVqZ/1Uy3JHjUBZQ43LNMm rxOxzHa6Q1U5odiIYxfS8LvBnVyo+NDQvj8q1PpF6/sXWvy1+e2/9ftqQzVTsUxzDx6rWccZ0wiOlH JCHtPfotFyQzC7EL/6WtRy1uhTRFulg== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=ravnborg.org; s=ed1; h=in-reply-to:content-transfer-encoding:content-type:mime-version:references: message-id:subject:cc:to:from:date:from; bh=rEJybCJet2Hivh6qA8E5QBR15vMK+Pp+penGzDCE/gA=; b=zhj7p1kncuTVyhNq25SboIi49TZRRb2yMqScN0famvosUjKTzDGPhMgzllTAHyuGU0B6+UIUM/zKT Z/HbU6wBA== X-HalOne-Cookie: c2ff1fd2e92b6addf632218b96cffdd31ae2ce00 X-HalOne-ID: f17ef01f-0038-11ed-823d-d0431ea8bb10 Received: from mailproxy4.cst.dirpod3-cph3.one.com (2-105-2-98-cable.dk.customer.tdc.net [2.105.2.98]) by mailrelay4.pub.mailoutpod1-cph3.one.com (Halon) with ESMTPSA id f17ef01f-0038-11ed-823d-d0431ea8bb10; Sun, 10 Jul 2022 10:13:29 +0000 (UTC) Date: Sun, 10 Jul 2022 12:13:27 +0200 From: Sam Ravnborg To: Molly Sophia Cc: Thierry Reding , David Airlie , Daniel Vetter , Rob Herring , Krzysztof Kozlowski , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, linux-arm-msm@vger.kernel.org Subject: Re: [PATCH v2 1/2] dt-bindings: display: panel: Add Novatek NT35596S panel bindings Message-ID: References: <20220709141136.58298-1-mollysophia379@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Molly, On Sun, Jul 10, 2022 at 02:19:41PM +0800, Molly Sophia wrote: > Hi Sam, > > Thanks for your suggestions. > > Sam Ravnborg 于 2022年7月10日周日 上午4:47写道： > > > Hi Molly, > > > > thanks for the quick response to the review comments. > > > > On Sat, Jul 09, 2022 at 10:11:35PM +0800, MollySophia wrote: > > > Add documentation for "novatek,nt35596s" panel. > > > > > > Signed-off-by: MollySophia > > The s-o-b needs your real name - guess the above is a concatenation of > > first name and surname. > > > > The binding included in this patch fails the check: > > $ make DT_CHECKER_FLAGS=-m dt_binding_check > > > > You may need to run: > > $ pip3 install dtschema --upgrade > > > > Or you may have to install some dependencies first. > > The problem is that the patch is missing a "reset-gpios: true" > > > > On top of this I looked at the binding - and the description > > this is copied from is almost identical. > > So another approach would be to extend the existing binding like > > in the following. > > > > And this also gives a good hint that maybe this can be embedded in > > the existing driver - and there is no need for a new driver. > > Could you try to give this a spin and get back on this. > > > > That's reasonable. Actually, this driver was modified from > novatek,nt35596s, with different panel initialization commands, and it > seems easy to be embedded in > the existing driver. However, I wonder what the driver file name would > be...? "panel-novatek-nt35596s-nt36672a.c" or something else? Just keep the current driver name - we cannot embed all the supported HW in one driver name anyway. And then you do not break currents users in case they have hardwired the current driver name. Sam