From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9EBEC43334 for ; Tue, 12 Jul 2022 02:29:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230126AbiGLC3c (ORCPT ); Mon, 11 Jul 2022 22:29:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35648 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229896AbiGLC3b (ORCPT ); Mon, 11 Jul 2022 22:29:31 -0400 Received: from mail-ot1-x336.google.com (mail-ot1-x336.google.com [IPv6:2607:f8b0:4864:20::336]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7257F326DA for ; Mon, 11 Jul 2022 19:29:30 -0700 (PDT) Received: by mail-ot1-x336.google.com with SMTP id j15-20020a056830014f00b0061c4d8736b5so2918897otp.1 for ; Mon, 11 Jul 2022 19:29:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=bVUeMOT6CxdYKQvRRpgploiMAFLvvgb73Ly7V1pXLtk=; b=w5ImoHPEOa/orzfpbfnqn4nL6QRHkFGjjNQZYmkUBkWlQWVHk+DWOP6XqkSi6t1KB7 oV3KAKH8llKXrEeE02drFReEMOKZfAPbgdso7aLtE5CW6Tzeu+wJMs1QJMi4gpCRnk8Z FmwYm1x8aNDd8Xa5JszYSJ5+ccl8QwZ5W/AEhQqCoJjAT1j+dMoU7ImlJyYR7b+ldiWn S7GWPKzQN6Q3YHuKvGXFQ1RG7xy7EeZzXVgN7cwP6ou0DFjie/FVcgA4TV+JU/jKV2pC LUC4uOKaiG5H40npL04prEQO0rx9gX0o/2LI+t1/0Hob/qmCb+in1KwYpwKp8M1yWs2d 8ljQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=bVUeMOT6CxdYKQvRRpgploiMAFLvvgb73Ly7V1pXLtk=; b=Ego4y4bOg/BshS+HNX4BG8URsryrl/4F7F6pT9TG6SS92c/Xrd6D+5daleM+eM10hY czBceD1iZHRoLTg2tdC5+E34V2jtm8Fp1CNPadyTPcGHrNr4z3iYF6m4XTMcAV6PDBFu OnCxba01eZi3fl7F4dJy2209FaObph4+E8cVH2bQJISGgRt9oiagzGTNnmyWoGlj7n/Z HCOahNzA7IYpzAESYpwrii76n5SKJeBm4g52mo5U3gsXa5tWgq9mQy7HdZ81ScUwczrJ lS8KJdoOPcyajUHR5yS4sxCCvNiNXHmdPA2xkxwerw5HUmt8IQtbchMhKU/h4MuurtVv oMlg== X-Gm-Message-State: AJIora+L3j0qTcakGzm961FckcF85XzPBgR22gkKtaAEB8vcpWhRsDhj 2Eqa7kMCphQAGLQ5lwnbvJdExQ== X-Google-Smtp-Source: AGRyM1vYCldoBiX82cDLOxQEYA7mJU1VsMRs9GX5SixmhPO1n9olIa7E47iMVVuAsmvScqtcp0HjtQ== X-Received: by 2002:a05:6830:314b:b0:61c:148c:4f34 with SMTP id c11-20020a056830314b00b0061c148c4f34mr8352234ots.283.1657592969782; Mon, 11 Jul 2022 19:29:29 -0700 (PDT) Received: from ripper (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id k18-20020a056870819200b0010c5005d427sm3998996oae.33.2022.07.11.19.29.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Jul 2022 19:29:29 -0700 (PDT) Date: Mon, 11 Jul 2022 19:31:56 -0700 From: Bjorn Andersson To: Manivannan Sadhasivam Cc: Andy Gross , Konrad Dybcio , Johan Hovold , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] arm64: dts: qcom: sc8280xp: Add lost ranges for timer Message-ID: References: <20220707160858.3178771-1-bjorn.andersson@linaro.org> <20220709065915.GG5063@thinkpad> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220709065915.GG5063@thinkpad> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Fri 08 Jul 23:59 PDT 2022, Manivannan Sadhasivam wrote: > On Thu, Jul 07, 2022 at 09:08:58AM -0700, Bjorn Andersson wrote: > > The timer node needs ranges specified to map the 1-cell children to the > > 2-cell address range used in /soc. This addition never made it into the > > patch that was posted and merged, so add it now. > > > > Fixes: 152d1faf1e2f ("arm64: dts: qcom: add SC8280XP platform") > > Signed-off-by: Bjorn Andersson > > --- > > arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi > > index 2bdb42c88311..37a4cd6f85b6 100644 > > --- a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi > > +++ b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi > > @@ -1667,6 +1667,7 @@ timer@17c20000 { > > reg = <0x0 0x17c20000 0x0 0x1000>; > > #address-cells = <1>; > > #size-cells = <1>; > > + ranges = <0 0 0 0x20000000>; > > Even though this looks correct, I'm wondering why other SoCs are defining the > child addresses in 2 cells. I don't think the timer frames can go beyond 32bit > address space. Should we fix them too? > Neither addresses nor sizes used for mmio need more than 32 bits, but ranges and dma-ranges are expressed in #size-cells. So unless these cells are 2 there's no way for us to express the fact that (most of) our busses uses 36 address bits. And we need to be able to do this, because the SMMU on multiple platforms claims that the bus is 40 address bits, so we end up running into issues with the upper 4 bits of IOVAs being truncated. Regards, Bjorn > But for this patch, > > Reviewed-by: Manivannan Sadhasivam > > Thanks, > Mani > > > > > frame@17c21000 { > > frame-number = <0>; > > -- > > 2.35.1 > > > > -- > ??????????????????????????? ????????????????????????