From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8351FC43334 for ; Thu, 14 Jul 2022 13:38:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239468AbiGNNia (ORCPT ); Thu, 14 Jul 2022 09:38:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35246 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239466AbiGNNi3 (ORCPT ); Thu, 14 Jul 2022 09:38:29 -0400 Received: from mail-wr1-x430.google.com (mail-wr1-x430.google.com [IPv6:2a00:1450:4864:20::430]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C33205F9B8 for ; Thu, 14 Jul 2022 06:38:24 -0700 (PDT) Received: by mail-wr1-x430.google.com with SMTP id h17so2673050wrx.0 for ; Thu, 14 Jul 2022 06:38:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=gZbm5v8jczB3m3Zbghv7hORrbzz+8TA8A7EGSVhjSaQ=; b=QhSFR35ht5QEM5YZF2rpDWTzxDIE4nFn1yZhWPiMSFmnpD/aDrZwGNbmNuamkHO1XF 1J4UOj7++gNdTSdZuPgzZvkbRoyZHLZhZb+N2JoI+nCcDQNaD/P8pQ75/GdD+ScQdwp0 59oDsFg3whwkWU97Rsn5CqHobBGGRYbjWrEOyblVdLZNk34xQRMRGkLoLnzSInu0dPKM aZVXK/Fey7k6krYGdUv3TzlEFgETj7JSuoN7kMMtQTCiSSFwqaHVrKTyYziyVfG2EiGk 5krBajsYVkRMa+oEMQTmJz40cEHzkpD5xdRKxpWJyH+LvNS6bhqZzJy1pKjOn59iCwTx 9c5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=gZbm5v8jczB3m3Zbghv7hORrbzz+8TA8A7EGSVhjSaQ=; b=ZZS7cxWOn44W7i8Jwc8j9AcxXyc29/1C8hqW2lqlOV5/9oFo9ME4GQmZtuopVgkySK TbiWn9BxUuwLHoPSko64Gx5el9hdK5EmnsywREcmi2E83ZoWoJDUrMEWdBDCwCh6byaB HUwNqFxxg0B+UNTuU0pm3dxdkhwwpFVkbgISxmZGm686tRwBPCopKvDv13OtUAOIvPlu wjHo8nFgslWLVFpsIkYMW0LRIwE9EG1bYRXO2HSQCidA09nn20y1Oj4U32KeOZRay+XH 5DSkDBBIH7wMyFRiEZjfDvLHBQZEpBcgEnsAwwnbOgrxI93uiLaDxa1XMON4mmV4dBjw Tyzg== X-Gm-Message-State: AJIora+FuvJHUxMnqIVSj/bVKRyToAM+v16Q8I+FnWwjfS5P33sdYe+6 k3IoIhA6LravfFpCbHW06cqz+g== X-Google-Smtp-Source: AGRyM1uxSpQQUohZAVCvRDTDUH1kMNPkjZLHzaAqEsW41la3u7tmhLBotyjHD8UJYEkeF4RD+P0HJw== X-Received: by 2002:a05:6000:81d:b0:21d:a495:6e3 with SMTP id bt29-20020a056000081d00b0021da49506e3mr8401904wrb.502.1657805903332; Thu, 14 Jul 2022 06:38:23 -0700 (PDT) Received: from google.com (cpc155339-bagu17-2-0-cust87.1-3.cable.virginm.net. [86.27.177.88]) by smtp.gmail.com with ESMTPSA id n18-20020a05600c4f9200b003a2ec73887fsm8793750wmq.1.2022.07.14.06.38.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Jul 2022 06:38:22 -0700 (PDT) Date: Thu, 14 Jul 2022 14:38:20 +0100 From: Lee Jones To: Tinghan Shen Cc: Yong Wu , Joerg Roedel , Will Deacon , Rob Herring , Krzysztof Kozlowski , Matthias Brugger , Chun-Jie Chen , AngeloGioacchino Del Regno , MandyJH Liu , Weiyi Lu , iommu@lists.linux.dev, linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Project_Global_Chrome_Upstream_Group@mediatek.com Subject: Re: [PATCH v2 03/19] dt-bindings: power: mediatek: Add bindings for MediaTek SCPSYS Message-ID: References: <20220714122837.20094-1-tinghan.shen@mediatek.com> <20220714122837.20094-4-tinghan.shen@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220714122837.20094-4-tinghan.shen@mediatek.com> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Subject line should be 'mfd', rather than 'power'. On Thu, 14 Jul 2022, Tinghan Shen wrote: > The System Control Processor System (SCPSYS) has several power > management related tasks in the system. Add the bindings for it. > > Signed-off-by: Tinghan Shen > --- > .../bindings/mfd/mediatek,scpsys.yaml | 62 +++++++++++++++++++ > 1 file changed, 62 insertions(+) > create mode 100644 Documentation/devicetree/bindings/mfd/mediatek,scpsys.yaml > > diff --git a/Documentation/devicetree/bindings/mfd/mediatek,scpsys.yaml b/Documentation/devicetree/bindings/mfd/mediatek,scpsys.yaml > new file mode 100644 > index 000000000000..a8b9220f2f27 > --- /dev/null > +++ b/Documentation/devicetree/bindings/mfd/mediatek,scpsys.yaml > @@ -0,0 +1,62 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/mfd/mediatek,scpsys.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: MediaTek System Control Processor System > + > +maintainers: > + - MandyJH Liu > + > +description: > + MediaTek System Control Processor System (SCPSYS) has several > + power management tasks. The tasks include MTCMOS power > + domain control, thermal measurement, DVFS, etc. > + > +properties: > + compatible: > + items: > + - const: mediatek,scpsys > + - const: syscon > + - const: simple-mfd > + > + reg: > + maxItems: 1 > + > + power-controller: > + $ref: /schemas/power/mediatek,power-controller.yaml# > + > +required: > + - compatible > + - reg > + > +additionalProperties: false > + > +examples: > + - | > + #include > + #include > + > + syscon@10006000 { > + compatible = "mediatek,scpsys", "syscon", "simple-mfd"; Not sure you need bindings for this. Seems overkill. I'll let the DT guys have the final say though. > + reg = <0x10006000 0x100>; > + > + spm: power-controller { > + compatible = "mediatek,mt8195-power-controller"; > + #address-cells = <1>; > + #size-cells = <0>; > + #power-domain-cells = <1>; > + > + /* sample of power domain nodes */ > + power-domain@MT8195_POWER_DOMAIN_PCIE_PHY { > + reg = ; > + #power-domain-cells = <0>; > + }; > + > + power-domain@MT8195_POWER_DOMAIN_SSUSB_PCIE_PHY { > + reg = ; > + #power-domain-cells = <0>; > + }; > + }; > + }; -- Lee Jones [李琼斯] Principal Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog