From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 98B2CC43334 for ; Fri, 15 Jul 2022 09:36:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231794AbiGOJgx (ORCPT ); Fri, 15 Jul 2022 05:36:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53292 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230138AbiGOJgx (ORCPT ); Fri, 15 Jul 2022 05:36:53 -0400 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1417D7E801; Fri, 15 Jul 2022 02:36:52 -0700 (PDT) Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id C2762993; Fri, 15 Jul 2022 11:36:49 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1657877809; bh=EHp0moRQn0J8P7EHzWyn0c8ze5yNEDJeYxMsaQuPATE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=g3jynj5FamzNz5y8dhscZqUhd3ppCWL2VxIXuuh1yttPoVxA6hgjM/muWkPSakqbh JGP+OCmzWfKhGFTu0mlKyaGtWMjLxcrLkOM2flcELvnxJMwuyFoNt8Ws73tYBna5pw kJBM2WiIZUy45Y+cK1M/rpTtIWMpmqVEBORH/zM0= Date: Fri, 15 Jul 2022 12:36:18 +0300 From: Laurent Pinchart To: Volodymyr Kharuk Cc: linux-media@vger.kernel.org, Andrii Kyselov , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Hyun Kwon , Michal Simek , Kieran Bingham , devicetree@vger.kernel.org, Benjamin Mugnier Subject: Re: [PATCH v2 4/6] media: uapi: Add mlx7502x header file Message-ID: References: <0765b2ef8eea43dce67232a109e9f8b338aa06bd.1657786765.git.vkh@melexis.com> <20220715085720.GA2295@vkh-ThinkPad-T490> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20220715085720.GA2295@vkh-ThinkPad-T490> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hello, CC'ing Benjamin Mugnier who I recall expressed an interest in ToF sensors (if I recall incorrectly, my apologies). On Fri, Jul 15, 2022 at 11:57:20AM +0300, Volodymyr Kharuk wrote: > On Thu, Jul 14, 2022 at 01:31:35PM +0300, Laurent Pinchart wrote: > > On Thu, Jul 14, 2022 at 11:34:46AM +0300, Volodymyr Kharuk wrote: > > > Define user controls for mlx7502x driver and update MAINTAINERS > > > > > > Signed-off-by: Volodymyr Kharuk > > > --- > > > MAINTAINERS | 7 +++++++ > > > include/uapi/linux/mlx7502x.h | 31 +++++++++++++++++++++++++++++++ > > > 2 files changed, 38 insertions(+) > > > create mode 100644 include/uapi/linux/mlx7502x.h > > > > > > diff --git a/MAINTAINERS b/MAINTAINERS > > > index ef3ec334fae9..1a68d888ee14 100644 > > > --- a/MAINTAINERS > > > +++ b/MAINTAINERS > > > @@ -12673,6 +12673,13 @@ S: Supported > > > W: http://www.melexis.com > > > F: drivers/iio/temperature/mlx90632.c > > > > > > +MELEXIS MLX7502X DRIVER > > > +M: Volodymyr Kharuk > > > +L: linux-media@vger.kernel.org > > > +S: Supported > > > +W: http://www.melexis.com > > > +F: include/uapi/linux/mlx7502x.h > > > + > > > MELFAS MIP4 TOUCHSCREEN DRIVER > > > M: Sangwon Jee > > > S: Supported > > > diff --git a/include/uapi/linux/mlx7502x.h b/include/uapi/linux/mlx7502x.h > > > new file mode 100644 > > > index 000000000000..44386f3d6f5a > > > --- /dev/null > > > +++ b/include/uapi/linux/mlx7502x.h > > > @@ -0,0 +1,31 @@ > > > +/* SPDX-License-Identifier: GPL-2.0 WITH Linux-syscall-note */ > > > +/* > > > + * Melexis 7502x ToF cameras driver. > > > + * > > > + * Copyright (C) 2021 Melexis N.V. > > > + * > > > + */ > > > + > > > +#ifndef __UAPI_MLX7502X_H_ > > > +#define __UAPI_MLX7502X_H_ > > > + > > > +#include > > > + > > > > These controls should be documented, in > > Documentation/userspace-api/media/drivers/. > > Ok, will do in v3 > > > > +/* number of phases per frame: 1..8 */ > > > +#define V4L2_CID_MLX7502X_PHASE_NUMBER (V4L2_CID_USER_MLX7502X_BASE + 0) > > > +/* shift of each phase in frame, this is an array of 8 elements, each 16bits */ > > > +#define V4L2_CID_MLX7502X_PHASE_SEQ (V4L2_CID_USER_MLX7502X_BASE + 1) > > > +/* frequency modulation in MHz */ > > > +#define V4L2_CID_MLX7502X_FMOD (V4L2_CID_USER_MLX7502X_BASE + 2) > > > +/* time integration of each phase in us */ > > > +#define V4L2_CID_MLX7502X_TINT (V4L2_CID_USER_MLX7502X_BASE + 3) > > > > Are these control very device-specific, or are they concept that apply > > in general to ToF sensors ? Same for V4L2_CID_MLX7502X_OUTPUT_MODE. > > These controls(except V4L2_CID_MLX7502X_OUTPUT_MODE) are general for ToF > sensors. Do you think we should standardize them? I would really really like to see control standardization for ToF sensors, yes :-) Do you know of any public litterature that explains the operating principles of ToF sensors ? I don't expect most of the V4L2 developers to be familiar with the concept, so something that could bring us up to speed on ToF would be useful for the discussion. > Note that the control V4L2_CID_MLX7502X_TINT is similar to > V4L2_CID_EXPOSURE, but the way it is done in ToF is different. They don't > have a shutter. So I gave a separate control name. Is it ok? Yes, I think that's fine. > > > +/* mode could sw(sending i2c packet), hw(pin triggering), and continuous(self triggering) */ > > > +#define V4L2_CID_MLX7502X_TRIGGER_MODE (V4L2_CID_USER_MLX7502X_BASE + 4) > > > +/* in case sw or hw trigger mode is used */ > > > +#define V4L2_CID_MLX7502X_TRIGGER (V4L2_CID_USER_MLX7502X_BASE + 5) > > > > Trigger control is likely something we need to standardize at the V4L2 > > level. > > Ok, then I'll remove these controls for now and I will back with this as > a separate patch. > > > > +/* this is related to the taps in ToF cameras, usually A minus B is the best option */ > > > +#define V4L2_CID_MLX7502X_OUTPUT_MODE (V4L2_CID_USER_MLX7502X_BASE + 6) > > > +/* ToF camers has its own temperature sensor, which can be read out only during streaming */ > > > +#define V4L2_CID_MLX7502X_TEMPERATURE (V4L2_CID_USER_MLX7502X_BASE + 7) > > > > This should probably use the proposed temperature control from > > https://lore.kernel.org/linux-media/20220415111845.27130-3-benjamin.mugnier@foss.st.com/ > > Ok, then I'll remove these controls for now. > > > > + > > > +#endif /* __UAPI_MLX7502X_H_ */ -- Regards, Laurent Pinchart