From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95A4AC43334 for ; Sun, 17 Jul 2022 03:04:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233038AbiGQDEr (ORCPT ); Sat, 16 Jul 2022 23:04:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37196 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232970AbiGQDEr (ORCPT ); Sat, 16 Jul 2022 23:04:47 -0400 Received: from mail-oa1-x29.google.com (mail-oa1-x29.google.com [IPv6:2001:4860:4864:20::29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C109D14012 for ; Sat, 16 Jul 2022 20:04:42 -0700 (PDT) Received: by mail-oa1-x29.google.com with SMTP id 586e51a60fabf-10d4691a687so320832fac.10 for ; Sat, 16 Jul 2022 20:04:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=hpo48E8sj1DuK2c49zytJWXoQg4RRXwX3plQ016SBF8=; b=L2c0lxLjMSR6pXr9J9CN5mx5OC2RgUZPavMO5F4XMyTvpRrXKi3dTpKE0/VFJ5mjLK OlPeIzxqCRGZoY+k5BLWPKfQuLCJRAFt/jk6gRH9dMeTKsAlBO1DNyf6mjf/XKp2F/gL qOPmsTNpPX5OA3bJ42ifPEFBgBMoEtI/vmSkRoDi8oDfvIgzDTbVMeelPwloVkKXJ+hp yr7O8pw+v7hbJkDxJwmwtECOnw+wHRhqXjzRGrTx6dKS0GeOSHf8hZssQJYpien5n6H5 8aa03hDMjRZYKKQR5MQiY70TSvUdb5mqMLjxYCOKwBqkypbAERhwnE0wcC/bB7/pYKs4 QAyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=hpo48E8sj1DuK2c49zytJWXoQg4RRXwX3plQ016SBF8=; b=M1MIVinX+Ari7ZG/2OVDGANLKqlv39ZxYl6d125Za8CWtyeIFhRKcfeYuyu9YAStcS DdDjl8jKELJM1Z9xBuB8nSOHT121Bf/CyGeSTuVkFURhTR/H1Wg7HsawJ4RWcEizrQyi bisNy74uy5SFfhGrtzhA1eTqZ/o8GMt0allPgpW8XyauQC6mHhmneQy2k/Pgn1edWnj1 qzEMWMWWtn2wcw4XNcZON/KIxq1NQtpq60drK9R9DGpfeMPmKqs7+oSdlmCQIa7H/ci3 aSFJMRNm4GrZSXIAV9WtRsTClMOVKWvXv7apG/1RYgK9hOaeV/BBdZZ5zJ+aE24GJ78l FDTA== X-Gm-Message-State: AJIora9V1H6SHQ57bl4O3gHjwlWQpKkwa7OQg+vat/tiix/fVcD84y6G 4pTw2msCSmmnHUj9BOCtNNUHfw== X-Google-Smtp-Source: AGRyM1vi7sSPETLwZXXm4NqV9z9s8VsFaKMm3xfvdQshZauQuoyl2sneX/Yol14OfG8iVaLDvZbpPA== X-Received: by 2002:a05:6870:b40c:b0:10b:8a3c:b13d with SMTP id x12-20020a056870b40c00b0010b8a3cb13dmr11838436oap.108.1658027082070; Sat, 16 Jul 2022 20:04:42 -0700 (PDT) Received: from builder.lan (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id k20-20020a056870571400b0010c275b6376sm4479708oap.38.2022.07.16.20.04.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 16 Jul 2022 20:04:41 -0700 (PDT) Date: Sat, 16 Jul 2022 22:04:39 -0500 From: Bjorn Andersson To: Christian Marangi Cc: Andy Gross , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Ohad Ben-Cohen , Baolin Wang , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-remoteproc@vger.kernel.org, Krzysztof Kozlowski Subject: Re: [PATCH v2 2/3] ARM: dts: qcom: add missing hwlock for ipq8064 dtsi Message-ID: References: <20220707102040.1859-1-ansuelsmth@gmail.com> <20220707102040.1859-2-ansuelsmth@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220707102040.1859-2-ansuelsmth@gmail.com> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Thu 07 Jul 05:20 CDT 2022, Christian Marangi wrote: > Add missing hwlock for ipq8064 dtsi provided by qcom,sfpb-mutex. > > Signed-off-by: Christian Marangi > Acked-by: Krzysztof Kozlowski > --- > arch/arm/boot/dts/qcom-ipq8064.dtsi | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/arch/arm/boot/dts/qcom-ipq8064.dtsi b/arch/arm/boot/dts/qcom-ipq8064.dtsi > index 4b475d98343c..cd1b43e2cab4 100644 > --- a/arch/arm/boot/dts/qcom-ipq8064.dtsi > +++ b/arch/arm/boot/dts/qcom-ipq8064.dtsi > @@ -1224,4 +1224,11 @@ sdcc3: mmc@12180000 { > }; > }; > }; > + > + sfpb_mutex: hwlock@1200600 { This is an mmio device, so it should live under /soc, so I moved it there while applying the patch. But it would be nice if this file followed others and kept all nodes sorted by address (or name if they don't have an address). Also if addresses were padded to 8 digits, to make sorting easier. I would much appreciate if you could find the time to prepare such a patch. Thank you, Bjorn > + compatible = "qcom,sfpb-mutex"; > + reg = <0x01200600 0x100>; > + > + #hwlock-cells = <1>; > + }; > }; > -- > 2.36.1 >