From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 358F0C19F29 for ; Thu, 28 Jul 2022 13:51:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230330AbiG1NvE (ORCPT ); Thu, 28 Jul 2022 09:51:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55752 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231304AbiG1Nux (ORCPT ); Thu, 28 Jul 2022 09:50:53 -0400 Received: from mailrelay3-1.pub.mailoutpod1-cph3.one.com (mailrelay3-1.pub.mailoutpod1-cph3.one.com [46.30.210.184]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AD01C481CA for ; Thu, 28 Jul 2022 06:50:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ravnborg.org; s=rsa1; h=in-reply-to:content-type:mime-version:references:message-id:subject:cc:to: from:date:from; bh=81CE8cWzUiT+pbHFTXIMXYIlWow9EQ8Wvsa5Y6TihSE=; b=mpQSV1lcqdnZfUqHQdsZjIZjllkBefKHfE47qVKcR0LcVGrrMg0gzsfGuXbi/Q4Pw/Gh917YDPusw yEUty+79TONgN7i6IbHrVlNs1xIi1YHtp7Z8TYGLm8LItpEj3fVBG7crQtM0omFesJ9/D2E5Zd8tAk uWyUGMK5/305ZYKmKc+5wbCa41ETO+e7FoKglMukQhbu55RtbFvcV/3HzTF0PtBcK/pQyEaxaiR7fX x0TAwr7kc2YLAdIZy3tgDe0LF82IdgiF0NBSzFnS44XUK928uMSsH9c1nv+SMZFJFXiLXGYXt6GCFi j/SnFGw7dr8j84w1sWq7vLrkPgeXR+A== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=ravnborg.org; s=ed1; h=in-reply-to:content-type:mime-version:references:message-id:subject:cc:to: from:date:from; bh=81CE8cWzUiT+pbHFTXIMXYIlWow9EQ8Wvsa5Y6TihSE=; b=vkqXrzrQS4Ozm2e1ARR8cR3abhTvNzuqERua9aY+ZZXN9K58QRPSMD5QoDmq+Nt2PnK04ujTj6o69 Hhll8OIDA== X-HalOne-Cookie: 0d8ef64462d11d9be67ccc33377236296e9cc1f0 X-HalOne-ID: 4828a37a-0e7c-11ed-be80-d0431ea8bb03 Received: from mailproxy2.cst.dirpod4-cph3.one.com (2-105-2-98-cable.dk.customer.tdc.net [2.105.2.98]) by mailrelay3.pub.mailoutpod1-cph3.one.com (Halon) with ESMTPSA id 4828a37a-0e7c-11ed-be80-d0431ea8bb03; Thu, 28 Jul 2022 13:50:47 +0000 (UTC) Date: Thu, 28 Jul 2022 15:50:45 +0200 From: Sam Ravnborg To: Krzysztof Kozlowski Cc: Molly Sophia , Sumit Semwal , Thierry Reding , David Airlie , Daniel Vetter , Rob Herring , Krzysztof Kozlowski , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org Subject: Re: [PATCH v4 2/2] drm: panel: Add novatek nt35596s panel driver Message-ID: References: <20220728023555.8952-1-mollysophia379@gmail.com> <20220728023555.8952-3-mollysophia379@gmail.com> <1685ecd6-cfe7-c2f1-add5-6bfff055fa06@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1685ecd6-cfe7-c2f1-add5-6bfff055fa06@linaro.org> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Krzysztof On Thu, Jul 28, 2022 at 02:17:29PM +0200, Krzysztof Kozlowski wrote: > On 28/07/2022 04:35, Molly Sophia wrote: > > Novatek NT35596s is a generic DSI IC that drives command and video mode > > panels. Add the driver for it. Currently add support for the LCD panel > > from JDI connected with this IC, as found on Xiaomi Mi Mix2s phones. > > > > Changes in v4: > > - No change. > > > > Changes in v3: > > - Embed the support into existing driver (panel-novatek-nt36672a), as > > these two IC are similar with different initialization commands. > > > > This does not go to commit msg (---). It depends... In the drm sub-system the general rule is if someone cares to write it, then it deserves to be added to the commit message. So for drm patches it is perfectly fine to have the history part included in the commit message. These sub-system differences does not makes it easier - I know. Sam