From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BAED0C19F2D for ; Wed, 3 Aug 2022 07:31:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234416AbiHCHbl (ORCPT ); Wed, 3 Aug 2022 03:31:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54650 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235619AbiHCHax (ORCPT ); Wed, 3 Aug 2022 03:30:53 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9D2E79FF2; Wed, 3 Aug 2022 00:30:51 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 4B8F9B821A5; Wed, 3 Aug 2022 07:30:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E4E87C433C1; Wed, 3 Aug 2022 07:30:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1659511848; bh=TyMeEqWBu5IifHReIBRw1bgA+Mfnb0FI1r7G9D1jkLs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ABFSsOPJVQ0vYhOl0vmk1f9ZZRJ2Jgb9fm+bK4TccFFZg1kKdvTJA+TdRy73eFCuv QoLYn4wuL+y2ZMpQVyJwESGS+RP1Zq/+d7a/SFs/VXtI2JiK1e1s9B/MwjVPqkJ9NH fGD0MyfqyoddyH/32g6Vfmf3f2C/94xNFRFKDgvQJJLZbh/UxKXOJn26cGXTughDz8 VV5a7kzy1kE9iVJLD6uDJS3ZCMMX9R9Af/C97KPQXx6i4WMwEi1g7hg14DXrPO3sXh 1LrRxqXCXuv1bHBcWQqYaA/XgIkoDDwUGJPJ8SZ+RfsPmandC9GpMN0K+S5VcA7hmc P4mSt0rBdUP4Q== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1oJ8qQ-0004OS-Mm; Wed, 03 Aug 2022 09:31:06 +0200 Date: Wed, 3 Aug 2022 09:31:06 +0200 From: Johan Hovold To: Rob Herring Cc: Johan Hovold , Greg Kroah-Hartman , Felipe Balbi , Krzysztof Kozlowski , Andy Gross , Bjorn Andersson , Manivannan Sadhasivam , Konrad Dybcio , Krishna Kurapati , Stephen Boyd , Doug Anderson , Matthias Kaehlcke , Pavankumar Kondeti , quic_ppratap@quicinc.com, quic_vpulyala@quicinc.com, linux-arm-msm , Linux USB List , devicetree@vger.kernel.org, "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 5/8] Revert "dt-bindings: usb: dwc3: Add wakeup-source property support" Message-ID: References: <20220802151404.1797-1-johan+linaro@kernel.org> <20220802151404.1797-6-johan+linaro@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Tue, Aug 02, 2022 at 11:17:22AM -0600, Rob Herring wrote: > On Tue, Aug 2, 2022 at 9:14 AM Johan Hovold wrote: > > It should also not be used to > > work around Linux driver implementation issues such as how to coordinate > > the glue and core dwc3 drivers. > > > > For the Qualcomm dwc3 controllers, it is the glue device that manages > > the wakeup interrupts, which may or may not be able to wake the system > > up from system suspend. > > While the reasoning to add this may have been for QCom, having this > property for other users makes sense. On some platforms, 'snps,dwc3' > is the only node (i.e. there's no wrapper node). So I don't think this > should be reverted. Fair enough. Let's keep it in the core child node then where we can still retrieve from the glue parent directly. (I assume you're not suggesting also adding 'wakeup-source' to the qcom glue node, which is where the actual wakeup interrupts live.) The glue and core parts needs to work in concert even if the current implementation tends to make that harder than it should be. Johan