From: Andrew Lunn <andrew@lunn.ch>
To: wei.fang@nxp.com
Cc: hkallweit1@gmail.com, linux@armlinux.org.uk, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
f.fainelli@gmail.com, netdev@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V3 net 2/2] net: phy: at803x: add disable hibernation mode support
Date: Thu, 18 Aug 2022 21:29:07 +0200 [thread overview]
Message-ID: <Yv6TA9xfx4m2+YrH@lunn.ch> (raw)
In-Reply-To: <20220818030054.1010660-3-wei.fang@nxp.com>
On Thu, Aug 18, 2022 at 11:00:54AM +0800, wei.fang@nxp.com wrote:
> From: Wei Fang <wei.fang@nxp.com>
>
> When the cable is unplugged, the Atheros AR803x PHYs will enter
> hibernation mode after about 10 seconds if the hibernation mode
> is enabled and will not provide any clock to the MAC. But for
> some MACs, this feature might cause unexpected issues due to the
> logic of MACs.
> Taking SYNP MAC (stmmac) as an example, if the cable is unplugged
> and the "eth0" interface is down, the AR803x PHY will enter
> hibernation mode. Then perform the "ifconfig eth0 up" operation,
> the stmmac can't be able to complete the software reset operation
> and fail to init it's own DMA. Therefore, the "eth0" interface is
> failed to ifconfig up. Why does it cause this issue? The truth is
> that the software reset operation of the stmmac is designed to
> depend on the RX_CLK of PHY.
> So, this patch offers an option for the user to determine whether
> to disable the hibernation mode of AR803x PHYs.
>
> Signed-off-by: Wei Fang <wei.fang@nxp.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
next prev parent reply other threads:[~2022-08-18 19:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-18 3:00 [PATCH V3 net 0/2] Add DT property to disable hibernation mode wei.fang
2022-08-18 3:00 ` [PATCH V3 net 1/2] dt-bindings: net: ar803x: add disable-hibernation-mode propetry wei.fang
2022-08-18 16:35 ` Rob Herring
2022-08-18 3:00 ` [PATCH V3 net 2/2] net: phy: at803x: add disable hibernation mode support wei.fang
2022-08-18 19:29 ` Andrew Lunn [this message]
2022-08-18 19:58 ` Jakub Kicinski
2022-08-18 20:28 ` Andrew Lunn
2022-08-18 23:40 ` [PATCH V3 net 0/2] Add DT property to disable hibernation mode patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yv6TA9xfx4m2+YrH@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=robh+dt@kernel.org \
--cc=wei.fang@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).