From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A34DCC00140 for ; Mon, 8 Aug 2022 21:34:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244374AbiHHVee (ORCPT ); Mon, 8 Aug 2022 17:34:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57734 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244412AbiHHVec (ORCPT ); Mon, 8 Aug 2022 17:34:32 -0400 Received: from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com [IPv6:2a00:1450:4864:20::42a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2B2471B79C for ; Mon, 8 Aug 2022 14:34:27 -0700 (PDT) Received: by mail-wr1-x42a.google.com with SMTP id p10so12258431wru.8 for ; Mon, 08 Aug 2022 14:34:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jrtc27.com; s=gmail.jrtc27.user; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc; bh=9kRHsgOgJ6PrAYABPQZo5fFEimmGDPOkqaNSMbcJVyc=; b=TYEiGXwYdSs4KSceoUw0CONgMh/BCvSsIAkhexa4o4d8X0/H14uel438GJ7mB39Q0O IE1q8hV2gxxGTpP8sXz39FaGlVNq0vre28mLKsTHR71YmHlycqTUxLWbMDvW8G9zA1kV aIcKAijN6Zne3pHprutjgeaZzPmEvNOOU/9mPkehxyznxeoFODtYxiK/b2/16Cayl1VM rTq2CSDmDw/x9K20038uoWnRahYX9u1Vnd/MNldNaqz17kK9epaesrnTJrVd7N5gemCz Xg8i4j+c8J0AhUsr6FCPhlytlOXTxD48x+cdFRPhrYN6g7snYKStSUeycdlW4nfYRVVg vyzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc; bh=9kRHsgOgJ6PrAYABPQZo5fFEimmGDPOkqaNSMbcJVyc=; b=BtQ0jEUo13JWexvb3LQNpe6fn8emloFfVLrGGFYjr7BQv7fLXpvmMAIwNnp/ZKGQJL UnWOitopv3BBffYl9y65DkM/rXiHk+D/FBK04NbgcnrtnyLz/hbcUseazvn0w+2bDUjp Nv88tk+K7aiK62rKdDL73/eO+vnu82G+jim75GQJZt3fuk67DuBE5KHPszJY+yAUZ5QF 252Qkb+majKo9fB/oKGQmW0hv3Esdb/fDwlay49PXJZbaD564rnTklaw7gxhw1u92GxE uKfBlBZ48f/CmfxqHzphkfnKmKuWtiD2uX3F+Qtkuff94LQc242nty4a8E0irBtSh37B DBqA== X-Gm-Message-State: ACgBeo1ZgFbJs2scHaaQX+Yl6N8s43ecCwChpjV85pNpGB9M/8IBVnvT gD+ZVZPueuNQm5mQqwoCrCWNxw== X-Google-Smtp-Source: AA6agR5mFLBH7jdSMh6Rb2K0gPj3kWj9UbS6iuvGWq1LcSMGI6UaYFSJLp5u4ZP4z0ZR67q8PSvObQ== X-Received: by 2002:a05:6000:235:b0:220:3a22:fe38 with SMTP id l21-20020a056000023500b002203a22fe38mr12675264wrz.419.1659994465738; Mon, 08 Aug 2022 14:34:25 -0700 (PDT) Received: from Jessicas-MacBook-Pro.localdomain (global-5-141.n-2.net.cam.ac.uk. [131.111.5.141]) by smtp.gmail.com with ESMTPSA id m6-20020a05600c4f4600b003a4eea0aa48sm15541146wmq.0.2022.08.08.14.34.25 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Mon, 08 Aug 2022 14:34:25 -0700 (PDT) Received: by Jessicas-MacBook-Pro.localdomain (Postfix, from userid 501) id B48C929DB6B6; Mon, 8 Aug 2022 22:34:24 +0100 (BST) Date: Mon, 8 Aug 2022 22:34:24 +0100 From: Jessica Clarke To: Conor Dooley Cc: Thomas Gleixner , Marc Zyngier , Rob Herring , Krzysztof Kozlowski , Palmer Dabbelt , Paul Walmsley , Albert Ou , Daniel Lezcano , Anup Patel , Conor Dooley , Guo Ren , Sagar Kadam , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-riscv@lists.infradead.org, qemu-riscv@nongnu.org Subject: Re: [PATCH 0/3] Fix dt-validate issues on qemu dtbdumps due to dt-bindings Message-ID: References: <20220805162844.1554247-1-mail@conchuod.ie> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220805162844.1554247-1-mail@conchuod.ie> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Fri, Aug 05, 2022 at 05:28:42PM +0100, Conor Dooley wrote: > From: Conor Dooley > > The device trees produced automatically for the virt and spike machines > fail dt-validate on several grounds. Some of these need to be fixed in > the linux kernel's dt-bindings, but others are caused by bugs in QEMU. > > Patches been sent that fix the QEMU issues [0], but a couple of them > need to be fixed in the kernel's dt-bindings. The first patches add > compatibles for "riscv,{clint,plic}0" which are present in drivers and > the auto generated QEMU dtbs. IMO the correct thing is to have QEMU use a qemu,plicX rather than to weaken the requirement that a non-generic compatible be used. Otherwise you end up with QEMU using something that's marked as deprecated and either the warning remains and annoys people still or it becomes too weak and people ignore it when creating real hardware. > The final patch adds some new ISA strings > which needs scruitiny from someone with more knowledge about what ISA > extension strings should be reported in a dt than I have. Listing every possible ISA string supported by the Linux kernel really is not going to scale... Jess > Thanks to Rob Herring for reporting these issues [1], > Conor. > > To reproduce the errors: > ./build/qemu-system-riscv64 -nographic -machine virt,dumpdtb=qemu.dtb > dt-validate -p /path/to/linux/kernel/Documentation/devicetree/bindings/processed-schema.json qemu.dtb > (The processed schema needs to be generated first) > > 0 - https://lore.kernel.org/linux-riscv/20220805155405.1504081-1-mail@conchuod.ie > 1 - https://lore.kernel.org/linux-riscv/20220803170552.GA2250266-robh@kernel.org/ > > Conor Dooley (3): > dt-bindings: timer: sifive,clint: add legacy riscv compatible > dt-bindings: interrupt-controller: sifive,plic: add legacy riscv > compatible > dt-bindings: riscv: add new riscv,isa strings for emulators > > .../sifive,plic-1.0.0.yaml | 5 +++++ > .../devicetree/bindings/riscv/cpus.yaml | 2 ++ > .../bindings/timer/sifive,clint.yaml | 18 ++++++++++++------ > 3 files changed, 19 insertions(+), 6 deletions(-) > > > base-commit: 42d670bda02fdba0f3944c92f545984501e5788d > -- > 2.37.1 > > > _______________________________________________ > linux-riscv mailing list > linux-riscv@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-riscv