From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2350DC25B08 for ; Tue, 9 Aug 2022 21:12:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229487AbiHIVLy (ORCPT ); Tue, 9 Aug 2022 17:11:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35106 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229711AbiHIVLm (ORCPT ); Tue, 9 Aug 2022 17:11:42 -0400 Received: from mail-oa1-x2b.google.com (mail-oa1-x2b.google.com [IPv6:2001:4860:4864:20::2b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3A3F85E31D for ; Tue, 9 Aug 2022 14:11:39 -0700 (PDT) Received: by mail-oa1-x2b.google.com with SMTP id 586e51a60fabf-10ea9ef5838so15510742fac.3 for ; Tue, 09 Aug 2022 14:11:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc; bh=0RDlI0yOZFKLzfsXOiJhSEf3VmQ/yEncp6iJ3cB4fto=; b=gMasx+0sDjRymuLWGt9b7mXSG5oWJydXMpw9X46dcNXprWjNn48EPwebcrs61YCsgv 0rCLP6e5Z6aVOtJKVpYWqBFdk9JTfPWxh4Dx6aecrZXlwWaqMSfmUEaYBgrDmWK4gyv7 s/1CoZljQU/Xv48NHvR/z9cFORA+T+mDbX3JmnE8mfvQhVO4mhDnIDnlrmC/fln4L8Ky Ku/GzFC+NkTh/IXenqQPvCJcWPcrpyNkhSTr2tI4xYdpofLdSj9RFkS13/2K6xOlwAbn kIVpAaV6354QUOirWlVKniNri7W5et4VYRcd5M87hQlMJXcu26xskMLjwKkXHAN2ljH9 1ofQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc; bh=0RDlI0yOZFKLzfsXOiJhSEf3VmQ/yEncp6iJ3cB4fto=; b=bovZSaRr9PjkW1QLTEv7RclUebrMuV/cdboRgboiSVwsxxodTkzw8sSeV/nrEoYgyd 8nJx+mtGOyJtxQlZBAt3wQpxVpXaWm+v7hpRU59EL9PHcXlBGv56znQywfTFymyKfMCv HUPH+57/lCV3rjyLOumbIw1Y9MdUSx07s5psimK566XQn8hdN+Jddk4Gae46qtX4OIS3 Ri6f3cKs9ogaF+7vyHsfSvPzidnhT0dceefxt6wOToQOXg24Eo/2W3ymC0iNrZJbEUeE YclVZUXs2MiTbObf23H0wLnQhnl3Y69w4xBHUvFEaWXDPjuNdW0C0T4m3UruCMWI9C0h 5qrw== X-Gm-Message-State: ACgBeo0W8780ZZDxDy0LtjkW8dpSYqm7RhSWVq7azhnH4F88sPslhNUm n1JzCsL4MSQjjX4HoiKoYq47xQ== X-Google-Smtp-Source: AA6agR5Dm0fRPPYug/WAD/FJ+8g5sch6O4DIf560RcIw2R1zzt4YkkkbsV4kVW1csUcD7MQX3u72qg== X-Received: by 2002:a05:6870:3281:b0:10e:4d35:dcb2 with SMTP id q1-20020a056870328100b0010e4d35dcb2mr149316oac.283.1660079499050; Tue, 09 Aug 2022 14:11:39 -0700 (PDT) Received: from baldur ([2600:380:785a:7aa8:200:ff:fe00:0]) by smtp.gmail.com with ESMTPSA id s9-20020a056870630900b0010c17e6c699sm3391992oao.47.2022.08.09.14.11.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Aug 2022 14:11:38 -0700 (PDT) Date: Tue, 9 Aug 2022 16:11:32 -0500 From: Bjorn Andersson To: Shinjo Park Cc: David Heidelberg , Andy Gross , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 2/3] ARM: dts: qcom: msm8960: add the device node of USB1 Message-ID: References: <2654048.mvXUDI8C0e@ainazi> <20220803074608.21048-1-peremen@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220803074608.21048-1-peremen@gmail.com> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Wed 03 Aug 02:46 CDT 2022, Shinjo Park wrote: > Use the same USB definition as qcom-apq8064.dtsi, tested on Casio GzOne. > I think this looks good, but I have a v2 of patch 1 and a v3 of patch 2, and I don't seem to have patch 3 in my inbox(?) Can you please resubmit the 3 patches with a --cover-letter, instead of each patch being a reply of the previous instance of that particular patch? This will make it much easier for me to merge the end result. Thanks, Bjorn > Signed-off-by: Shinjo Park > Reviewed-by: David Heidelberg > --- > > v3: > - Include missing clock/qcom,lcc-msm8960.h to make cleanly applicable > > v2: > - Rewrite commit message > - Reorder status line > > arch/arm/boot/dts/qcom-msm8960.dtsi | 33 +++++++++++++++++++++++++++++ > 1 file changed, 33 insertions(+) > > diff --git a/arch/arm/boot/dts/qcom-msm8960.dtsi b/arch/arm/boot/dts/qcom-msm8960.dtsi > index e14e1c5d1..0e099aa7c 100644 > --- a/arch/arm/boot/dts/qcom-msm8960.dtsi > +++ b/arch/arm/boot/dts/qcom-msm8960.dtsi > @@ -3,6 +3,8 @@ > > #include > #include > +#include > +#include > #include > #include > > @@ -167,6 +169,37 @@ regulators { > }; > }; > > + usb1: usb@12500000 { > + compatible = "qcom,ci-hdrc"; > + reg = <0x12500000 0x200>, > + <0x12500200 0x200>; > + interrupts = ; > + clocks = <&gcc USB_HS1_XCVR_CLK>, <&gcc USB_HS1_H_CLK>; > + clock-names = "core", "iface"; > + assigned-clocks = <&gcc USB_HS1_XCVR_CLK>; > + assigned-clock-rates = <60000000>; > + resets = <&gcc USB_HS1_RESET>; > + reset-names = "core"; > + phy_type = "ulpi"; > + ahb-burst-config = <0>; > + phys = <&usb_hs1_phy>; > + phy-names = "usb-phy"; > + #reset-cells = <1>; > + status = "disabled"; > + > + ulpi { > + usb_hs1_phy: phy { > + compatible = "qcom,usb-hs-phy-msm8960", > + "qcom,usb-hs-phy"; > + clocks = <&sleep_clk>, <&cxo_board>; > + clock-names = "sleep", "ref"; > + resets = <&usb1 0>; > + reset-names = "por"; > + #phy-cells = <0>; > + }; > + }; > + }; > + > acc0: clock-controller@2088000 { > compatible = "qcom,kpss-acc-v1"; > reg = <0x02088000 0x1000>, <0x02008000 0x1000>; > -- > 2.34.1 >