From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85E07C25B07 for ; Wed, 10 Aug 2022 19:51:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233195AbiHJTvN (ORCPT ); Wed, 10 Aug 2022 15:51:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48150 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229924AbiHJTvM (ORCPT ); Wed, 10 Aug 2022 15:51:12 -0400 Received: from mail-ot1-x335.google.com (mail-ot1-x335.google.com [IPv6:2607:f8b0:4864:20::335]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 10FE386C3E for ; Wed, 10 Aug 2022 12:51:11 -0700 (PDT) Received: by mail-ot1-x335.google.com with SMTP id cb12-20020a056830618c00b00616b871cef3so11331078otb.5 for ; Wed, 10 Aug 2022 12:51:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc; bh=wufSRqh/QVijGNaq/aAL4S6kr3FJOGsDXoMinL9NFkQ=; b=LXS7pfWVJyH5+9g4Izlsrw3QCK89LKUhaAHp5PyyAybFmK+2tcHA6rw4Qhm3UpQHLg dNr+xBXZVwW5tdJ5LNEpA5dFjcQ6aiuAnYIFqZBfm4KTzmx0X6M67UWHgAO5DKnCt5ct zX9KsxzwDqU/wIREG0lFidsRNh1UAjHYzHpF5rwWmfHA6Awz7PYTk4QslNbpBuvC3SQ9 PU4vqDIE30AI9OomcvRsYk/JJITDIv3oSAQnGzoUMQNzJaGh1Oexs8iWx7v6uzbOxOf8 Q4i+9pyUxUq4kNWQcloP+g98YZTZsjqLc4FhPQOGcIk/zlClbgYXupz5AGUvpY45sQGp 5qLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc; bh=wufSRqh/QVijGNaq/aAL4S6kr3FJOGsDXoMinL9NFkQ=; b=KLet0mqe8OLXF64juN4Dxp2o/a3zCai4l+tmpNwUVdBzDGFdwKe6tzjvkAaXlQ+atU SAbE4lfIVJQREpUn6x8XpzpRoEGVgaEuCGtpR8OLc1f/q5tvItACwfOmh7D7ipkCTcNy FgL2zFHelM+2bdFqnD27DVo3lgUmFMIEH3cEdrQlIABtBPtg6IIeJCxyQSkNvcqe9T/v ZFkrKZ9Q/lMwg5yuRTmBnFZ63JTsylHxeDS9syV4BncC28G6eVOrAAp/ttj005dRmPgp jmhKXdu9XSRG5DDkt5XFSG2SNueFg6anDfBLPQz3Bfng0gc96bLlA8yt4nD6zJFXqVxl WyGg== X-Gm-Message-State: ACgBeo3CQAKEG0Oh5Lsfoxtkd3sTa6uWVgN/rtx80xJMp0IjVGENTE7+ V2pE26/GjMWH+zenJQu1gTMKqA== X-Google-Smtp-Source: AA6agR6PRtN3JeugTc37Fb3rdblC9rYxMYOE9wdMFW9tBCBxJ51atqOVkmRgev2zizv/QACpsCOqjw== X-Received: by 2002:a9d:53c8:0:b0:61e:ddc0:bfae with SMTP id i8-20020a9d53c8000000b0061eddc0bfaemr10427715oth.266.1660161070280; Wed, 10 Aug 2022 12:51:10 -0700 (PDT) Received: from ripper (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id bk12-20020a056830368c00b00636e6dea5e5sm819363otb.23.2022.08.10.12.51.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Aug 2022 12:51:09 -0700 (PDT) Date: Wed, 10 Aug 2022 12:53:45 -0700 From: Bjorn Andersson To: Rudraksha Gupta Cc: agross@kernel.org, david@ixit.cz, devicetree@vger.kernel.org, krzysztof.kozlowski+dt@linaro.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, robh+dt@kernel.org Subject: Re: [PATCH v2 1/2] ARM: msm8960: Rename cxo_board to cxo-board and add alias Message-ID: References: <20220808234723.5184-2-guptarud@gmail.com> <20220809000300.6384-1-guptarud@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220809000300.6384-1-guptarud@gmail.com> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Mon 08 Aug 17:02 PDT 2022, Rudraksha Gupta wrote: > This patch renames cxo_board to be up to date with the current naming > style. It also adds an alias. > > Signed-off-by: Rudraksha Gupta > --- > v2: > - Group the correct changes together > > arch/arm/boot/dts/qcom-msm8960.dtsi | 2 +- > drivers/clk/qcom/gcc-msm8960.c | 2 +- Clock and dts patches goes through two different paths towards mainline, so they should be separated. > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/boot/dts/qcom-msm8960.dtsi b/arch/arm/boot/dts/qcom-msm8960.dtsi > index 0e099aa7c889..2ed969785b78 100644 > --- a/arch/arm/boot/dts/qcom-msm8960.dtsi > +++ b/arch/arm/boot/dts/qcom-msm8960.dtsi > @@ -58,7 +58,7 @@ cpu-pmu { > }; > > clocks { > - cxo_board { > + cxo_board: cxo-board { > compatible = "fixed-clock"; > #clock-cells = <0>; > clock-frequency = <19200000>; > diff --git a/drivers/clk/qcom/gcc-msm8960.c b/drivers/clk/qcom/gcc-msm8960.c > index 051745ef99c8..56ce05a846dd 100644 > --- a/drivers/clk/qcom/gcc-msm8960.c > +++ b/drivers/clk/qcom/gcc-msm8960.c > @@ -3624,7 +3624,7 @@ static int gcc_msm8960_probe(struct platform_device *pdev) > if (!match) > return -EINVAL; > > - ret = qcom_cc_register_board_clk(dev, "cxo_board", "cxo", 19200000); > + ret = qcom_cc_register_board_clk(dev, "cxo-board", "cxo", 19200000); This breaks compatibility with existing DTB files. What you probably want is to make sure that any clocks with parent name of "cxo", should have a .fw_name = "cxo", then you can make a phandle-based reference in DT and these global names doesn't matter (and in the end we can remove this board_clk from the driver). Regards, Bjorn > if (ret) > return ret; > > -- > 2.25.1 >