From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Wei Fang <wei.fang@nxp.com>, "andrew@lunn.ch" <andrew@lunn.ch>,
"hkallweit1@gmail.com" <hkallweit1@gmail.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"edumazet@google.com" <edumazet@google.com>,
"kuba@kernel.org" <kuba@kernel.org>,
"pabeni@redhat.com" <pabeni@redhat.com>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"krzysztof.kozlowski+dt@linaro.org"
<krzysztof.kozlowski+dt@linaro.org>,
"f.fainelli@gmail.com" <f.fainelli@gmail.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net 1/2] dt: ar803x: Document disable-hibernation property
Date: Fri, 12 Aug 2022 12:36:54 +0100 [thread overview]
Message-ID: <YvY7Vjtj+WV3BI59@shell.armlinux.org.uk> (raw)
In-Reply-To: <14cf568e-d7ee-886e-5122-69b2e58b8717@linaro.org>
On Fri, Aug 12, 2022 at 02:25:42PM +0300, Krzysztof Kozlowski wrote:
> hibernation is a feature, but 'disable-hibernation' is not. DTS
> describes the hardware, not policy or driver bejhvior. Why disabling
> hibernation is a property of hardware? How you described, it's not,
> therefore either property is not for DT or it has to be phrased
> correctly to describe the hardware.
However, older DT descriptions need to be compatible with later kernels,
and as existing setups have hibernation enabled, introducing a property
to _enable_ hibernation (which implies if the property is not present,
hibernation is disabled) changes the behaviour with older DT, thereby
breaking backwards compatibility.
Yes, DT needs to describe hardware, but there are also other
constraints too.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2022-08-12 11:37 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-12 14:50 [PATCH net 0/2] Add DT property to disable hibernation mode wei.fang
2022-08-12 14:50 ` [PATCH net 1/2] dt: ar803x: Document disable-hibernation property wei.fang
2022-08-12 7:27 ` Krzysztof Kozlowski
2022-08-12 9:02 ` Wei Fang
2022-08-12 11:25 ` Krzysztof Kozlowski
2022-08-12 11:36 ` Russell King (Oracle) [this message]
2022-08-12 12:04 ` Krzysztof Kozlowski
2022-08-12 12:30 ` Russell King (Oracle)
2022-08-12 12:36 ` Krzysztof Kozlowski
2022-08-12 14:34 ` Russell King (Oracle)
2022-08-15 8:51 ` Wei Fang
2022-08-15 9:19 ` Russell King (Oracle)
2022-08-12 14:15 ` Andrew Lunn
2022-08-15 6:49 ` Wei Fang
2022-08-18 1:20 ` Andrew Lunn
2022-08-18 1:29 ` Wei Fang
2022-08-18 1:44 ` Andrew Lunn
2022-08-18 1:50 ` Wei Fang
2022-08-18 2:01 ` Wei Fang
2022-08-12 15:13 ` Rob Herring
2022-08-12 15:36 ` Andrew Lunn
2022-08-12 14:50 ` [PATCH net 2/2] net: phy: at803x: Add disable hibernation mode support wei.fang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YvY7Vjtj+WV3BI59@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=robh+dt@kernel.org \
--cc=wei.fang@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).