From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F195DC3F6B0 for ; Fri, 12 Aug 2022 11:37:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237405AbiHLLhH (ORCPT ); Fri, 12 Aug 2022 07:37:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43106 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231627AbiHLLhG (ORCPT ); Fri, 12 Aug 2022 07:37:06 -0400 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8C085A5996; Fri, 12 Aug 2022 04:37:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=5cH4W1xFUfBKzHhA0qmhN71IL97dIcVdgSB2lbcjbhI=; b=VWrfiySIRfk42fymYJ4lbMVoYg IvsVVC0S+Tf0U+2J/GIMjtrvjKGe881kIM3qOo7ZdL0eJaBs45a3iNQ/gzMHghMZK4LUtiICadymK Ej1EwJqzyYs2gbFPaMyrtEkt6b4XXnfzjPn5+WFE3Qc8IOf1UbzFAIOJ7Dd3gR/icjf2rkFKYET3u x7duDKn+LxxDelM93iNu4xzc6g9xdbkpyECaZB2xahCkkjvw0/r2eEaRh+AV74gTFLaa8nKKwI2yE JmBdIY5qDTux4U2j0HKwoDA4wvjFQok/sYIB2sg/RTGlBrcwRnk/IB3AyPv/mtmdKsNMGblijkp+z Wc7c80uw==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:33758) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1oMSyH-0000Dg-1j; Fri, 12 Aug 2022 12:36:57 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1oMSyE-0000t0-9V; Fri, 12 Aug 2022 12:36:54 +0100 Date: Fri, 12 Aug 2022 12:36:54 +0100 From: "Russell King (Oracle)" To: Krzysztof Kozlowski Cc: Wei Fang , "andrew@lunn.ch" , "hkallweit1@gmail.com" , "davem@davemloft.net" , "edumazet@google.com" , "kuba@kernel.org" , "pabeni@redhat.com" , "robh+dt@kernel.org" , "krzysztof.kozlowski+dt@linaro.org" , "f.fainelli@gmail.com" , "netdev@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH net 1/2] dt: ar803x: Document disable-hibernation property Message-ID: References: <20220812145009.1229094-1-wei.fang@nxp.com> <20220812145009.1229094-2-wei.fang@nxp.com> <0cd22a17-3171-b572-65fb-e9d3def60133@linaro.org> <14cf568e-d7ee-886e-5122-69b2e58b8717@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <14cf568e-d7ee-886e-5122-69b2e58b8717@linaro.org> Sender: Russell King (Oracle) Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Fri, Aug 12, 2022 at 02:25:42PM +0300, Krzysztof Kozlowski wrote: > hibernation is a feature, but 'disable-hibernation' is not. DTS > describes the hardware, not policy or driver bejhvior. Why disabling > hibernation is a property of hardware? How you described, it's not, > therefore either property is not for DT or it has to be phrased > correctly to describe the hardware. However, older DT descriptions need to be compatible with later kernels, and as existing setups have hibernation enabled, introducing a property to _enable_ hibernation (which implies if the property is not present, hibernation is disabled) changes the behaviour with older DT, thereby breaking backwards compatibility. Yes, DT needs to describe hardware, but there are also other constraints too. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!