From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6D73C25B0E for ; Fri, 12 Aug 2022 12:30:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235957AbiHLMa5 (ORCPT ); Fri, 12 Aug 2022 08:30:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46732 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235068AbiHLMa4 (ORCPT ); Fri, 12 Aug 2022 08:30:56 -0400 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 51D2A9D8E2; Fri, 12 Aug 2022 05:30:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=MR9SSeaqihz5X2s1bIn8TOSxi6LHd5zxSbZDA/8YSx0=; b=BL3hcI1EE7ekYTVspP/0KjywAP n6Hc2VqPrv2wp/ipxGuPEK5lKa2QOWoJrceSyhSM6oH7iZZSgz1ybnkPFlr5utEvxpCqkADGbw0s8 YXmTa7eX+Y7sgGSGfk0Wn6MOcP771vYtvZrmOVay4XWDyDU60R3Ya2m9sHR/ti+3QXeqNkudKmKtG 1xfJjfMfgF0UTTO1HUVQjiDYgR2SM6QaWFU+pj76CU6h9sHjOOukWDxCfaICCtdQZsovbWgTY+lN9 13Qxp69TvbRewXXctRwC2hLYBHr75i4T5TXUaDEIG5lkLcUH3b+L3PJYV0bLZua8Z0vAIJ7xZ93Qt majPS4Jg==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:33764) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1oMToN-0000G1-NN; Fri, 12 Aug 2022 13:30:47 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1oMToL-0000vW-B7; Fri, 12 Aug 2022 13:30:45 +0100 Date: Fri, 12 Aug 2022 13:30:45 +0100 From: "Russell King (Oracle)" To: Krzysztof Kozlowski Cc: Wei Fang , "andrew@lunn.ch" , "hkallweit1@gmail.com" , "davem@davemloft.net" , "edumazet@google.com" , "kuba@kernel.org" , "pabeni@redhat.com" , "robh+dt@kernel.org" , "krzysztof.kozlowski+dt@linaro.org" , "f.fainelli@gmail.com" , "netdev@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH net 1/2] dt: ar803x: Document disable-hibernation property Message-ID: References: <20220812145009.1229094-1-wei.fang@nxp.com> <20220812145009.1229094-2-wei.fang@nxp.com> <0cd22a17-3171-b572-65fb-e9d3def60133@linaro.org> <14cf568e-d7ee-886e-5122-69b2e58b8717@linaro.org> <4cf8d73e-9f14-fe8d-d6e2-551920c1f29e@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4cf8d73e-9f14-fe8d-d6e2-551920c1f29e@linaro.org> Sender: Russell King (Oracle) Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Fri, Aug 12, 2022 at 03:04:41PM +0300, Krzysztof Kozlowski wrote: > I did not propose a property to enable hibernation. The property must > describe hardware, so this piece is missing, regardless whether the > logic in the driver is "enable" or "disable". > > The hardware property for example is: "broken foo, so hibernation should > be disabled" or "engineer forgot to wire cables, so hibernation won't > work"... >From the problem description, the PHY itself isn't broken. The stmmac hardware doesn't reset properly when the clock from the PHY is stopped. That could hardly be described as "broken" - it's quite common for hardware specifications to state that clocks must be running for the hardware to operate correctly. This is a matter of configuring the hardware to inter-operate correctly. Isn't that the whole purpose of DT? So, nothing is broken. Nothing has forgotten to be wired. It's a matter of properly configuring the hardware. Just the same as selecting the correct interface mode to connect two devices together. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!