[PATCH] ARM: dts: am5748: keep usb4_tm disabled

[PATCH] ARM: dts: am5748: keep usb4_tm disabled

[Romain Naour]

From: Romain Naour <romain.naour@skf.com>

From [1]
AM5 and DRA7 SoC families have different set of modules in them so the
SoC sepecific dtsi files need to be separated.

e.g. Some of the major differences between AM576 and DRA76

		DRA76x	AM576x

USB3		x
USB4		x
ATL		x
VCP		x
MLB		x
ISS		x
PRU-ICSS1		x
PRU-ICSS2		x

But commit [2] removed usb4_tm part from am5748.dtsi and introcuded new
ti-sysc errors in dmesg.

Fixes:
ti-sysc 48940000.target-module: clock get error for fck: -2
ti-sysc: probe of 48940000.target-module failed with error -2

[1] https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=bcbb63b80284af0061ac44fe944d31a8482d2b8a
[2] https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=176f26bcd41a0ee8c69b14e97d1edf50e6485d52

Signed-off-by: Romain Naour <romain.naour@skf.com>
Signed-off-by: Romain Naour <romain.naour@smile.fr>
Cc: Roger Quadros <rogerq@ti.com>
---
Issue reproduced on a AM5749 CPU using a 5.10 kernel from ti-linux-kernel:
https://git.ti.com/cgit/ti-linux-kernel/ti-linux-kernel/commit/?h=linux-5.10.y
---
 arch/arm/boot/dts/am5748.dtsi | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/arch/arm/boot/dts/am5748.dtsi b/arch/arm/boot/dts/am5748.dtsi
index c260aa1a85bd..a1f029e9d1f3 100644
--- a/arch/arm/boot/dts/am5748.dtsi
+++ b/arch/arm/boot/dts/am5748.dtsi
@@ -25,6 +25,10 @@ &usb3_tm {
 	status = "disabled";
 };
 
+&usb4_tm {
+	status = "disabled";
+};
+
 &atl_tm {
 	status = "disabled";
 };
-- 
2.34.3

Re: [PATCH] ARM: dts: am5748: keep usb4_tm disabled

[Tony Lindgren]

Hi,

* Romain Naour <romain.naour@smile.fr> [220822 15:39]:
> From: Romain Naour <romain.naour@skf.com>
> 
> From [1]
> AM5 and DRA7 SoC families have different set of modules in them so the
> SoC sepecific dtsi files need to be separated.
> 
> e.g. Some of the major differences between AM576 and DRA76
> 
> 		DRA76x	AM576x
> 
> USB3		x
> USB4		x
> ATL		x
> VCP		x
> MLB		x
> ISS		x
> PRU-ICSS1		x
> PRU-ICSS2		x
> 
> But commit [2] removed usb4_tm part from am5748.dtsi and introcuded new
> ti-sysc errors in dmesg.

OK makes sense to me. Can you please update your patch to use proper
Fixes tags and commit descriptions? This way the patch will get
automatically picked up for stable kernels as a fix.

So something like this instead of listing URLs to commits:

Commit bcbb63b80284 ("ARM: dts: dra7: Separate AM57 dtsi files") blah
blah, then commit 176f26bcd41a ("ARM: dts: Add support for dra762 abz
package") blah blah...

Fixes: 176f26bcd41a ("ARM: dts: Add support for dra762 abz package")

Regards,

Tony

Re: [PATCH] ARM: dts: am5748: keep usb4_tm disabled

[Romain Naour]

Hello,

Le 23/08/2022 à 07:53, Tony Lindgren a écrit :
> Hi,
> 
> * Romain Naour <romain.naour@smile.fr> [220822 15:39]:
>> From: Romain Naour <romain.naour@skf.com>
>>
>> From [1]
>> AM5 and DRA7 SoC families have different set of modules in them so the
>> SoC sepecific dtsi files need to be separated.
>>
>> e.g. Some of the major differences between AM576 and DRA76
>>
>> 		DRA76x	AM576x
>>
>> USB3		x
>> USB4		x
>> ATL		x
>> VCP		x
>> MLB		x
>> ISS		x
>> PRU-ICSS1		x
>> PRU-ICSS2		x
>>
>> But commit [2] removed usb4_tm part from am5748.dtsi and introcuded new
>> ti-sysc errors in dmesg.
> 
> OK makes sense to me. Can you please update your patch to use proper
> Fixes tags and commit descriptions? This way the patch will get
> automatically picked up for stable kernels as a fix.
> 
> So something like this instead of listing URLs to commits:
> 
> Commit bcbb63b80284 ("ARM: dts: dra7: Separate AM57 dtsi files") blah
> blah, then commit 176f26bcd41a ("ARM: dts: Add support for dra762 abz
> package") blah blah...
> 
> Fixes: 176f26bcd41a ("ARM: dts: Add support for dra762 abz package")

Thanks for the review!

I just sent a new patch with updated commit log.

Best regards,
Romain


> 
> Regards,
> 
> Tony