* [PATCH v2] soundwire: qcom: Update error prints to debug prints
@ 2022-07-13 14:54 Srinivasa Rao Mandadapu
2022-07-13 14:58 ` Pierre-Louis Bossart
2022-08-23 16:54 ` Vinod Koul
0 siblings, 2 replies; 3+ messages in thread
From: Srinivasa Rao Mandadapu @ 2022-07-13 14:54 UTC (permalink / raw)
To: vkoul, agross, bjorn.andersson, lgirdwood, broonie, robh+dt,
quic_plai, bgoswami, perex, tiwai, srinivas.kandagatla,
quic_rohkumar, linux-arm-msm, alsa-devel, devicetree,
linux-kernel, swboyd, judyhsiao
Cc: Srinivasa Rao Mandadapu
Update error prints to debug prints to avoid redundant logging in kernel
boot time, as these prints are informative prints in irq handler.
Signed-off-by: Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com>
Reviewed-by: Andrew Halaney <ahalaney@redhat.com>
---
Changes since v1:
-- Remove redundant __func__ argument.
-- Replace dev_dbg with dev_dbg_ratelimited.
drivers/soundwire/qcom.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/soundwire/qcom.c b/drivers/soundwire/qcom.c
index 9df970e..976ae75 100644
--- a/drivers/soundwire/qcom.c
+++ b/drivers/soundwire/qcom.c
@@ -573,11 +573,10 @@ static irqreturn_t qcom_swrm_irq_handler(int irq, void *dev_id)
break;
case SWRM_INTERRUPT_STATUS_NEW_SLAVE_ATTACHED:
case SWRM_INTERRUPT_STATUS_CHANGE_ENUM_SLAVE_STATUS:
- dev_err_ratelimited(swrm->dev, "%s: SWR new slave attached\n",
- __func__);
+ dev_dbg_ratelimited(swrm->dev, "SWR new slave attached\n");
swrm->reg_read(swrm, SWRM_MCP_SLV_STATUS, &slave_status);
if (swrm->slave_status == slave_status) {
- dev_err(swrm->dev, "Slave status not changed %x\n",
+ dev_dbg(swrm->dev, "Slave status not changed %x\n",
slave_status);
} else {
qcom_swrm_get_device_status(swrm);
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH v2] soundwire: qcom: Update error prints to debug prints
2022-07-13 14:54 [PATCH v2] soundwire: qcom: Update error prints to debug prints Srinivasa Rao Mandadapu
@ 2022-07-13 14:58 ` Pierre-Louis Bossart
2022-08-23 16:54 ` Vinod Koul
1 sibling, 0 replies; 3+ messages in thread
From: Pierre-Louis Bossart @ 2022-07-13 14:58 UTC (permalink / raw)
To: Srinivasa Rao Mandadapu, vkoul, agross, bjorn.andersson,
lgirdwood, broonie, robh+dt, quic_plai, bgoswami, perex, tiwai,
srinivas.kandagatla, quic_rohkumar, linux-arm-msm, alsa-devel,
devicetree, linux-kernel, swboyd, judyhsiao
On 7/13/22 09:54, Srinivasa Rao Mandadapu wrote:
> Update error prints to debug prints to avoid redundant logging in kernel
> boot time, as these prints are informative prints in irq handler.
>
> Signed-off-by: Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com>
> Reviewed-by: Andrew Halaney <ahalaney@redhat.com>
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
> ---
> Changes since v1:
> -- Remove redundant __func__ argument.
> -- Replace dev_dbg with dev_dbg_ratelimited.
>
> drivers/soundwire/qcom.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/soundwire/qcom.c b/drivers/soundwire/qcom.c
> index 9df970e..976ae75 100644
> --- a/drivers/soundwire/qcom.c
> +++ b/drivers/soundwire/qcom.c
> @@ -573,11 +573,10 @@ static irqreturn_t qcom_swrm_irq_handler(int irq, void *dev_id)
> break;
> case SWRM_INTERRUPT_STATUS_NEW_SLAVE_ATTACHED:
> case SWRM_INTERRUPT_STATUS_CHANGE_ENUM_SLAVE_STATUS:
> - dev_err_ratelimited(swrm->dev, "%s: SWR new slave attached\n",
> - __func__);
> + dev_dbg_ratelimited(swrm->dev, "SWR new slave attached\n");
> swrm->reg_read(swrm, SWRM_MCP_SLV_STATUS, &slave_status);
> if (swrm->slave_status == slave_status) {
> - dev_err(swrm->dev, "Slave status not changed %x\n",
> + dev_dbg(swrm->dev, "Slave status not changed %x\n",
> slave_status);
> } else {
> qcom_swrm_get_device_status(swrm);
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH v2] soundwire: qcom: Update error prints to debug prints
2022-07-13 14:54 [PATCH v2] soundwire: qcom: Update error prints to debug prints Srinivasa Rao Mandadapu
2022-07-13 14:58 ` Pierre-Louis Bossart
@ 2022-08-23 16:54 ` Vinod Koul
1 sibling, 0 replies; 3+ messages in thread
From: Vinod Koul @ 2022-08-23 16:54 UTC (permalink / raw)
To: Srinivasa Rao Mandadapu
Cc: agross, bjorn.andersson, lgirdwood, broonie, robh+dt, quic_plai,
bgoswami, perex, tiwai, srinivas.kandagatla, quic_rohkumar,
linux-arm-msm, alsa-devel, devicetree, linux-kernel, swboyd,
judyhsiao
On 13-07-22, 20:24, Srinivasa Rao Mandadapu wrote:
> Update error prints to debug prints to avoid redundant logging in kernel
> boot time, as these prints are informative prints in irq handler.
Applied, thanks
--
~Vinod
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-08-23 18:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-07-13 14:54 [PATCH v2] soundwire: qcom: Update error prints to debug prints Srinivasa Rao Mandadapu
2022-07-13 14:58 ` Pierre-Louis Bossart
2022-08-23 16:54 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).