devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Nishanth Menon <nm@ti.com>
Cc: Vignesh Raghavendra <vigneshr@ti.com>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	Keerthy <j-keerthy@ti.com>
Subject: Re: [PATCH 2/2] arm64: dts: ti: k3-am65: Add general purpose timers for am65
Date: Wed, 24 Aug 2022 13:45:27 +0300	[thread overview]
Message-ID: <YwYBR0b03KO5rOfk@atomide.com> (raw)
In-Reply-To: <YvpDRLLp7rVkMDAu@atomide.com>

* Tony Lindgren <tony@atomide.com> [220815 16:03]:
> Hi,
> 
> * Nishanth Menon <nm@ti.com> [220706 23:16]:
> > On 13:47-20220407, Tony Lindgren wrote:
> > > diff --git a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
> > > --- a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
> > > +++ b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
> > > @@ -271,6 +271,114 @@ main_spi4: spi@2140000 {
> > >  		#size-cells = <0>;
> > >  	};
> > >  
> > > +	main_timer0: timer@2400000 {
> > > +		compatible = "ti,am6-timer";
> > > +		reg = <0x00 0x2400000 0x00 0x400>;
> > > +		interrupts = <GIC_SPI 224 IRQ_TYPE_LEVEL_HIGH>;
> > > +		clocks = <&k3_clks 23 12>;
> > > +		clock-names = "fck";
> > > +		ti,timer-pwm;
> > > +	};
> > 
> > Tony,
> > Lets hold this back one more window.. ti,am6-timer should come
> > in the next rc1, but I still dont see this yet in next-20220706, So, i am
> > going to have to skip this window at least.
> 
> I'm seeing the clock being too fast although debugfs reports the timer
> source clock at 32k. Not quite sure what is wrong, maybe the clock index
> should be 1 instead of 12 here. Best to wait with the dts patches until
> the clock issue has bee sorted out.

FYI the issue was caused by a wrong clock configuration. To use the 32k
source as the default clock for main_timer0:

clocks = <&k3_clks 23 0>;
clock-names = "fck";
assigned-clocks = <&k3_clks 23 0>;
assigned-clock-parents = <&k3_clks 23 12>;

Regards,

Tony

      reply	other threads:[~2022-08-24 10:46 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-07 10:47 [PATCH 1/2] arm64: dts: ti: k3-am65: Configure pinctrl for timer IO pads Tony Lindgren
2022-04-07 10:47 ` [PATCH 2/2] arm64: dts: ti: k3-am65: Add general purpose timers for am65 Tony Lindgren
2022-07-06 23:21   ` Nishanth Menon
2022-08-15 12:59     ` Tony Lindgren
2022-08-24 10:45       ` Tony Lindgren [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YwYBR0b03KO5rOfk@atomide.com \
    --to=tony@atomide.com \
    --cc=devicetree@vger.kernel.org \
    --cc=j-keerthy@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=nm@ti.com \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).