From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>
Subject: Re: [PATCH 0/5] arm64: dts: renesas: move I2C aliases to board files
Date: Thu, 25 Aug 2022 08:37:29 +0200 [thread overview]
Message-ID: <YwcYqbIuwtImOQ7/@shikoro> (raw)
In-Reply-To: <CAMuHMdWW0kPATT4zGcjcEPw6XO+18MWJAn_HESe3rrtoEoF=FA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 883 bytes --]
Hi Geert,
> I have never been a fan of the i2c aliases in the SoC-specific .dtsi files,
> as aliases are typically board-specific.
> We also don't have physical connectors labeled "i2c<N>" on any of
> the affected boards. But people like the i2c aliases, because i2c
The reasoning here was that the busses were named like this in the
schematics. Debugging was confusing if these numbers were mixed.
> exposes the full buses to userspace, and the aliases fix the userspace
> naming of /dev/i2c-<N> (I believe there is no better way to identify
> i2c buses from userspace?).
The proper way is udev rules.
> So moving the i2c aliases to the board files is definitely a step in
> the good direction.
>
> BTW, you missed r8a774a1.dtsi in your update.
Okay, so I will send v2 with the above SoC converted as well?
Thanks for your comments,
Wolfram
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2022-08-25 6:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220729164425.11062-1-wsa+renesas@sang-engineering.com>
2022-08-18 13:27 ` [PATCH 0/5] arm64: dts: renesas: move I2C aliases to board files Geert Uytterhoeven
2022-08-25 6:37 ` Wolfram Sang [this message]
2022-08-25 6:46 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YwcYqbIuwtImOQ7/@shikoro \
--to=wsa+renesas@sang-engineering.com \
--cc=devicetree@vger.kernel.org \
--cc=geert@linux-m68k.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).