From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7C87ECAAD7 for ; Fri, 26 Aug 2022 19:37:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231652AbiHZThH (ORCPT ); Fri, 26 Aug 2022 15:37:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42954 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232244AbiHZThF (ORCPT ); Fri, 26 Aug 2022 15:37:05 -0400 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 78B94D2B2A for ; Fri, 26 Aug 2022 12:37:04 -0700 (PDT) Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id D62C52B3; Fri, 26 Aug 2022 21:37:01 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1661542622; bh=Jn/CmBJ+bsugW3aE7kSyGIdCbJd/B+MpKaoeREH+L6w=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Dc+suvu5dWjzY/0AJSl5WL9TrzPCJj4CtBlXzrJleqalrDdjn1k5MEmlnaIzQKVzf obTZQhVh/BGXB6M4N69/iRLQdlrs+YFW88lwHd5kiUZKx3pd+GxStNqgmMGucaF8IJ IaaQuYdHcI5QX0dBjizmOt7nDGwfSUHpDV/ecP3U= Date: Fri, 26 Aug 2022 22:36:54 +0300 From: Laurent Pinchart To: Lucas Stach Cc: Rob Herring , Krzysztof Kozlowski , Liu Ying , Andrzej Hajda , Neil Armstrong , Robert Foss , Jonas Karlman , Philipp Zabel , Kieran Bingham , Marek Vasut , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, patchwork-lst@pengutronix.de, kernel@pengutronix.de Subject: Re: [PATCH 1/4] dt-bindings: display: imx: add binding for i.MX8MP HDMI TX Message-ID: References: <20220826192424.3216734-1-l.stach@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20220826192424.3216734-1-l.stach@pengutronix.de> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Lucas, Thank you for the patch. On Fri, Aug 26, 2022 at 09:24:21PM +0200, Lucas Stach wrote: > The HDMI TX controller on the i.MX8MP SoC is a Synopsys designware IP > core with a little bit of SoC integration around it. > > Signed-off-by: Lucas Stach > Tested-by: Marek Vasut > --- > .../bindings/display/imx/fsl,imx8mp-hdmi.yaml | 74 +++++++++++++++++++ > 1 file changed, 74 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/imx/fsl,imx8mp-hdmi.yaml > > diff --git a/Documentation/devicetree/bindings/display/imx/fsl,imx8mp-hdmi.yaml b/Documentation/devicetree/bindings/display/imx/fsl,imx8mp-hdmi.yaml > new file mode 100644 > index 000000000000..14f7cd47209c > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/imx/fsl,imx8mp-hdmi.yaml > @@ -0,0 +1,74 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/imx/fsl,imx8mp-hdmi.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Freescale i.MX8MP DWC HDMI TX Encoder > + > +maintainers: > + - Lucas Stach > + > +description: | > + The HDMI transmitter is a Synopsys DesignWare HDMI 2.0 TX controller IP. > + > +allOf: > + - $ref: ../bridge/synopsys,dw-hdmi.yaml# > + > +properties: > + compatible: > + enum: > + - fsl,imx8mp-hdmi > + > + reg: > + maxItems: 1 > + > + reg-io-width: > + const: 1 > + > + clocks: > + maxItems: 5 > + > + clock-names: > + items: > + - {} > + - {} I assume these are not named as synopsys,dw-hdmi.yaml already checks them, but would it hurt to list them here for clarity ? I don't mind much either way. Reviewed-by: Laurent Pinchart > + - const: cec > + - const: pix > + - const: fdcc > + > + interrupts: > + maxItems: 1 > + > + power-domains: > + maxItems: 1 > + > +required: > + - compatible > + - reg > + - clocks > + - clock-names > + - interrupts > + - power-domains > + > +additionalProperties: false > + > +examples: > + - | > + #include > + #include > + #include > + > + hdmi@32fd8000 { > + compatible = "fsl,imx8mp-hdmi"; > + reg = <0x32fd8000 0x7eff>; > + interrupts = <0 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&clk IMX8MP_CLK_HDMI_APB>, > + <&clk IMX8MP_CLK_HDMI_REF_266M>, > + <&clk IMX8MP_CLK_HDMI_FDCC_TST>, > + <&clk IMX8MP_CLK_32K>, > + <&hdmi_tx_phy>; > + clock-names = "iahb", "isfr", "fdcc", "cec", "pix"; > + power-domains = <&hdmi_blk_ctrl IMX8MP_HDMIBLK_PD_HDMI_TX>; > + reg-io-width = <1>; > + }; -- Regards, Laurent Pinchart