From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: "Farber, Eliav" <farbere@amazon.com>
Cc: jdelvare@suse.com, linux@roeck-us.net, robh+dt@kernel.org,
p.zabel@pengutronix.de, rtanwar@maxlinear.com,
linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, talel@amazon.com,
hhhawa@amazon.com, jonnyc@amazon.com, hanochu@amazon.com,
ronenk@amazon.com, itamark@amazon.com, shellykz@amazon.com,
shorer@amazon.com, amitlavi@amazon.com, almogbs@amazon.com,
dkl@amazon.com
Subject: Re: [PATCH v3 18/19] hwmon: (mr75203) add debugfs to read and write temperature coefficients
Date: Thu, 1 Sep 2022 22:46:41 +0300 [thread overview]
Message-ID: <YxEMIdBMOeDBsu5D@smile.fi.intel.com> (raw)
In-Reply-To: <646af681-38b0-1268-3798-c5434ca30bee@amazon.com>
On Thu, Sep 01, 2022 at 09:54:21AM +0300, Farber, Eliav wrote:
> On 8/31/2022 3:14 PM, Andy Shevchenko wrote:
> > On Tue, Aug 30, 2022 at 07:22:11PM +0000, Eliav Farber wrote:
...
> > > + pvt->dbgfs_dir = debugfs_create_dir(dev_name(dev), NULL);
> >
> > > + if (!pvt->dbgfs_dir) {
> > > + dev_err(dev, "Failed to create dbgfs_dir\n");
> > > + return -EINVAL;
> > > + }
> >
> > No, just don't check the return value of debugfs API calls.
> >
> Do you mean that I should just do:
> debugfs_create_dir(dev_name(dev), NULL);
> Can you please explain why it's OK to ignore the return value?
Author of the debugfs is speaking:
https://patchwork.kernel.org/project/linux-wireless/patch/20190122152151.16139-38-gregkh@linuxfoundation.org/
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2022-09-01 19:47 UTC|newest]
Thread overview: 88+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-30 19:21 [PATCH v3 00/19] Variety of fixes and new features for mr75203 driver Eliav Farber
2022-08-30 19:21 ` [PATCH v3 01/19] dt-bindings: hwmon: (mr75203) update "intel,vm-map" property to be optional Eliav Farber
2022-09-02 19:50 ` Rob Herring
2022-08-30 19:21 ` [PATCH v3 02/19] hwmon: (mr75203) fix VM sensor allocation when "intel,vm-map" not defined Eliav Farber
2022-08-31 2:39 ` Guenter Roeck
2022-08-31 4:36 ` [PATCH v3 02/19] hwmon: (mr75203) fix VM sensor allocation when "intel, vm-map" " Farber, Eliav
2022-08-31 5:36 ` [PATCH v3 02/19] hwmon: (mr75203) fix VM sensor allocation when "intel,vm-map" " Guenter Roeck
2022-08-31 5:49 ` [PATCH v3 02/19] hwmon: (mr75203) fix VM sensor allocation when "intel, vm-map" " Farber, Eliav
2022-08-31 6:09 ` Farber, Eliav
2022-08-31 11:48 ` Guenter Roeck
2022-09-01 8:39 ` Farber, Eliav
2022-09-01 14:44 ` Guenter Roeck
2022-09-01 15:24 ` Farber, Eliav
2022-09-01 17:11 ` Guenter Roeck
2022-09-01 18:36 ` Farber, Eliav
2022-09-01 19:25 ` Guenter Roeck
2022-09-01 19:49 ` Andy Shevchenko
2022-08-31 9:38 ` [PATCH v3 02/19] hwmon: (mr75203) fix VM sensor allocation when "intel,vm-map" " Andy Shevchenko
2022-09-02 12:08 ` [PATCH v3 02/19] hwmon: (mr75203) fix VM sensor allocation when "intel, vm-map" " Farber, Eliav
2022-09-02 14:15 ` Andy Shevchenko
2022-08-30 19:21 ` [PATCH v3 03/19] hwmon: (mr75203) update pvt->v_num to the actual number of used sensors Eliav Farber
2022-08-31 2:41 ` Guenter Roeck
2022-08-31 4:50 ` Farber, Eliav
2022-08-31 5:31 ` Guenter Roeck
2022-08-30 19:21 ` [PATCH v3 04/19] dt-bindings: hwmon: (mr75203) change "reset" property to be optional Eliav Farber
2022-08-31 8:21 ` Philipp Zabel
2022-08-31 9:43 ` Farber, Eliav
2022-08-31 9:48 ` Philipp Zabel
2022-09-02 19:51 ` Rob Herring
2022-09-03 19:16 ` Farber, Eliav
2022-08-30 19:21 ` [PATCH v3 05/19] hwmon: (mr75203) skip reset-control deassert for SOCs that don't support it Eliav Farber
2022-08-31 8:19 ` Philipp Zabel
2022-08-30 19:21 ` [PATCH v3 06/19] hwmon: (mr75203) fix multi-channel voltage reading Eliav Farber
2022-08-31 9:46 ` Andy Shevchenko
2022-09-01 13:12 ` Farber, Eliav
2022-08-30 19:22 ` [PATCH v3 07/19] hwmon: (mr75203) enable polling for all VM channels Eliav Farber
2022-08-31 11:21 ` Andy Shevchenko
2022-08-31 11:55 ` Farber, Eliav
2022-08-30 19:22 ` [PATCH v3 08/19] dt-bindings: hwmon: (mr75203) add "moortec,vm-active-channels" property Eliav Farber
2022-08-31 11:39 ` Rob Herring
[not found] ` <a8557b5a-6e27-2e66-161e-814fc0f69c1d@amazon.com>
2022-08-31 12:17 ` [PATCH v3 08/19] dt-bindings: hwmon: (mr75203) add "moortec, vm-active-channels" property Rob Herring
2022-08-31 17:47 ` Farber, Eliav
2022-08-31 19:19 ` Rob Herring
2022-08-31 19:55 ` Farber, Eliav
2022-08-30 19:22 ` [PATCH v3 09/19] hwmon: (mr75203) add VM active channel support Eliav Farber
2022-08-31 11:48 ` Andy Shevchenko
2022-09-02 12:04 ` Farber, Eliav
2022-08-30 19:22 ` [PATCH v3 10/19] dt-bindings: hwmon: (mr75203) add "moortec,vm-pre-scaler" property Eliav Farber
2022-09-02 19:57 ` Rob Herring
2022-09-03 19:34 ` [PATCH v3 10/19] dt-bindings: hwmon: (mr75203) add "moortec, vm-pre-scaler" property Farber, Eliav
2022-08-30 19:22 ` [PATCH v3 11/19] hwmon: (mr75203) add VM pre-scaler support Eliav Farber
2022-08-31 12:02 ` Andy Shevchenko
2022-09-01 14:17 ` Farber, Eliav
2022-08-30 19:22 ` [PATCH v3 12/19] hwmon: (mr75203) fix voltage equation for negative source input Eliav Farber
2022-08-31 12:04 ` Andy Shevchenko
2022-09-01 12:47 ` Farber, Eliav
2022-09-01 20:08 ` Andy Shevchenko
2022-08-30 19:22 ` [PATCH v3 13/19] hwmon: (mr75203) modify the temperature equation according to series 5 datasheet Eliav Farber
2022-08-31 12:06 ` Andy Shevchenko
2022-09-01 12:22 ` Farber, Eliav
2022-08-30 19:22 ` [PATCH v3 14/19] dt-bindings: hwmon: (mr75203) add "moortec,ts-series" property Eliav Farber
2022-08-31 8:23 ` Philipp Zabel
2022-08-31 9:23 ` [PATCH v3 14/19] dt-bindings: hwmon: (mr75203) add "moortec, ts-series" property Farber, Eliav
2022-08-31 9:42 ` Philipp Zabel
2022-09-02 13:18 ` Farber, Eliav
2022-09-02 19:59 ` [PATCH v3 14/19] dt-bindings: hwmon: (mr75203) add "moortec,ts-series" property Rob Herring
2022-09-03 19:12 ` [PATCH v3 14/19] dt-bindings: hwmon: (mr75203) add "moortec, ts-series" property Farber, Eliav
2022-08-30 19:22 ` [PATCH v3 15/19] hwmon: (mr75203) add support for series 6 temperature equation Eliav Farber
2022-08-31 12:08 ` Andy Shevchenko
2022-09-01 12:14 ` Farber, Eliav
2022-08-30 19:22 ` [PATCH v3 16/19] dt-bindings: hwmon: (mr75203) add coefficient properties for the thermal equation Eliav Farber
2022-09-02 20:03 ` Rob Herring
2022-09-03 19:16 ` Farber, Eliav
2022-08-30 19:22 ` [PATCH v3 17/19] hwmon: (mr75203) parse temperature coefficients from device-tree Eliav Farber
2022-08-31 12:11 ` Andy Shevchenko
2022-09-01 9:54 ` Farber, Eliav
2022-08-30 19:22 ` [PATCH v3 18/19] hwmon: (mr75203) add debugfs to read and write temperature coefficients Eliav Farber
2022-08-31 12:14 ` Andy Shevchenko
2022-09-01 6:54 ` Farber, Eliav
2022-09-01 14:28 ` Guenter Roeck
2022-09-01 19:46 ` Andy Shevchenko [this message]
2022-08-30 19:22 ` [PATCH v3 19/19] hwmon: (mr75203) fix coding style space errors Eliav Farber
2022-08-31 12:15 ` Andy Shevchenko
2022-09-01 14:21 ` Farber, Eliav
2022-09-01 14:46 ` Guenter Roeck
2022-09-01 15:31 ` Farber, Eliav
2022-09-01 17:09 ` Guenter Roeck
2022-09-01 18:40 ` Farber, Eliav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YxEMIdBMOeDBsu5D@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=almogbs@amazon.com \
--cc=amitlavi@amazon.com \
--cc=devicetree@vger.kernel.org \
--cc=dkl@amazon.com \
--cc=farbere@amazon.com \
--cc=hanochu@amazon.com \
--cc=hhhawa@amazon.com \
--cc=itamark@amazon.com \
--cc=jdelvare@suse.com \
--cc=jonnyc@amazon.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=ronenk@amazon.com \
--cc=rtanwar@maxlinear.com \
--cc=shellykz@amazon.com \
--cc=shorer@amazon.com \
--cc=talel@amazon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).