devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: "Pali Rohár" <pali@kernel.org>
Cc: Gregory Clement <gregory.clement@bootlin.com>,
	Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Marek Behun <marek.behun@nic.cz>,
	linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM: dts: turris-omnia: Add mcu node
Date: Sun, 4 Sep 2022 03:02:56 +0200	[thread overview]
Message-ID: <YxP5QD6v4HmBUVGp@lunn.ch> (raw)
In-Reply-To: <20220903152735.2ga3iwrivh6zhibf@pali>

> > I'm also not sure what the DT people will say about the node name mcu.
> > I don't see any examples of that in the binding documentation. They
> > might request you rename it to gpio-controller, unless it does more
> > than GPIO? And if it does do more than GPIO we are then into mfd
> > territory, and the binding then becomes much more interesting. Then we
> > start the questions, are you defining a ABI now, before there is even
> > a driver for it?
> > 
> >        Andrew
> 
> Yes, there is already driver. See my previous email, I mentioned it and
> also I wrote link for this driver. Moreover now driver is merged in
> upstream u-boot.

I'm not comfortable accepting a DT binding for a driver which does not
exist in Linux. As i said, there are interesting ABI issues here, and
it could be the MFD, GPIO or reset Maintainers don't accept a binding
until a Linux driver exists.

At minimum, you need an Acked-by from the GPIO Maintainer, of the
binding before this DT change is merged via MVEBU.

	Andrew

  reply	other threads:[~2022-09-04  1:03 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-19 13:11 [PATCH] ARM: dts: turris-omnia: Add mcu node Pali Rohár
2022-08-31 14:28 ` Pali Rohár
2022-09-01 22:45   ` Andrew Lunn
2022-09-03  2:39     ` Marek Behún
2022-09-03 15:12       ` Andrew Lunn
2022-09-03 15:27     ` Pali Rohár
2022-09-04  1:02       ` Andrew Lunn [this message]
2022-09-05 16:19       ` Florian Fainelli
2022-09-05 16:34         ` Krzysztof Kozlowski
2022-09-05 17:12           ` Pali Rohár
2022-09-06  6:34             ` Krzysztof Kozlowski
2022-09-06  7:24               ` Pali Rohár

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YxP5QD6v4HmBUVGp@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=devicetree@vger.kernel.org \
    --cc=gregory.clement@bootlin.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marek.behun@nic.cz \
    --cc=pali@kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=sebastian.hesselbarth@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).