From: Abel Vesa <abel.vesa@linaro.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
Amol Maheshwari <amahesh@qti.qualcomm.com>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@somainline.org>,
Rob Herring <robh@kernel.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
David Heidelberg <david@ixit.cz>
Subject: Re: [PATCH v7 1/2] dt-bindings: misc: fastrpc convert bindings to yaml
Date: Tue, 6 Sep 2022 11:46:01 +0300 [thread overview]
Message-ID: <YxcIyRadKQN+BmRe@linaro.org> (raw)
In-Reply-To: <2ffe1ad9-bce9-ff4c-f6f2-6473f4939a52@linaro.org>
On 22-09-06 10:36:14, Krzysztof Kozlowski wrote:
> On 06/09/2022 10:29, Abel Vesa wrote:
> > On 22-09-06 08:45:22, Krzysztof Kozlowski wrote:
> >> On 05/09/2022 16:45, Abel Vesa wrote:
> >>> Convert Qualcomm FastRPC bindings to yaml format, so that we could validate
> >>> dt-entries correctly and any future additions can go into yaml format.
> >>>
> >>> Use compute-cb@ subnodes instead of just cb@.
> >>>
> >>> Also add qcom,non-secure-domain, qcom,glink-channels and
> >>> qcom,smd-channels missing properties to make sure dtbs_check doesn't
> >>> fail right off the bat.
> >>
> >> qcom,non-secure-domain is in original binding, so I don't understand why
> >> it is being "added".
> >>
> >
> > Yeah, my bad, I should've added this line to the changes since v4.
> >
> >>>
> >>> Co-developed-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> >>> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> >>> Co-developed-by: David Heidelberg <david@ixit.cz>
> >>> Signed-off-by: David Heidelberg <david@ixit.cz>
> >>> Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
> >>> ---
> >>>
> >>> Changes since v6:
> >>> * renamed the parent node name in the example from smd-edge to glink-edge
> >>>
> >>> .../devicetree/bindings/misc/qcom,fastrpc.txt | 88 -------------
> >>> .../bindings/misc/qcom,fastrpc.yaml | 118 ++++++++++++++++++
> >>
> >> As you can see in Rob's bot report - the patchset introduces errors and
> >> is not bisectable.
> >
> > Please note that Rob's bot report is for v6.
>
> I see report as a reply to this patch, so for v7. Why do you think it is v6?
Oh, didn't see Rob's bot reply to v7 before.
>
> >
> > v7 fixes the errors reported, by using glink-edge instead of smd-edge.
> >
> > Looking at all QCOM SoCs that have fastrpc node in devicetree, they all
> > seem to be using glink-edge.
>
> I was not talking about these errors (they were separate issue). I am
> talking about wrong path error.
>
Yes, got it now. Will resend.
> >
> >>
> >> You also need to fix qcom,glink-edge.yaml
> >>
> >
> > I don't see why, with the changes I made in v7, there are no errors
> > anymore.
>
> There are, but not from tooling. The error is wrong path. It should be
> converted to proper schema $ref.
Sure. Will do.
Thanks!
>
> Best regards,
> Krzysztof
prev parent reply other threads:[~2022-09-06 8:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-05 14:45 [PATCH v7 1/2] dt-bindings: misc: fastrpc convert bindings to yaml Abel Vesa
2022-09-05 14:45 ` [PATCH v7 2/2] MAINTAINERS: Update fastrpc documentation file from txt " Abel Vesa
2022-09-06 6:27 ` Krzysztof Kozlowski
2022-09-06 2:29 ` [PATCH v7 1/2] dt-bindings: misc: fastrpc convert bindings " Rob Herring
2022-09-06 6:45 ` Krzysztof Kozlowski
2022-09-06 8:29 ` Abel Vesa
2022-09-06 8:36 ` Krzysztof Kozlowski
2022-09-06 8:46 ` Abel Vesa [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YxcIyRadKQN+BmRe@linaro.org \
--to=abel.vesa@linaro.org \
--cc=agross@kernel.org \
--cc=amahesh@qti.qualcomm.com \
--cc=andersson@kernel.org \
--cc=david@ixit.cz \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@somainline.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).