From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4AF60C54EE9 for ; Tue, 6 Sep 2022 19:15:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229803AbiIFTPA (ORCPT ); Tue, 6 Sep 2022 15:15:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40970 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229795AbiIFTO7 (ORCPT ); Tue, 6 Sep 2022 15:14:59 -0400 Received: from mail-wr1-x433.google.com (mail-wr1-x433.google.com [IPv6:2a00:1450:4864:20::433]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0FCF9786FE for ; Tue, 6 Sep 2022 12:14:56 -0700 (PDT) Received: by mail-wr1-x433.google.com with SMTP id t7so11870374wrm.10 for ; Tue, 06 Sep 2022 12:14:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date; bh=gvPESzLpY6u1LTvkQ/VxBL4ihvtg/iVVRexp1JQT68U=; b=Sh4U0KNGDRZAxg+JbByc/lzJN+bGHvkdKKkJXcCga0+Bj12T2UqdTB621WApI7xgC+ WBUeQfUtfRFxSkGndQmM/gmJJDhBWgx3B7zJcd35kCxO0Y69kWfMEzLRz+HL3KsoRKbo ugYXLb5xQAyTKNlq6TGbHjnNsCFtukxZnI8n61xNUCohMd7sCpiln7H/ZIsQd97XTAYM GnJNRYGyQKm9Tmo8Bs1UNMbxpZcdWHMGxB/eGiutPhz06yFS0ML8lMvALRZYJd7q0L2b dqNe3TDc5gR2jyYHcXsM1Fz1WqYln+TYsMS9d8woX2ta7NHqDH7yTpjccSP3EoGgug1g RYaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date; bh=gvPESzLpY6u1LTvkQ/VxBL4ihvtg/iVVRexp1JQT68U=; b=lpaUOkdH0aO0GT1Hp2SR59lQJkSMzu+bgBS1XxjIW1gBRlKzw+GNhr6B8RE/YYkIu6 eGTCF/FbWFzl8EUGkhCiZsSOE0VCvvz2gwBIgsXls7G0MzCvsdsDf1iDDImMqwG1Wd9z jHA3AXVj7szJ3MgnwxW8U1KhOmW6BIM5QOibO7woqCF7jC26zGkLRDpWG7SMVrPcF9Pl rfnm1YXaPeV0fdoXw0D9V5bBhkaPbvM3o5V9BT7+5qN8T4QiZ3dYF6QhnxuP33fuJeow lavXc4L8Ka/cm/SuYNjgtF3YRSRMGIQFI9P7KDRfB1B/F2Xz+yggh3kUE24QNbLuHPPW iCvw== X-Gm-Message-State: ACgBeo1ZVBBdMDHU15/woxFt6vSHDmh3/BjZcTQzVvtgRTBkBrau4UvR oN3BaOKa59S2qu1U+xSdQ8OLko2TncgQTaLw X-Google-Smtp-Source: AA6agR5tbpF5Im0z0sX3351+86BY/+/J5/WwQY/7WYGKoBmH8Zb4TyiSySEMo03H3BdwA9/7GZCTHg== X-Received: by 2002:adf:fa52:0:b0:228:9675:e6f3 with SMTP id y18-20020adffa52000000b002289675e6f3mr6015259wrr.151.1662491695375; Tue, 06 Sep 2022 12:14:55 -0700 (PDT) Received: from linaro.org ([94.52.112.99]) by smtp.gmail.com with ESMTPSA id z11-20020a056000110b00b00228dcf471e8sm2341788wrw.56.2022.09.06.12.14.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Sep 2022 12:14:54 -0700 (PDT) Date: Tue, 6 Sep 2022 22:14:52 +0300 From: Abel Vesa To: Krzysztof Kozlowski Cc: Srinivas Kandagatla , Amol Maheshwari , Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Herring , Mathieu Poirier , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, Linux Kernel Mailing List , linux-remoteproc@vger.kernel.org, David Heidelberg Subject: Re: [PATCH v11] dt-bindings: misc: fastrpc convert bindings to yaml Message-ID: References: <20220906150102.3399115-1-abel.vesa@linaro.org> <67657fa4-4b15-da4c-db3a-907b2a5b6d92@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <67657fa4-4b15-da4c-db3a-907b2a5b6d92@linaro.org> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 22-09-06 18:12:51, Krzysztof Kozlowski wrote: > On 06/09/2022 17:01, Abel Vesa wrote: > > Convert Qualcomm FastRPC bindings to yaml format, so that we could validate > > dt-entries correctly and any future additions can go into yaml format. > > > > Thank you for your patch. There is something to discuss/improve. > > > + > > +patternProperties: > > + "(compute-)?cb@[0-9]*$": > > + type: object > > + > > + description: > > > + Each subnode of the Fastrpc represents compute context banks available on the dsp. > > + > > + properties: > > + compatible: > > + const: qcom,fastrpc-compute-cb > > + > > + reg: > > + maxItems: 1 > > + > > + qcom,nsession: > > + $ref: /schemas/types.yaml#/definitions/uint32 > > + default: 1 > > + description: > > > + A value indicating how many sessions can share this context bank. > > + > > + required: > > + - compatible > > + - reg > > I think this was pointed previously by Rob in v4 - you need here > additionalProperties: false (on that level of indentation). Ugh, I thought if the check doesn't complain, it is not necessary to add it as false. Will resend. > > > + > > +required: > > + - compatible > > + - label > > + - "#address-cells" > > + - "#size-cells" > > + > > > Best regards, > Krzysztof