From: Patrick Williams <patrick@stwcx.xyz>
To: Karthikeyan Pasupathi <pkarthikeyan1509@gmail.com>
Cc: Rob Herring <robh+dt@kernel.org>, Joel Stanley <joel@jms.id.au>,
Andrew Jeffery <andrew@aj.id.au>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org,
openbmc@lists.ozlabs.org, kernel test robot <lkp@intel.com>
Subject: Re: [PATCH v4] ARM: dts: aspeed: yosemit V2: Enable OCP debug card
Date: Fri, 23 Sep 2022 16:52:33 -0500 [thread overview]
Message-ID: <Yy4qofFUIxudLxbS@heinlein> (raw)
In-Reply-To: <20220921064309.GA18932@hcl-ThinkPad-T495>
[-- Attachment #1: Type: text/plain, Size: 1642 bytes --]
> Subject: [PATCH v4] ARM: dts: aspeed: yosemit V2: Enable OCP debug card
Please double-check your spelling of commit messages. You've misspelled
"yosemite" here, which gives an impression that it is quite likely that
other things are wrong with your commit.
On Wed, Sep 21, 2022 at 12:13:09PM +0530, Karthikeyan Pasupathi wrote:
> Added IPMB-13 channel for Debug Card communication.
> which improve the readability of the machine and makes
> easier to debug the server. and it will display the some
> informations about the server like "system info",
> "Critical sensors" and "critical sel".
>
> ---
> --- v4- Resolved syntax error
> --- v3- Updated the title and commit
> --- v2- Updated the title
> --- v1- Initial draft
> ---
>
> Signed-off-by: Karthikeyan Pasupathi <pkarthikeyan1509@gmail.com>
> ---
> arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts b/arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts
> index 8864e9c312a8..84236df522dc 100644
> --- a/arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts
> +++ b/arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts
> @@ -215,6 +215,17 @@
> };
> };
>
> +&i2c13 {
> + status = "okay";
> + // Debug Card
> + multi-master;
> + ipmb13@10 {
> + compatible = "ipmb-dev";
> + reg = <(0x10 | I2C_OWN_SLAVE_ADDRESS)>;
> + i2c-protocol;
> + };
> +};
> +
> &pwm_tacho {
> status = "okay";
> //FSC
> --
> 2.17.1
>
Reviewed-by: Patrick Williams <patrick@stwcx.xyz>
--
Patrick Williams
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2022-09-23 21:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-21 6:43 [PATCH v4] ARM: dts: aspeed: yosemit V2: Enable OCP debug card Karthikeyan Pasupathi
2022-09-23 21:52 ` Patrick Williams [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yy4qofFUIxudLxbS@heinlein \
--to=patrick@stwcx.xyz \
--cc=andrew@aj.id.au \
--cc=devicetree@vger.kernel.org \
--cc=joel@jms.id.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=openbmc@lists.ozlabs.org \
--cc=pkarthikeyan1509@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).