* [PATCH 1/2] dt-bindings: phy: qcom,qmp-usb: add missing power-domains property
2022-09-02 8:07 [PATCH 0/2] dt-bindings: phy: qcom,qmp: add missing power-domains properties Johan Hovold
@ 2022-09-02 8:07 ` Johan Hovold
2022-09-07 21:03 ` Rob Herring
2022-09-02 8:07 ` [PATCH 2/2] dt-bindings: phy: qcom,qmp-usb3-dp: " Johan Hovold
2022-09-13 14:35 ` [PATCH 0/2] dt-bindings: phy: qcom,qmp: add missing power-domains properties Vinod Koul
2 siblings, 1 reply; 6+ messages in thread
From: Johan Hovold @ 2022-09-02 8:07 UTC (permalink / raw)
To: Vinod Koul
Cc: Rob Herring, Krzysztof Kozlowski, Andy Gross, Bjorn Andersson,
Konrad Dybcio, Kishon Vijay Abraham I, Wesley Cheng,
linux-arm-msm, linux-phy, devicetree, linux-kernel, Johan Hovold
At least the "sc8280xp-qmp-usb3-uni-phy" binding requires a power domain
to be specified.
Fixes: aa27597e594c ("dt-bindings: phy: qcom,qmp: Add compatible for SC8280XP USB phys")
Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
---
.../devicetree/bindings/phy/qcom,qmp-usb-phy.yaml | 13 +++++++++++++
1 file changed, 13 insertions(+)
diff --git a/Documentation/devicetree/bindings/phy/qcom,qmp-usb-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,qmp-usb-phy.yaml
index 25e01ec4799d..7acb4b7de7f9 100644
--- a/Documentation/devicetree/bindings/phy/qcom,qmp-usb-phy.yaml
+++ b/Documentation/devicetree/bindings/phy/qcom,qmp-usb-phy.yaml
@@ -58,6 +58,9 @@ properties:
minItems: 3
maxItems: 4
+ power-domains:
+ maxItems: 1
+
resets:
maxItems: 2
@@ -265,6 +268,16 @@ allOf:
- const: phy_phy
- const: phy
+ - if:
+ properties:
+ compatible:
+ contains:
+ enum:
+ - qcom,sc8280xp-qmp-usb3-uni-phy
+ then:
+ required:
+ - power-domains
+
- if:
properties:
compatible:
--
2.35.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH 1/2] dt-bindings: phy: qcom,qmp-usb: add missing power-domains property
2022-09-02 8:07 ` [PATCH 1/2] dt-bindings: phy: qcom,qmp-usb: add missing power-domains property Johan Hovold
@ 2022-09-07 21:03 ` Rob Herring
0 siblings, 0 replies; 6+ messages in thread
From: Rob Herring @ 2022-09-07 21:03 UTC (permalink / raw)
To: Johan Hovold
Cc: linux-kernel, Bjorn Andersson, Vinod Koul, Rob Herring,
Konrad Dybcio, Kishon Vijay Abraham I, Wesley Cheng,
linux-arm-msm, linux-phy, devicetree, Andy Gross,
Krzysztof Kozlowski
On Fri, 02 Sep 2022 10:07:04 +0200, Johan Hovold wrote:
> At least the "sc8280xp-qmp-usb3-uni-phy" binding requires a power domain
> to be specified.
>
> Fixes: aa27597e594c ("dt-bindings: phy: qcom,qmp: Add compatible for SC8280XP USB phys")
> Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
> ---
> .../devicetree/bindings/phy/qcom,qmp-usb-phy.yaml | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 2/2] dt-bindings: phy: qcom,qmp-usb3-dp: add missing power-domains property
2022-09-02 8:07 [PATCH 0/2] dt-bindings: phy: qcom,qmp: add missing power-domains properties Johan Hovold
2022-09-02 8:07 ` [PATCH 1/2] dt-bindings: phy: qcom,qmp-usb: add missing power-domains property Johan Hovold
@ 2022-09-02 8:07 ` Johan Hovold
2022-09-07 21:04 ` Rob Herring
2022-09-13 14:35 ` [PATCH 0/2] dt-bindings: phy: qcom,qmp: add missing power-domains properties Vinod Koul
2 siblings, 1 reply; 6+ messages in thread
From: Johan Hovold @ 2022-09-02 8:07 UTC (permalink / raw)
To: Vinod Koul
Cc: Rob Herring, Krzysztof Kozlowski, Andy Gross, Bjorn Andersson,
Konrad Dybcio, Kishon Vijay Abraham I, Wesley Cheng,
linux-arm-msm, linux-phy, devicetree, linux-kernel, Johan Hovold
At least the "qcom,sc8280xp-qmp-usb43dp-phy" binding requires a power
domain to be specified.
Fixes: aa27597e594c ("dt-bindings: phy: qcom,qmp: Add compatible for SC8280XP USB phys")
Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
---
.../bindings/phy/qcom,qmp-usb3-dp-phy.yaml | 14 ++++++++++++++
1 file changed, 14 insertions(+)
diff --git a/Documentation/devicetree/bindings/phy/qcom,qmp-usb3-dp-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,qmp-usb3-dp-phy.yaml
index abc29686dff6..97a7ecafbf85 100644
--- a/Documentation/devicetree/bindings/phy/qcom,qmp-usb3-dp-phy.yaml
+++ b/Documentation/devicetree/bindings/phy/qcom,qmp-usb3-dp-phy.yaml
@@ -53,6 +53,9 @@ properties:
- const: ref
- const: com_aux
+ power-domains:
+ maxItems: 1
+
resets:
items:
- description: reset of phy block.
@@ -159,6 +162,17 @@ required:
additionalProperties: false
+allOf:
+ - if:
+ properties:
+ compatible:
+ contains:
+ enum:
+ - qcom,sc8280xp-qmp-usb43dp-phy
+ then:
+ required:
+ - power-domains
+
examples:
- |
#include <dt-bindings/clock/qcom,gcc-sdm845.h>
--
2.35.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH 2/2] dt-bindings: phy: qcom,qmp-usb3-dp: add missing power-domains property
2022-09-02 8:07 ` [PATCH 2/2] dt-bindings: phy: qcom,qmp-usb3-dp: " Johan Hovold
@ 2022-09-07 21:04 ` Rob Herring
0 siblings, 0 replies; 6+ messages in thread
From: Rob Herring @ 2022-09-07 21:04 UTC (permalink / raw)
To: Johan Hovold
Cc: Krzysztof Kozlowski, Bjorn Andersson, devicetree, Vinod Koul,
Konrad Dybcio, linux-arm-msm, linux-phy, linux-kernel,
Rob Herring, Andy Gross, Wesley Cheng, Kishon Vijay Abraham I
On Fri, 02 Sep 2022 10:07:05 +0200, Johan Hovold wrote:
> At least the "qcom,sc8280xp-qmp-usb43dp-phy" binding requires a power
> domain to be specified.
>
> Fixes: aa27597e594c ("dt-bindings: phy: qcom,qmp: Add compatible for SC8280XP USB phys")
> Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
> ---
> .../bindings/phy/qcom,qmp-usb3-dp-phy.yaml | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 0/2] dt-bindings: phy: qcom,qmp: add missing power-domains properties
2022-09-02 8:07 [PATCH 0/2] dt-bindings: phy: qcom,qmp: add missing power-domains properties Johan Hovold
2022-09-02 8:07 ` [PATCH 1/2] dt-bindings: phy: qcom,qmp-usb: add missing power-domains property Johan Hovold
2022-09-02 8:07 ` [PATCH 2/2] dt-bindings: phy: qcom,qmp-usb3-dp: " Johan Hovold
@ 2022-09-13 14:35 ` Vinod Koul
2 siblings, 0 replies; 6+ messages in thread
From: Vinod Koul @ 2022-09-13 14:35 UTC (permalink / raw)
To: Johan Hovold
Cc: Rob Herring, Krzysztof Kozlowski, Andy Gross, Bjorn Andersson,
Konrad Dybcio, Kishon Vijay Abraham I, Wesley Cheng,
linux-arm-msm, linux-phy, devicetree, linux-kernel
On 02-09-22, 10:07, Johan Hovold wrote:
> The new SC8280XP USB PHYs require a power domain to be specified so
> amend the bindings.
Applied, thanks
--
~Vinod
^ permalink raw reply [flat|nested] 6+ messages in thread