Re: [PATCH 09/11] dt-bindings: input: iqs7222: Allow 'linux,code' to be optional

Jeff LaBundy
2022-09-13T13:47:22Z

Hi Rob,

Thank you for taking a look.

On Tue, Sep 13, 2022 at 06:42:49AM -0500, Rob Herring wrote:
> On Thu, Sep 08, 2022 at 08:15:46AM -0500, Jeff LaBundy wrote:
> > The 'linux,code' property has been made optional in the driver;
> > update the binding to reflect this change.
>
> But with an old kernel, it would still be required. So still required in
> the DT.

For v2 of this series, the corresponding driver change will be
absorbed in a patch intended for -stable; the refactoring just
worked out that way.

In that case, even older kernels would drop this requirement,
so I will keep the patch. In case I misunderstood your comment,
please let me know.

>
> >
> > Fixes: 44dc42d254bf ("dt-bindings: input: Add bindings for Azoteq IQS7222A/B/C")
> > Signed-off-by: Jeff LaBundy <jeff@labundy.com>
> > ---
> > Documentation/devicetree/bindings/input/azoteq,iqs7222.yaml | 6 ------
> > 1 file changed, 6 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/input/azoteq,iqs7222.yaml b/Documentation/devicetree/bindings/input/azoteq,iqs7222.yaml
> > index 785fb9e83354..913fd2da9862 100644
> > --- a/Documentation/devicetree/bindings/input/azoteq,iqs7222.yaml
> > +++ b/Documentation/devicetree/bindings/input/azoteq,iqs7222.yaml
> > @@ -473,9 +473,6 @@ patternProperties:
> > Specifies whether the event is to be interpreted as a key (1)
> > or a switch (5).
> >
> > - required:
> > - - linux,code
> > -
> > additionalProperties: false
> >
> > dependencies:
> > @@ -620,9 +617,6 @@ patternProperties:
> > GPIO, they must all be of the same type (proximity, touch or
> > slider gesture).
> >
> > - required:
> > - - linux,code
> > -
> > additionalProperties: false
> >
> > required:
> > --
> > 2.25.1
> >
> >

Kind regards,
Jeff LaBundy