From: Andrew Lunn <andrew@lunn.ch>
To: "Pali Rohár" <pali@kernel.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Gregory Clement <gregory.clement@bootlin.com>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
Marcin Wojtas <mw@semihalf.com>,
alsa-devel@alsa-project.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/5] ASoC: kirkwood: enable Kirkwood driver for Armada 38x platforms
Date: Tue, 20 Sep 2022 15:39:18 +0200 [thread overview]
Message-ID: <YynChnIJe3SZUUW5@lunn.ch> (raw)
In-Reply-To: <20220920132648.2008-2-pali@kernel.org>
> + if (of_device_is_compatible(np, "marvell,armada-380-audio")) {
> + err = armada_38x_i2s_init_quirk(pdev, priv, soc_dai);
> + /* Set initial pll frequency */
> + if (priv->pll_config)
> + armada_38x_set_pll(priv->pll_config, 44100);
> + if (err < 0)
> + return err;
A nitpick: It would be better to do the test for err before calling
armada_38x_set_pll(), and then there is no need for the NULL check.
Andrew
next prev parent reply other threads:[~2022-09-20 13:39 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-20 13:26 [PATCH 0/5] ARM: mvebu: Add audio support for Armada 38x Pali Rohár
2022-09-20 13:26 ` [PATCH 1/5] ASoC: kirkwood: enable Kirkwood driver for Armada 38x platforms Pali Rohár
2022-09-20 13:39 ` Andrew Lunn [this message]
2022-09-26 19:48 ` Rob Herring
2022-09-26 20:04 ` Andrew Lunn
2022-09-20 13:26 ` [PATCH 2/5] ARM: mvebu: add audio I2S controller to Armada 38x Device Tree Pali Rohár
2022-09-20 13:40 ` Andrew Lunn
2022-09-20 13:26 ` [PATCH 3/5] ARM: mvebu: add audio support to Armada 385 DB Pali Rohár
2022-09-20 13:41 ` Andrew Lunn
2022-09-20 13:26 ` [PATCH 4/5] ARM: mvebu: Add spdif-pins mpp pins for Armada 38x Pali Rohár
2022-09-20 13:41 ` Andrew Lunn
2022-09-20 13:26 ` [PATCH 5/5] ARM: dts: turris-omnia: Define S/PDIF audio card Pali Rohár
2022-09-20 13:42 ` Andrew Lunn
2022-09-23 15:14 ` [PATCH 0/5] ARM: mvebu: Add audio support for Armada 38x Gregory CLEMENT
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YynChnIJe3SZUUW5@lunn.ch \
--to=andrew@lunn.ch \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregory.clement@bootlin.com \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mw@semihalf.com \
--cc=pali@kernel.org \
--cc=sebastian.hesselbarth@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).