Re: [PATCH v4 2/3] arm64: dts: qcom: sa8295p: move common nodes to dtsi

[Johan Hovold <johan@kernel.org>]

[ Resending with Bjorn's address updated. ]

On Tue, Sep 20, 2022 at 05:38:01PM +0530, Parikshit Pareek wrote:
> There are many ADP boards with lot of common features. Move common
> nodes to sa8540p-adp.dtsi file. This will be base for many ADP boards
> to be introduced in near future.

I already asked you to include a description of those differences here
in the commit message so that we can make a decision on whether this
change makes sense or not.

This also needs to be documented for future changes. For example, when
I'll be adding PCIe support to sa8295p-adp I'd need to know whether this
should go in a shared dtsi or in the board file.

For reasons like this, I'm still not convinced that this is a good idea.

> Signed-off-by: Parikshit Pareek <quic_ppareek@quicinc.com>
> ---
>  arch/arm64/boot/dts/qcom/sa8295p-adp.dts      | 392 +-----------------
>  .../{sa8295p-adp.dts => sa8540p-adp.dtsi}     |   0
>  2 files changed, 14 insertions(+), 378 deletions(-)
>  rewrite arch/arm64/boot/dts/qcom/sa8295p-adp.dts (96%)
>  copy arch/arm64/boot/dts/qcom/{sa8295p-adp.dts => sa8540p-adp.dtsi} (100%)

Johan