* [PATCH v4 1/3] dt-bindings: arm: qcom: Document additional sa8540p device
2022-09-20 12:07 [PATCH v4 0/3] arm64: dts: qcom: add dts for sa8540p-ride board Parikshit Pareek
@ 2022-09-20 12:08 ` Parikshit Pareek
2022-09-20 12:08 ` [PATCH v4 2/3] arm64: dts: qcom: sa8295p: move common nodes to dtsi Parikshit Pareek
` (2 subsequent siblings)
3 siblings, 0 replies; 11+ messages in thread
From: Parikshit Pareek @ 2022-09-20 12:08 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski
Cc: linux-arm-msm, devicetree, linux-kernel, Andrew Halaney,
Shazad Hussain, Parikshit Pareek
Add the ADP ride device to the valid device compatibles found on the
sa8540p platform.
Signed-off-by: Parikshit Pareek <quic_ppareek@quicinc.com>
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
Documentation/devicetree/bindings/arm/qcom.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
index 3ab1ff6991bf..c6b802522183 100644
--- a/Documentation/devicetree/bindings/arm/qcom.yaml
+++ b/Documentation/devicetree/bindings/arm/qcom.yaml
@@ -675,6 +675,7 @@ properties:
- items:
- enum:
- qcom,sa8295p-adp
+ - qcom,sa8540p-adp-ride
- const: qcom,sa8540p
- items:
--
2.17.1
^ permalink raw reply related [flat|nested] 11+ messages in thread* [PATCH v4 2/3] arm64: dts: qcom: sa8295p: move common nodes to dtsi
2022-09-20 12:07 [PATCH v4 0/3] arm64: dts: qcom: add dts for sa8540p-ride board Parikshit Pareek
2022-09-20 12:08 ` [PATCH v4 1/3] dt-bindings: arm: qcom: Document additional sa8540p device Parikshit Pareek
@ 2022-09-20 12:08 ` Parikshit Pareek
2022-09-20 15:27 ` Krzysztof Kozlowski
` (2 more replies)
2022-09-20 12:08 ` [PATCH v4 3/3] arm64: dts: qcom: introduce sa8540p-ride dts Parikshit Pareek
2022-09-21 6:39 ` [PATCH v4 0/3] arm64: dts: qcom: add dts for sa8540p-ride board Johan Hovold
3 siblings, 3 replies; 11+ messages in thread
From: Parikshit Pareek @ 2022-09-20 12:08 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski
Cc: linux-arm-msm, devicetree, linux-kernel, Andrew Halaney,
Shazad Hussain, Parikshit Pareek
There are many ADP boards with lot of common features. Move common
nodes to sa8540p-adp.dtsi file. This will be base for many ADP boards
to be introduced in near future.
Signed-off-by: Parikshit Pareek <quic_ppareek@quicinc.com>
---
arch/arm64/boot/dts/qcom/sa8295p-adp.dts | 392 +-----------------
.../{sa8295p-adp.dts => sa8540p-adp.dtsi} | 0
2 files changed, 14 insertions(+), 378 deletions(-)
rewrite arch/arm64/boot/dts/qcom/sa8295p-adp.dts (96%)
copy arch/arm64/boot/dts/qcom/{sa8295p-adp.dts => sa8540p-adp.dtsi} (100%)
diff --git a/arch/arm64/boot/dts/qcom/sa8295p-adp.dts b/arch/arm64/boot/dts/qcom/sa8295p-adp.dts
dissimilarity index 96%
index ca5f5ad32ce5..c6d5b7644c20 100644
--- a/arch/arm64/boot/dts/qcom/sa8295p-adp.dts
+++ b/arch/arm64/boot/dts/qcom/sa8295p-adp.dts
@@ -1,378 +1,14 @@
-// SPDX-License-Identifier: BSD-3-Clause
-/*
- * Copyright (c) 2021, The Linux Foundation. All rights reserved.
- * Copyright (c) 2022, Linaro Limited
- */
-
-/dts-v1/;
-
-#include <dt-bindings/gpio/gpio.h>
-#include <dt-bindings/regulator/qcom,rpmh-regulator.h>
-#include <dt-bindings/spmi/spmi.h>
-
-#include "sa8540p.dtsi"
-
-/ {
- model = "Qualcomm SA8295P ADP";
- compatible = "qcom,sa8295p-adp", "qcom,sa8540p";
-
- aliases {
- serial0 = &qup2_uart17;
- };
-
- chosen {
- stdout-path = "serial0:115200n8";
- };
-};
-
-&apps_rsc {
- pmm8540-a-regulators {
- compatible = "qcom,pm8150-rpmh-regulators";
- qcom,pmic-id = "a";
-
- vreg_l3a: ldo3 {
- regulator-name = "vreg_l3a";
- regulator-min-microvolt = <1200000>;
- regulator-max-microvolt = <1208000>;
- regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
- };
-
- vreg_l5a: ldo5 {
- regulator-name = "vreg_l5a";
- regulator-min-microvolt = <912000>;
- regulator-max-microvolt = <912000>;
- regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
- };
-
- vreg_l7a: ldo7 {
- regulator-name = "vreg_l7a";
- regulator-min-microvolt = <1800000>;
- regulator-max-microvolt = <1800000>;
- regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
- };
-
- vreg_l13a: ldo13 {
- regulator-name = "vreg_l13a";
- regulator-min-microvolt = <3072000>;
- regulator-max-microvolt = <3072000>;
- regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
- };
- };
-
- pmm8540-c-regulators {
- compatible = "qcom,pm8150-rpmh-regulators";
- qcom,pmic-id = "c";
-
- vreg_l1c: ldo1 {
- regulator-name = "vreg_l1c";
- regulator-min-microvolt = <912000>;
- regulator-max-microvolt = <912000>;
- regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
- };
-
- vreg_l2c: ldo2 {
- regulator-name = "vreg_l2c";
- regulator-min-microvolt = <3072000>;
- regulator-max-microvolt = <3072000>;
- regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
- };
-
- vreg_l3c: ldo3 {
- regulator-name = "vreg_l3c";
- regulator-min-microvolt = <1200000>;
- regulator-max-microvolt = <1200000>;
- regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
- regulator-allow-set-load;
- };
-
- vreg_l4c: ldo4 {
- regulator-name = "vreg_l4c";
- regulator-min-microvolt = <1200000>;
- regulator-max-microvolt = <1208000>;
- regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
- };
-
- vreg_l6c: ldo6 {
- regulator-name = "vreg_l6c";
- regulator-min-microvolt = <1200000>;
- regulator-max-microvolt = <1200000>;
- regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
- regulator-allow-set-load;
- };
-
- vreg_l7c: ldo7 {
- regulator-name = "vreg_l7c";
- regulator-min-microvolt = <1800000>;
- regulator-max-microvolt = <1800000>;
- regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
- };
-
- vreg_l10c: ldo10 {
- regulator-name = "vreg_l10c";
- regulator-min-microvolt = <2504000>;
- regulator-max-microvolt = <2504000>;
- regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
- regulator-allow-set-load;
- };
-
- vreg_l17c: ldo17 {
- regulator-name = "vreg_l17c";
- regulator-min-microvolt = <2504000>;
- regulator-max-microvolt = <2504000>;
- regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
- regulator-allow-set-load;
- };
- };
-
- pmm8540-g-regulators {
- compatible = "qcom,pm8150-rpmh-regulators";
- qcom,pmic-id = "g";
-
- vreg_l3g: ldo3 {
- regulator-name = "vreg_l3g";
- regulator-min-microvolt = <1200000>;
- regulator-max-microvolt = <1200000>;
- regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
- };
-
- vreg_l7g: ldo7 {
- regulator-name = "vreg_l7g";
- regulator-min-microvolt = <1800000>;
- regulator-max-microvolt = <1800000>;
- regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
- };
-
- vreg_l8g: ldo8 {
- regulator-name = "vreg_l8g";
- regulator-min-microvolt = <880000>;
- regulator-max-microvolt = <880000>;
- regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
- };
- };
-};
-
-&qup2 {
- status = "okay";
-};
-
-&qup2_uart17 {
- compatible = "qcom,geni-debug-uart";
- status = "okay";
-};
-
-&remoteproc_adsp {
- firmware-name = "qcom/sa8540p/adsp.mbn";
- status = "okay";
-};
-
-&remoteproc_nsp0 {
- firmware-name = "qcom/sa8540p/cdsp.mbn";
- status = "okay";
-};
-
-&remoteproc_nsp1 {
- firmware-name = "qcom/sa8540p/cdsp1.mbn";
- status = "okay";
-};
-
-&spmi_bus {
- pm8450a: pmic@0 {
- compatible = "qcom,pm8150", "qcom,spmi-pmic";
- reg = <0x0 SPMI_USID>;
- #address-cells = <1>;
- #size-cells = <0>;
-
- pm8450a_gpios: gpio@c000 {
- compatible = "qcom,pm8150-gpio";
- reg = <0xc000>;
- gpio-controller;
- #gpio-cells = <2>;
- interrupt-controller;
- #interrupt-cells = <2>;
- };
- };
-
- pm8450c: pmic@4 {
- compatible = "qcom,pm8150", "qcom,spmi-pmic";
- reg = <0x4 SPMI_USID>;
- #address-cells = <1>;
- #size-cells = <0>;
-
- pm8450c_gpios: gpio@c000 {
- compatible = "qcom,pm8150-gpio";
- reg = <0xc000>;
- gpio-controller;
- #gpio-cells = <2>;
- interrupt-controller;
- #interrupt-cells = <2>;
- };
- };
-
- pm8450e: pmic@8 {
- compatible = "qcom,pm8150", "qcom,spmi-pmic";
- reg = <0x8 SPMI_USID>;
- #address-cells = <1>;
- #size-cells = <0>;
-
- pm8450e_gpios: gpio@c000 {
- compatible = "qcom,pm8150-gpio";
- reg = <0xc000>;
- gpio-controller;
- #gpio-cells = <2>;
- interrupt-controller;
- #interrupt-cells = <2>;
- };
- };
-
- pm8450g: pmic@c {
- compatible = "qcom,pm8150", "qcom,spmi-pmic";
- reg = <0xc SPMI_USID>;
- #address-cells = <1>;
- #size-cells = <0>;
-
- pm8450g_gpios: gpio@c000 {
- compatible = "qcom,pm8150-gpio";
- reg = <0xc000>;
- gpio-controller;
- #gpio-cells = <2>;
- interrupt-controller;
- #interrupt-cells = <2>;
- };
- };
-};
-
-&ufs_mem_hc {
- reset-gpios = <&tlmm 228 GPIO_ACTIVE_LOW>;
-
- vcc-supply = <&vreg_l17c>;
- vcc-max-microamp = <800000>;
- vccq-supply = <&vreg_l6c>;
- vccq-max-microamp = <900000>;
-
- status = "okay";
-};
-
-&ufs_mem_phy {
- vdda-phy-supply = <&vreg_l8g>;
- vdda-pll-supply = <&vreg_l3g>;
-
- status = "okay";
-};
-
-&ufs_card_hc {
- reset-gpios = <&tlmm 229 GPIO_ACTIVE_LOW>;
-
- vcc-supply = <&vreg_l10c>;
- vcc-max-microamp = <800000>;
- vccq-supply = <&vreg_l3c>;
- vccq-max-microamp = <900000>;
-
- status = "okay";
-};
-
-&ufs_card_phy {
- vdda-phy-supply = <&vreg_l8g>;
- vdda-pll-supply = <&vreg_l3g>;
-
- status = "okay";
-};
-
-&usb_0 {
- status = "okay";
-};
-
-&usb_0_dwc3 {
- /* TODO: Define USB-C connector properly */
- dr_mode = "peripheral";
-};
-
-&usb_0_hsphy {
- vdda-pll-supply = <&vreg_l5a>;
- vdda18-supply = <&vreg_l7a>;
- vdda33-supply = <&vreg_l13a>;
-
- status = "okay";
-};
-
-&usb_0_qmpphy {
- vdda-phy-supply = <&vreg_l3a>;
- vdda-pll-supply = <&vreg_l5a>;
-
- status = "okay";
-};
-
-&usb_1 {
- status = "okay";
-};
-
-&usb_1_dwc3 {
- /* TODO: Define USB-C connector properly */
- dr_mode = "host";
-};
-
-&usb_1_hsphy {
- vdda-pll-supply = <&vreg_l1c>;
- vdda18-supply = <&vreg_l7c>;
- vdda33-supply = <&vreg_l2c>;
-
- status = "okay";
-};
-
-&usb_1_qmpphy {
- vdda-phy-supply = <&vreg_l4c>;
- vdda-pll-supply = <&vreg_l1c>;
-
- status = "okay";
-};
-
-&usb_2_hsphy0 {
- vdda-pll-supply = <&vreg_l5a>;
- vdda18-supply = <&vreg_l7g>;
- vdda33-supply = <&vreg_l13a>;
-
- status = "okay";
-};
-
-&usb_2_hsphy1 {
- vdda-pll-supply = <&vreg_l5a>;
- vdda18-supply = <&vreg_l7g>;
- vdda33-supply = <&vreg_l13a>;
-
- status = "okay";
-};
-
-&usb_2_hsphy2 {
- vdda-pll-supply = <&vreg_l5a>;
- vdda18-supply = <&vreg_l7g>;
- vdda33-supply = <&vreg_l13a>;
-
- status = "okay";
-};
-
-&usb_2_hsphy3 {
- vdda-pll-supply = <&vreg_l5a>;
- vdda18-supply = <&vreg_l7g>;
- vdda33-supply = <&vreg_l13a>;
-
- status = "okay";
-};
-
-&usb_2_qmpphy0 {
- vdda-phy-supply = <&vreg_l3a>;
- vdda-pll-supply = <&vreg_l5a>;
-
- status = "okay";
-};
-
-&usb_2_qmpphy1 {
- vdda-phy-supply = <&vreg_l3a>;
- vdda-pll-supply = <&vreg_l5a>;
-
- status = "okay";
-};
-
-&xo_board_clk {
- clock-frequency = <38400000>;
-};
-
-/* PINCTRL */
+// SPDX-License-Identifier: BSD-3-Clause
+/*
+ * Copyright (c) 2021, The Linux Foundation. All rights reserved.
+ * Copyright (c) 2022, Linaro Limited
+ */
+
+/dts-v1/;
+
+#include "sa8540p-adp.dtsi"
+
+/ {
+ model = "Qualcomm SA8295P ADP";
+ compatible = "qcom,sa8295p-adp", "qcom,sa8540p";
+};
diff --git a/arch/arm64/boot/dts/qcom/sa8295p-adp.dts b/arch/arm64/boot/dts/qcom/sa8540p-adp.dtsi
similarity index 100%
copy from arch/arm64/boot/dts/qcom/sa8295p-adp.dts
copy to arch/arm64/boot/dts/qcom/sa8540p-adp.dtsi
--
2.17.1
^ permalink raw reply related [flat|nested] 11+ messages in thread* Re: [PATCH v4 2/3] arm64: dts: qcom: sa8295p: move common nodes to dtsi
2022-09-20 12:08 ` [PATCH v4 2/3] arm64: dts: qcom: sa8295p: move common nodes to dtsi Parikshit Pareek
@ 2022-09-20 15:27 ` Krzysztof Kozlowski
2022-09-21 6:48 ` Johan Hovold
2022-09-21 7:06 ` Johan Hovold
2 siblings, 0 replies; 11+ messages in thread
From: Krzysztof Kozlowski @ 2022-09-20 15:27 UTC (permalink / raw)
To: Parikshit Pareek, Andy Gross, Bjorn Andersson, Konrad Dybcio,
Rob Herring, Krzysztof Kozlowski
Cc: linux-arm-msm, devicetree, linux-kernel, Andrew Halaney,
Shazad Hussain
On 20/09/2022 14:08, Parikshit Pareek wrote:
> There are many ADP boards with lot of common features. Move common
> nodes to sa8540p-adp.dtsi file. This will be base for many ADP boards
> to be introduced in near future.
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v4 2/3] arm64: dts: qcom: sa8295p: move common nodes to dtsi
2022-09-20 12:08 ` [PATCH v4 2/3] arm64: dts: qcom: sa8295p: move common nodes to dtsi Parikshit Pareek
2022-09-20 15:27 ` Krzysztof Kozlowski
@ 2022-09-21 6:48 ` Johan Hovold
2022-09-21 7:06 ` Johan Hovold
2 siblings, 0 replies; 11+ messages in thread
From: Johan Hovold @ 2022-09-21 6:48 UTC (permalink / raw)
To: Parikshit Pareek
Cc: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, linux-arm-msm, devicetree, linux-kernel,
Andrew Halaney, Shazad Hussain
On Tue, Sep 20, 2022 at 05:38:01PM +0530, Parikshit Pareek wrote:
> There are many ADP boards with lot of common features. Move common
> nodes to sa8540p-adp.dtsi file. This will be base for many ADP boards
> to be introduced in near future.
I already asked you to include a description of those differences here
in the commit message so that we can make a decision on whether this
change makes sense or not.
This also needs to be documented for future changes. For example, when
I'll be adding PCIe support to sa8295p-adp I'd need to know whether this
should go in a shared dtsi or in the board file.
For reasons like this, I'm still not convinced that this is a good idea.
> Signed-off-by: Parikshit Pareek <quic_ppareek@quicinc.com>
> ---
> arch/arm64/boot/dts/qcom/sa8295p-adp.dts | 392 +-----------------
> .../{sa8295p-adp.dts => sa8540p-adp.dtsi} | 0
> 2 files changed, 14 insertions(+), 378 deletions(-)
> rewrite arch/arm64/boot/dts/qcom/sa8295p-adp.dts (96%)
> copy arch/arm64/boot/dts/qcom/{sa8295p-adp.dts => sa8540p-adp.dtsi} (100%)
Johan
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PATCH v4 2/3] arm64: dts: qcom: sa8295p: move common nodes to dtsi
2022-09-20 12:08 ` [PATCH v4 2/3] arm64: dts: qcom: sa8295p: move common nodes to dtsi Parikshit Pareek
2022-09-20 15:27 ` Krzysztof Kozlowski
2022-09-21 6:48 ` Johan Hovold
@ 2022-09-21 7:06 ` Johan Hovold
2 siblings, 0 replies; 11+ messages in thread
From: Johan Hovold @ 2022-09-21 7:06 UTC (permalink / raw)
To: Parikshit Pareek, Bjorn Andersson
Cc: Andy Gross, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
linux-arm-msm, devicetree, linux-kernel, Andrew Halaney,
Shazad Hussain
[ Resending with Bjorn's address updated. ]
On Tue, Sep 20, 2022 at 05:38:01PM +0530, Parikshit Pareek wrote:
> There are many ADP boards with lot of common features. Move common
> nodes to sa8540p-adp.dtsi file. This will be base for many ADP boards
> to be introduced in near future.
I already asked you to include a description of those differences here
in the commit message so that we can make a decision on whether this
change makes sense or not.
This also needs to be documented for future changes. For example, when
I'll be adding PCIe support to sa8295p-adp I'd need to know whether this
should go in a shared dtsi or in the board file.
For reasons like this, I'm still not convinced that this is a good idea.
> Signed-off-by: Parikshit Pareek <quic_ppareek@quicinc.com>
> ---
> arch/arm64/boot/dts/qcom/sa8295p-adp.dts | 392 +-----------------
> .../{sa8295p-adp.dts => sa8540p-adp.dtsi} | 0
> 2 files changed, 14 insertions(+), 378 deletions(-)
> rewrite arch/arm64/boot/dts/qcom/sa8295p-adp.dts (96%)
> copy arch/arm64/boot/dts/qcom/{sa8295p-adp.dts => sa8540p-adp.dtsi} (100%)
Johan
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH v4 3/3] arm64: dts: qcom: introduce sa8540p-ride dts
2022-09-20 12:07 [PATCH v4 0/3] arm64: dts: qcom: add dts for sa8540p-ride board Parikshit Pareek
2022-09-20 12:08 ` [PATCH v4 1/3] dt-bindings: arm: qcom: Document additional sa8540p device Parikshit Pareek
2022-09-20 12:08 ` [PATCH v4 2/3] arm64: dts: qcom: sa8295p: move common nodes to dtsi Parikshit Pareek
@ 2022-09-20 12:08 ` Parikshit Pareek
2022-09-20 15:27 ` Krzysztof Kozlowski
2022-09-21 6:51 ` Johan Hovold
2022-09-21 6:39 ` [PATCH v4 0/3] arm64: dts: qcom: add dts for sa8540p-ride board Johan Hovold
3 siblings, 2 replies; 11+ messages in thread
From: Parikshit Pareek @ 2022-09-20 12:08 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski
Cc: linux-arm-msm, devicetree, linux-kernel, Andrew Halaney,
Shazad Hussain, Parikshit Pareek
Create new dts file specific for Qdrive board based on sa8540p chipset.
Introduce common dtsi file sa8295p-adp.dtsi, to be included for adp and
Qdrive board.
This is quite similar to sa8295 ADP development board. Main differences
are related to connectors, and interface cards, like USB external ports,
ethernet-switch, and PCIe switch etc.
Signed-off-by: Parikshit Pareek <quic_ppareek@quicinc.com>
Reported-by: Shazad Hussain <quic_shazhuss@quicinc.com>
---
arch/arm64/boot/dts/qcom/Makefile | 1 +
arch/arm64/boot/dts/qcom/sa8540p-adp-ride.dts | 31 +++++++++++++++++++
2 files changed, 32 insertions(+)
create mode 100644 arch/arm64/boot/dts/qcom/sa8540p-adp-ride.dts
diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile
index 68a172c4c748..e30d2a958937 100644
--- a/arch/arm64/boot/dts/qcom/Makefile
+++ b/arch/arm64/boot/dts/qcom/Makefile
@@ -54,6 +54,7 @@ dtb-$(CONFIG_ARCH_QCOM) += qcs404-evb-4000.dtb
dtb-$(CONFIG_ARCH_QCOM) += qrb5165-rb5.dtb
dtb-$(CONFIG_ARCH_QCOM) += sa8155p-adp.dtb
dtb-$(CONFIG_ARCH_QCOM) += sa8295p-adp.dtb
+dtb-$(CONFIG_ARCH_QCOM) += sa8540p-adp-ride.dtb
dtb-$(CONFIG_ARCH_QCOM) += sc7180-idp.dtb
dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-coachz-r1.dtb
dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-coachz-r1-lte.dtb
diff --git a/arch/arm64/boot/dts/qcom/sa8540p-adp-ride.dts b/arch/arm64/boot/dts/qcom/sa8540p-adp-ride.dts
new file mode 100644
index 000000000000..bd79866b80e1
--- /dev/null
+++ b/arch/arm64/boot/dts/qcom/sa8540p-adp-ride.dts
@@ -0,0 +1,31 @@
+// SPDX-License-Identifier: BSD-3-Clause
+/*
+ * Copyright (c) 2021, The Linux Foundation. All rights reserved.
+ * Copyright (c) 2022, Linaro Limited
+ * Copyright (c) 2022, Qualcomm Innovation Center, Inc. All rights reserved.
+ */
+
+/dts-v1/;
+
+#include "sa8540p-adp.dtsi"
+
+/ {
+ model = "Qualcomm SA8540 ADP";
+ compatible = "qcom,sa8540p-adp-ride", "qcom,sa8540p";
+};
+
+&ufs_card_hc {
+ status = "disabled";
+};
+
+&usb_1 {
+ status = "disabled";
+};
+
+&usb_1_hsphy {
+ status = "disabled";
+};
+
+&usb_1_qmpphy {
+ status = "disabled";
+};
--
2.17.1
^ permalink raw reply related [flat|nested] 11+ messages in thread* Re: [PATCH v4 3/3] arm64: dts: qcom: introduce sa8540p-ride dts
2022-09-20 12:08 ` [PATCH v4 3/3] arm64: dts: qcom: introduce sa8540p-ride dts Parikshit Pareek
@ 2022-09-20 15:27 ` Krzysztof Kozlowski
2022-09-21 6:51 ` Johan Hovold
1 sibling, 0 replies; 11+ messages in thread
From: Krzysztof Kozlowski @ 2022-09-20 15:27 UTC (permalink / raw)
To: Parikshit Pareek, Andy Gross, Bjorn Andersson, Konrad Dybcio,
Rob Herring, Krzysztof Kozlowski
Cc: linux-arm-msm, devicetree, linux-kernel, Andrew Halaney,
Shazad Hussain
On 20/09/2022 14:08, Parikshit Pareek wrote:
> Create new dts file specific for Qdrive board based on sa8540p chipset.
> Introduce common dtsi file sa8295p-adp.dtsi, to be included for adp and
> Qdrive board.
>
> This is quite similar to sa8295 ADP development board. Main differences
> are related to connectors, and interface cards, like USB external ports,
> ethernet-switch, and PCIe switch etc.
>
> Signed-off-by: Parikshit Pareek <quic_ppareek@quicinc.com>
> Reported-by: Shazad Hussain <quic_shazhuss@quicinc.com>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v4 3/3] arm64: dts: qcom: introduce sa8540p-ride dts
2022-09-20 12:08 ` [PATCH v4 3/3] arm64: dts: qcom: introduce sa8540p-ride dts Parikshit Pareek
2022-09-20 15:27 ` Krzysztof Kozlowski
@ 2022-09-21 6:51 ` Johan Hovold
2022-09-29 5:11 ` Parikshit Pareek
1 sibling, 1 reply; 11+ messages in thread
From: Johan Hovold @ 2022-09-21 6:51 UTC (permalink / raw)
To: Parikshit Pareek
Cc: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, linux-arm-msm, devicetree, linux-kernel,
Andrew Halaney, Shazad Hussain
On Tue, Sep 20, 2022 at 05:38:02PM +0530, Parikshit Pareek wrote:
> Create new dts file specific for Qdrive board based on sa8540p chipset.
> Introduce common dtsi file sa8295p-adp.dtsi, to be included for adp and
> Qdrive board.
>
> This is quite similar to sa8295 ADP development board. Main differences
> are related to connectors, and interface cards, like USB external ports,
> ethernet-switch, and PCIe switch etc.
>
> Signed-off-by: Parikshit Pareek <quic_ppareek@quicinc.com>
> Reported-by: Shazad Hussain <quic_shazhuss@quicinc.com>
> ---
> diff --git a/arch/arm64/boot/dts/qcom/sa8540p-adp-ride.dts b/arch/arm64/boot/dts/qcom/sa8540p-adp-ride.dts
> new file mode 100644
> index 000000000000..bd79866b80e1
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/sa8540p-adp-ride.dts
> @@ -0,0 +1,31 @@
> +// SPDX-License-Identifier: BSD-3-Clause
> +/*
> + * Copyright (c) 2021, The Linux Foundation. All rights reserved.
> + * Copyright (c) 2022, Linaro Limited
> + * Copyright (c) 2022, Qualcomm Innovation Center, Inc. All rights reserved.
> + */
> +
> +/dts-v1/;
> +
> +#include "sa8540p-adp.dtsi"
> +
> +/ {
> + model = "Qualcomm SA8540 ADP";
> + compatible = "qcom,sa8540p-adp-ride", "qcom,sa8540p";
> +};
> +
> +&ufs_card_hc {
> + status = "disabled";
> +};
What about the UFS phy, etc?
This opt-out scheme seems quite fragile.
> +&usb_1 {
> + status = "disabled";
> +};
> +
> +&usb_1_hsphy {
> + status = "disabled";
> +};
> +
> +&usb_1_qmpphy {
> + status = "disabled";
> +};
Johan
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PATCH v4 3/3] arm64: dts: qcom: introduce sa8540p-ride dts
2022-09-21 6:51 ` Johan Hovold
@ 2022-09-29 5:11 ` Parikshit Pareek
0 siblings, 0 replies; 11+ messages in thread
From: Parikshit Pareek @ 2022-09-29 5:11 UTC (permalink / raw)
To: Johan Hovold
Cc: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, linux-arm-msm, devicetree, linux-kernel,
Andrew Halaney, Shazad Hussain
On Wed, Sep 21, 2022 at 08:51:32AM +0200, Johan Hovold wrote:
> On Tue, Sep 20, 2022 at 05:38:02PM +0530, Parikshit Pareek wrote:
> > Create new dts file specific for Qdrive board based on sa8540p chipset.
> > Introduce common dtsi file sa8295p-adp.dtsi, to be included for adp and
> > Qdrive board.
> >
> > This is quite similar to sa8295 ADP development board. Main differences
> > are related to connectors, and interface cards, like USB external ports,
> > ethernet-switch, and PCIe switch etc.
> >
> > Signed-off-by: Parikshit Pareek <quic_ppareek@quicinc.com>
> > Reported-by: Shazad Hussain <quic_shazhuss@quicinc.com>
> > ---
>
> > diff --git a/arch/arm64/boot/dts/qcom/sa8540p-adp-ride.dts b/arch/arm64/boot/dts/qcom/sa8540p-adp-ride.dts
> > new file mode 100644
> > index 000000000000..bd79866b80e1
> > --- /dev/null
> > +++ b/arch/arm64/boot/dts/qcom/sa8540p-adp-ride.dts
> > @@ -0,0 +1,31 @@
> > +// SPDX-License-Identifier: BSD-3-Clause
> > +/*
> > + * Copyright (c) 2021, The Linux Foundation. All rights reserved.
> > + * Copyright (c) 2022, Linaro Limited
> > + * Copyright (c) 2022, Qualcomm Innovation Center, Inc. All rights reserved.
> > + */
> > +
> > +/dts-v1/;
> > +
> > +#include "sa8540p-adp.dtsi"
> > +
> > +/ {
> > + model = "Qualcomm SA8540 ADP";
> > + compatible = "qcom,sa8540p-adp-ride", "qcom,sa8540p";
> > +};
> > +
> > +&ufs_card_hc {
> > + status = "disabled";
> > +};
>
> What about the UFS phy, etc?
Really missed that. Will add phy nodes too.
>
> This opt-out scheme seems quite fragile.
>
> > +&usb_1 {
> > + status = "disabled";
> > +};
> > +
> > +&usb_1_hsphy {
> > + status = "disabled";
> > +};
> > +
> > +&usb_1_qmpphy {
> > + status = "disabled";
> > +};
>
> Johan
Regards,
Parikshit Pareek
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v4 0/3] arm64: dts: qcom: add dts for sa8540p-ride board
2022-09-20 12:07 [PATCH v4 0/3] arm64: dts: qcom: add dts for sa8540p-ride board Parikshit Pareek
` (2 preceding siblings ...)
2022-09-20 12:08 ` [PATCH v4 3/3] arm64: dts: qcom: introduce sa8540p-ride dts Parikshit Pareek
@ 2022-09-21 6:39 ` Johan Hovold
3 siblings, 0 replies; 11+ messages in thread
From: Johan Hovold @ 2022-09-21 6:39 UTC (permalink / raw)
To: Parikshit Pareek
Cc: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, linux-arm-msm, devicetree, linux-kernel,
Andrew Halaney, Shazad Hussain
On Tue, Sep 20, 2022 at 05:37:59PM +0530, Parikshit Pareek wrote:
> This series introduces the Qualcom sa8540p-ride automotive development
> board, also called as Qdrive-3 board.
>
> Changes in v4:
> - Removed the ufs_card_hc node, as it is not mounted on Qdrive-3 board.
> - Removed usb_1 related nodes, as usb1 doesn't have any port connected on
> Qdrive3 board.
Please include the full change log here (also for earlier versions).
Also, please try to remember to CC people who have commented on earlier
versions of the series when resending.
> - Added Reported-by tag for Shazad(for ufs and usb_1 node removals)
This is generally not how we use Reported-by tags (even if the kbuild
robot sometimes gets credit for finding things during review this way).
You can give credit to reviewers by for example putting their name in
parentheses after the corresponding changelog entry (or just spelling
out who suggested the change).
> Parikshit Pareek (3):
> dt-bindings: arm: qcom: Document additional sa8540p device
> arm64: dts: qcom: sa8295p: move common nodes to dtsi
> arm64: dts: qcom: introduce sa8540p-ride dts
>
> .../devicetree/bindings/arm/qcom.yaml | 1 +
> arch/arm64/boot/dts/qcom/Makefile | 1 +
> arch/arm64/boot/dts/qcom/sa8295p-adp.dts | 392 +-----------------
> arch/arm64/boot/dts/qcom/sa8540p-adp-ride.dts | 15 +
> .../{sa8295p-adp.dts => sa8540p-adp.dtsi} | 0
> 5 files changed, 31 insertions(+), 378 deletions(-)
> rewrite arch/arm64/boot/dts/qcom/sa8295p-adp.dts (96%)
> create mode 100644 arch/arm64/boot/dts/qcom/sa8540p-adp-ride.dts
> copy arch/arm64/boot/dts/qcom/{sa8295p-adp.dts => sa8540p-adp.dtsi} (100%)
Johan
^ permalink raw reply [flat|nested] 11+ messages in thread