From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B032C32771 for ; Mon, 26 Sep 2022 20:36:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229544AbiIZUgV (ORCPT ); Mon, 26 Sep 2022 16:36:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34388 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229458AbiIZUgU (ORCPT ); Mon, 26 Sep 2022 16:36:20 -0400 Received: from hall.aurel32.net (hall.aurel32.net [IPv6:2001:bc8:30d7:100::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4BD416CD2F; Mon, 26 Sep 2022 13:36:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=aurel32.net ; s=202004.hall; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Content-Transfer-Encoding:From:Reply-To: Subject:Content-ID:Content-Description:X-Debbugs-Cc; bh=JDRp4qDr97IzM04ueqqbM+oSnyDy0BzALtcY4EKIDWo=; b=CQ33+ur/wXAuMpk31a+d91z6f2 O+rH4wfoBJhnCU1w4k+ofQRQkELKhmDZQZmV9pU93nbHvcVnNmPErmEp5d56WNpFgucZ89a+RzWdV zdFxRtR4OMryfGnQRMPPJDF7VVHWEDylxP2hel4zyrh7rgAdu5QCWbPX+LQKAqL9uGQxaWTSRDBJL 4ioVAutyajsmTNQN+S4ls7x++DCGOAOdYH0Rd/9pT9x6modnLw5M/ySApOc+kTXh/q+Erwjrd7x78 TYX5+lAWBY6fm9EzN4xYyEbqALZk0UpZ00lg7WYzc9upd5yIxIb0L+f9q/EWyvz83ZG/L3X3j4mYE wCG7IJkQ==; Received: from [2a01:e34:ec5d:a741:8a4c:7c4e:dc4c:1787] (helo=ohm.rr44.fr) by hall.aurel32.net with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1ocupq-00BDUk-Bw; Mon, 26 Sep 2022 22:36:14 +0200 Received: from aurel32 by ohm.rr44.fr with local (Exim 4.96) (envelope-from ) id 1ocupp-0001J1-2k; Mon, 26 Sep 2022 22:36:13 +0200 Date: Mon, 26 Sep 2022 22:36:13 +0200 From: Aurelien Jarno To: Peter Geis Cc: linux-kernel@vger.kernel.org, Rob Herring , Krzysztof Kozlowski , Heiko Stuebner , Frank Wunderlich , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "moderated list:ARM/Rockchip SoC support" , "open list:ARM/Rockchip SoC support" Subject: Re: [PATCH] arm64: dts: rockchip: Add missing rockchip,pipe-grf to rk3568 PCIe v3 PHY Message-ID: Mail-Followup-To: Peter Geis , linux-kernel@vger.kernel.org, Rob Herring , Krzysztof Kozlowski , Heiko Stuebner , Frank Wunderlich , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "moderated list:ARM/Rockchip SoC support" , "open list:ARM/Rockchip SoC support" References: <20220926183533.1893371-1-aurelien@aurel32.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/2.2.7 (2022-08-07) Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 2022-09-26 14:58, Peter Geis wrote: > On Mon, Sep 26, 2022 at 2:35 PM Aurelien Jarno wrote: > > > > This commit fixes the error message > > > > rockchip-snps-pcie3-phy fe8c0000.phy: failed to find rockchip,pipe_grf regmap > > The pipe grf only is used on the rk3588 device for this phy. Ok, looking at the code in details, I confirm that. Does it mean the change should be done at the phy driver level, to only look for rockchip,pipe-grf on the rk3588 device? -- Aurelien Jarno GPG: 4096R/1DDD8C9B aurelien@aurel32.net http://www.aurel32.net