From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3EA7BC04A95 for ; Wed, 28 Sep 2022 19:25:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233015AbiI1TZJ (ORCPT ); Wed, 28 Sep 2022 15:25:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45594 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234526AbiI1TYs (ORCPT ); Wed, 28 Sep 2022 15:24:48 -0400 Received: from mail-io1-xd2a.google.com (mail-io1-xd2a.google.com [IPv6:2607:f8b0:4864:20::d2a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0B5AC17A8B for ; Wed, 28 Sep 2022 12:24:46 -0700 (PDT) Received: by mail-io1-xd2a.google.com with SMTP id v128so10948529ioe.12 for ; Wed, 28 Sep 2022 12:24:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date; bh=MO1VbxnfAHIl77onNuYWJWsBzJp4QOHXVNC5oK8Yuqk=; b=VGhasSHLM0UkJ9hO2GsiyUwH4ah5kerBGf+crFciQjqxDNeERk5jKuYEJ5Yba9Go0q IgtJJf3agMY6KjseD9Gyn/BnWrwXU0+KleAvQiAzyMtGEiCWn49FGbq2bFProuD3p50Q aotr66sKe46RnRQvVkj4ufBvdi5IhntQhj5nw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date; bh=MO1VbxnfAHIl77onNuYWJWsBzJp4QOHXVNC5oK8Yuqk=; b=bUe5LJG5VhMnZS2tYkMryzqJwK/aCz8w1tTyFBbZtvrOBtIgmzk45H8h4xREFJ4es7 1w0eJyjnmwvPw6Q0isCDUs+ngrCQct+21rYqjTB9aepf72ZBLaZfVDLBU+v0Sa9w9AZ+ bHp6XxZRFw3NDyf43ZOIYyT9zEWiAJfNOHZXTfpKOayjqIcsrR66tDAHFxRBPnVl6MYY ahe0NwoDpC9P/0Zwt+xPMdEknbFWDpmoXQk1/ateQPn9BzT9dqUbuGX8MKidxLmVacpH Crea5EK84DOabBtKWGJAPCadEI1N7tOQTZBPl4j6fjBXZYeQkz8xS8fh4U735m4C2XoA 2s5A== X-Gm-Message-State: ACrzQf0nz0qe9bbYMZwNxnAOM7ISaxpGqSXI55y0aUEw+GzHGlXLM1t/ jVPfC1qzlbFhe1eexRsg7vQSRw== X-Google-Smtp-Source: AMsMyM4Fl42E9H+wUQXKwFcdMnU08P+BAXhYmjSJDqL8xOBr7TJo2zF9ZAwd9zNUMHuvxLdD4XgIRg== X-Received: by 2002:a05:6602:2d83:b0:6a4:ea1e:3fe8 with SMTP id k3-20020a0566022d8300b006a4ea1e3fe8mr5216114iow.163.1664393085395; Wed, 28 Sep 2022 12:24:45 -0700 (PDT) Received: from localhost (30.23.70.34.bc.googleusercontent.com. [34.70.23.30]) by smtp.gmail.com with UTF8SMTPSA id r2-20020a056e02108200b002f6460e4d90sm1904897ilj.85.2022.09.28.12.24.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 28 Sep 2022 12:24:44 -0700 (PDT) Date: Wed, 28 Sep 2022 19:24:43 +0000 From: Matthias Kaehlcke To: Doug Anderson Cc: Andy Gross , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , linux-arm-msm , Krishna Kurapati , LKML , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Bjorn Andersson Subject: Re: [PATCH v2] arm64: dts: qcom: sc7180: Configure USB as wakeup source Message-ID: References: <20220901102946.v2.1.I347ea409ee3134bd32a29e33fecd1a6ef32085a0@changeid> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Bjorn, This patch should be ready for landing, could you pick it? Thanks Matthias On Tue, Sep 06, 2022 at 12:22:42PM -0700, Doug Anderson wrote: > Hi, > > On Tue, Sep 6, 2022 at 12:04 PM Matthias Kaehlcke wrote: > > > > Hi Doug, > > > > On Tue, Sep 06, 2022 at 11:33:56AM -0700, Doug Anderson wrote: > > > Hi, > > > > > > On Thu, Sep 1, 2022 at 10:29 AM Matthias Kaehlcke wrote: > > > > > > > > The dwc3 USB controller of the sc7180 supports USB remote > > > > wakeup, configure it as a wakeup source. > > > > > > > > Signed-off-by: Matthias Kaehlcke > > > > --- > > > > > > > > Changes in v2: > > > > - use qcom/arm64-for-6.1 as base, v1 was unintendedly based on a > > > > downstream branch that was used for testing > > > > > > > > arch/arm64/boot/dts/qcom/sc7180.dtsi | 2 ++ > > > > 1 file changed, 2 insertions(+) > > > > > > > > diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi > > > > index e8debb0da411..af5bab27eaf3 100644 > > > > --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi > > > > +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi > > > > @@ -2782,6 +2782,8 @@ usb_1: usb@a6f8800 { > > > > <&gem_noc MASTER_APPSS_PROC 0 &config_noc SLAVE_USB3 0>; > > > > interconnect-names = "usb-ddr", "apps-usb"; > > > > > > > > + wakeup-source; > > > > + > > > > > > The patch documenting this property has landed in commit 416b61893860 > > > ("dt-bindings: usb: qcom,dwc3: add wakeup-source property"). I guess > > > the only question is whether this should be in the general sc7180 > > > device tree file or just for trogdor. > > > > I had a similar comment on the patch for sc7280 [1], there the rationale > > for putting the property into the .dtsi of the SoC was that the wakeup > > capability is provided by the SoC. > > > > For sc8280xp.dtsi the property is also in the .dtsi of the SoC: > > > > https://git.kernel.org/pub/scm/linux/kernel/git/qcom/linux.git/tree/arch/arm64/boot/dts/qcom/sc8280xp.dtsi?h=arm64-for-6.1#n1315 > > > > > Any chance it could cause problems for devices that aren't designed like > > > trogdor? > > > > Probably not in a functional sense, however power consumption during system > > suspend is slightly higher (2-3 mW) when USB wakeup is enabled. Boards can > > disable wakeup by deleting the property in their .dtsi file, though it > > is not necessarily evident that this is an option to reduce power > > consumption. > > > > [1] https://patchwork.kernel.org/project/linux-arm-msm/patch/1649321104-31322-7-git-send-email-quic_c_sanm@quicinc.com/ > > OK then. > > Reviewed-by: Douglas Anderson