From: Andrew Lunn <andrew@lunn.ch>
To: Pawel Dembicki <paweldembicki@gmail.com>
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Gregory Clement <gregory.clement@bootlin.com>
Subject: Re: [PATCH] ARM: dts: kirkwood: Add Endian 4i Edge 200 board
Date: Thu, 29 Sep 2022 14:43:23 +0200 [thread overview]
Message-ID: <YzWS6+3KXwVRS2Df@lunn.ch> (raw)
In-Reply-To: <20220929080036.3179552-1-paweldembicki@gmail.com>
> +// SPDX-License-Identifier: GPL-2.0-or-later
I think the preference is that DT is dual licence GPL or MIT.
> + switch0: switch@11 {
> + compatible = "marvell,mv88e6085";
> + reg = <0x11>;
> +
> + ports {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + port@0 {
> + reg = <0>;
> + label = "port1";
> + };
> +
> + port@1 {
> + reg = <1>;
> + label = "port2";
> + };
> +
> + port@2 {
> + reg = <2>;
> + label = "port3";
> + };
> +
> + port@3 {
> + reg = <3>;
> + label = "port4";
> + };
> +
> + port@5 {
> + reg = <5>;
> + label = "cpu";
This label is never used by DSA, and Vladimir has been removing them
in general. Please delete it.
Andrew
prev parent reply other threads:[~2022-09-29 12:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-29 8:00 [PATCH] ARM: dts: kirkwood: Add Endian 4i Edge 200 board Pawel Dembicki
2022-09-29 12:43 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YzWS6+3KXwVRS2Df@lunn.ch \
--to=andrew@lunn.ch \
--cc=devicetree@vger.kernel.org \
--cc=gregory.clement@bootlin.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=paweldembicki@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).