From: Andrew Lunn <andrew@lunn.ch>
To: Pawel Dembicki <paweldembicki@gmail.com>
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Gregory Clement <gregory.clement@bootlin.com>,
Tony Dinh <mibodhi@gmail.com>
Subject: Re: [PATCH] ARM: dts: kirkwood: Add Zyxel NSA310S board
Date: Thu, 29 Sep 2022 14:53:15 +0200 [thread overview]
Message-ID: <YzWVOyM+Z3AFSI7c@lunn.ch> (raw)
In-Reply-To: <20220929080110.3182561-1-paweldembicki@gmail.com>
> +// SPDX-License-Identifier: GPL-2.0-only
Same license comment. However, you can only change the license if it
is your code. If you did the conversion from a board setup file to DT,
you can change the license. If somebody else did that and you are just
submitting it, then we need to keep to GPL-2.0-only.
> + regulators {
> + compatible = "simple-bus";
> + #address-cells = <1>;
> + #size-cells = <0>;
> + pinctrl-0 = <&pmx_power>;
> + pinctrl-names = "default";
The modern way to do regulators is to no longer user a container node.
Most of the existing kirkwood DTS files are from long before this was
introduced, so they do have a container. But new files should probably
do it the 'new' way.
Andrew
next prev parent reply other threads:[~2022-09-29 12:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-29 8:01 [PATCH] ARM: dts: kirkwood: Add Zyxel NSA310S board Pawel Dembicki
2022-09-29 12:53 ` Andrew Lunn [this message]
2022-10-29 0:14 ` Adam Baker
2022-10-29 0:49 ` Tony Dinh
2022-10-29 14:31 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YzWVOyM+Z3AFSI7c@lunn.ch \
--to=andrew@lunn.ch \
--cc=devicetree@vger.kernel.org \
--cc=gregory.clement@bootlin.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=mibodhi@gmail.com \
--cc=paweldembicki@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).