* [PATCH v2] ARM: dts: stihxxx-b2120: fix polarity of reset line of tsin0 port
@ 2022-09-30 16:00 Dmitry Torokhov
2023-02-02 18:51 ` Dmitry Torokhov
0 siblings, 1 reply; 3+ messages in thread
From: Dmitry Torokhov @ 2022-09-30 16:00 UTC (permalink / raw)
To: Patrice Chotard
Cc: Rob Herring, Krzysztof Kozlowski, Alain Volmat, linux-arm-kernel,
devicetree, linux-kernel
According to c8sectpfe driver code we first drive reset line low and
then high to reset the port, therefore the reset line is supposed to
be annotated as "active low". This will be important when we convert
the driver to gpiod API.
Reviewed-by: Patrice Chotard <patrice.chotard@foss.st.com>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
---
v2: fixed typo in the subject, added Patrice's reviewed-by
arch/arm/boot/dts/stihxxx-b2120.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/stihxxx-b2120.dtsi b/arch/arm/boot/dts/stihxxx-b2120.dtsi
index 2aa94605d3d4..d52a7aaa1074 100644
--- a/arch/arm/boot/dts/stihxxx-b2120.dtsi
+++ b/arch/arm/boot/dts/stihxxx-b2120.dtsi
@@ -178,7 +178,7 @@ tsin0: port {
tsin-num = <0>;
serial-not-parallel;
i2c-bus = <&ssc2>;
- reset-gpios = <&pio15 4 GPIO_ACTIVE_HIGH>;
+ reset-gpios = <&pio15 4 GPIO_ACTIVE_LOW>;
dvb-card = <STV0367_TDA18212_NIMA_1>;
};
};
--
2.38.0.rc1.362.ged0d419d3c-goog
--
Dmitry
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] ARM: dts: stihxxx-b2120: fix polarity of reset line of tsin0 port
2022-09-30 16:00 [PATCH v2] ARM: dts: stihxxx-b2120: fix polarity of reset line of tsin0 port Dmitry Torokhov
@ 2023-02-02 18:51 ` Dmitry Torokhov
2023-02-03 13:50 ` Patrice CHOTARD
0 siblings, 1 reply; 3+ messages in thread
From: Dmitry Torokhov @ 2023-02-02 18:51 UTC (permalink / raw)
To: Patrice Chotard
Cc: Rob Herring, Krzysztof Kozlowski, Alain Volmat, linux-arm-kernel,
devicetree, linux-kernel
On Fri, Sep 30, 2022 at 09:00:41AM -0700, Dmitry Torokhov wrote:
> According to c8sectpfe driver code we first drive reset line low and
> then high to reset the port, therefore the reset line is supposed to
> be annotated as "active low". This will be important when we convert
> the driver to gpiod API.
>
> Reviewed-by: Patrice Chotard <patrice.chotard@foss.st.com>
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> ---
Gentle ping on this one...
>
> v2: fixed typo in the subject, added Patrice's reviewed-by
>
> arch/arm/boot/dts/stihxxx-b2120.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/stihxxx-b2120.dtsi b/arch/arm/boot/dts/stihxxx-b2120.dtsi
> index 2aa94605d3d4..d52a7aaa1074 100644
> --- a/arch/arm/boot/dts/stihxxx-b2120.dtsi
> +++ b/arch/arm/boot/dts/stihxxx-b2120.dtsi
> @@ -178,7 +178,7 @@ tsin0: port {
> tsin-num = <0>;
> serial-not-parallel;
> i2c-bus = <&ssc2>;
> - reset-gpios = <&pio15 4 GPIO_ACTIVE_HIGH>;
> + reset-gpios = <&pio15 4 GPIO_ACTIVE_LOW>;
> dvb-card = <STV0367_TDA18212_NIMA_1>;
> };
> };
> --
> 2.38.0.rc1.362.ged0d419d3c-goog
>
>
> --
> Dmitry
--
Dmitry
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] ARM: dts: stihxxx-b2120: fix polarity of reset line of tsin0 port
2023-02-02 18:51 ` Dmitry Torokhov
@ 2023-02-03 13:50 ` Patrice CHOTARD
0 siblings, 0 replies; 3+ messages in thread
From: Patrice CHOTARD @ 2023-02-03 13:50 UTC (permalink / raw)
To: Dmitry Torokhov
Cc: Rob Herring, Krzysztof Kozlowski, Alain Volmat, linux-arm-kernel,
devicetree, linux-kernel
On 2/2/23 19:51, Dmitry Torokhov wrote:
> On Fri, Sep 30, 2022 at 09:00:41AM -0700, Dmitry Torokhov wrote:
>> According to c8sectpfe driver code we first drive reset line low and
>> then high to reset the port, therefore the reset line is supposed to
>> be annotated as "active low". This will be important when we convert
>> the driver to gpiod API.
>>
>> Reviewed-by: Patrice Chotard <patrice.chotard@foss.st.com>
>> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
>> ---
>
> Gentle ping on this one...
Hi Dmitry
Sorry for the delay, i will push a STi pull request including your patch.
Patrice
>
>>
>> v2: fixed typo in the subject, added Patrice's reviewed-by
>>
>> arch/arm/boot/dts/stihxxx-b2120.dtsi | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/boot/dts/stihxxx-b2120.dtsi b/arch/arm/boot/dts/stihxxx-b2120.dtsi
>> index 2aa94605d3d4..d52a7aaa1074 100644
>> --- a/arch/arm/boot/dts/stihxxx-b2120.dtsi
>> +++ b/arch/arm/boot/dts/stihxxx-b2120.dtsi
>> @@ -178,7 +178,7 @@ tsin0: port {
>> tsin-num = <0>;
>> serial-not-parallel;
>> i2c-bus = <&ssc2>;
>> - reset-gpios = <&pio15 4 GPIO_ACTIVE_HIGH>;
>> + reset-gpios = <&pio15 4 GPIO_ACTIVE_LOW>;
>> dvb-card = <STV0367_TDA18212_NIMA_1>;
>> };
>> };
>> --
>> 2.38.0.rc1.362.ged0d419d3c-goog
>>
>>
>> --
>> Dmitry
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-02-03 13:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-09-30 16:00 [PATCH v2] ARM: dts: stihxxx-b2120: fix polarity of reset line of tsin0 port Dmitry Torokhov
2023-02-02 18:51 ` Dmitry Torokhov
2023-02-03 13:50 ` Patrice CHOTARD
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).