From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f176.google.com (mail-pf1-f176.google.com [209.85.210.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1D0CD22E410 for ; Tue, 15 Apr 2025 18:48:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744742894; cv=none; b=pfiZlcAFSnGrkX6r/Tgeihiw3haCoT+esitW2/GWbR0HnzeLgGVp9VIr6Qoy9XdgmpY6j8eA8jGKG8AEWcSmrh7Nkc/JTDi+5tH0JQ2QCpiHf9tNhMcGSZNedMt5fnV4nyovbeMk53OgT/1pxdbZvPES0qBPrWuPQDOoYz9MRZw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744742894; c=relaxed/simple; bh=jyspZm5GDyE8V8MqM0DVGyy+s9l/GwhLFwsgaQQGonw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=kXvWhqdhRV42nKcZRcjmEqVUS83MckEpfhDcGqZoZGZolxtFfVs5LqvTpkXld/I+CMUT3f3m7eZVy5IA0Ys0cAqv7eMUCxavYBtKzcJb/5GIC/7i/NTmn6xwNSh77A6mdnLld9a9u1BRiX0zi44o2NL5n2XKexxim0DlKpeC0gk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pdp7.com; spf=none smtp.mailfrom=pdp7.com; dkim=pass (2048-bit key) header.d=pdp7-com.20230601.gappssmtp.com header.i=@pdp7-com.20230601.gappssmtp.com header.b=1+MwscUe; arc=none smtp.client-ip=209.85.210.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pdp7.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=pdp7.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=pdp7-com.20230601.gappssmtp.com header.i=@pdp7-com.20230601.gappssmtp.com header.b="1+MwscUe" Received: by mail-pf1-f176.google.com with SMTP id d2e1a72fcca58-736c3e7b390so5005406b3a.2 for ; Tue, 15 Apr 2025 11:48:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pdp7-com.20230601.gappssmtp.com; s=20230601; t=1744742892; x=1745347692; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=glUhvdbg6jDxSzyhesIM3rd1JyjGcrsNSGuSqUFVHug=; b=1+MwscUeTVfBM7bjPdLu6bUneloOL81f/Yya/cT52SsUTCY15XkjAkbKP9kJVSn6pG wM47IBzFbvRklbgrnGDSEnHY0APRUns77kG9QBm/lFehrbl4dvpFKQjhFVvMoa/EVlDZ W5IEz0GRUuIvoUmLHgQre9ifjnI8Oil1YZGGd3TPD02qm6aSOzsefOt7UvFLcqICue3z ZvFN6NJaDsf476XVogolYLzskAMkulEZuSeblXHi9JIePHQ5q9dcsugiq+c9XSEQ36Mh V3Uc4P6QXEhXFxSCEleM2ra5orNvvE11i/VaOIKrkBNcUwffOpwNGiFIhbFslHZczUFy xPbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744742892; x=1745347692; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=glUhvdbg6jDxSzyhesIM3rd1JyjGcrsNSGuSqUFVHug=; b=f679yoJwjFydUd91dK0SV+xW4ZtElTjWdZQ4B5hiCKaOsSADkPfzqMUlhetNelc1Bh IbeeGz/PeFajyPljr87Y7CMMtm7998SeYxtRy39sIZgHARjyuTCTHJWFjZZ9VlIP2xts Frk/IHcO1F4bW6ethS4TaUoVJ0c1B9UsYtteUfw/tYG0OT3JRuYelaBrTl7JV75t4sxU vY0lRk3mMHZfPu65BHUS3cmSoD3RQAGATt9TFnXtUi9vCeRvVFQwQkDh8OrLvh5mN26C UzJH1BuRtO1OR5nb0X/TxBwTEr65pGAkidH6/pVvE7lYVHhz6Y77WnC+LYFwPBwB+zof z6OQ== X-Forwarded-Encrypted: i=1; AJvYcCW2liKv7pwY1I8Ph93XzrczHInQ6oVY3fFFdb+jE4SlBD4TeetxOvmnWv40v4fu7kRN++24x0aBoVb8@vger.kernel.org X-Gm-Message-State: AOJu0YyWr8bdAAoo56BvyjL+yVP2eCtPQoVDVFdSIbYb88y9smTFHqE+ fsrCgrSlWcLhVmQE+StH5So5SjA+vHut8k14052rAc+gla6rDsBOYe7P2XdZqbA= X-Gm-Gg: ASbGncuXy+lQ22ivHJ6QzTEVB7PpYjSP3IPOk8T8mArUZbff/33fqCSiPhoZ9yPxrM9 AjRJa0/sODMEqXBikZt0DsMJagw65KoeIM+YuScfnXJ+swZzNj7aGx6/D9K4aXr2yWxz0jDZ/LU YDIgrxblzxZISA41OJvWRWaTdbGJ4X7rqurlbIGUtXTCJYp2Lgy1zWj/SQ4yulELYhT0oXPkL7l fFb97Q8mg54k2tyTYxeDmyvGJIZHXjn+rEMUG3zozMd6IZT3GH4R+0sMhoyEgOPrrifWbrQwcBm b0hksADxvNTCYKYsmGVIBwWMdhrNofZkzn7T0/CP7r04jXg= X-Google-Smtp-Source: AGHT+IFU1A6IgDtbE+ayph1nkrk/Xkmje9tzi2mXCLVIUeRmrboHqr3jd6su6fZeet5H41nBKRVWlQ== X-Received: by 2002:a05:6a00:a26:b0:736:3979:369e with SMTP id d2e1a72fcca58-73c1f8f742emr628913b3a.9.1744742891991; Tue, 15 Apr 2025 11:48:11 -0700 (PDT) Received: from x1 (97-120-122-6.ptld.qwest.net. [97.120.122.6]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-b02a2d3a4ddsm9578290a12.49.2025.04.15.11.48.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Apr 2025 11:48:10 -0700 (PDT) Date: Tue, 15 Apr 2025 11:48:08 -0700 From: Drew Fustini To: Michal Wilczynski Cc: mturquette@baylibre.com, sboyd@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, guoren@kernel.org, wefu@redhat.com, jassisinghbrar@gmail.com, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, frank.binns@imgtec.com, matt.coster@imgtec.com, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, ulf.hansson@linaro.org, jszhang@kernel.org, p.zabel@pengutronix.de, m.szyprowski@samsung.com, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, dri-devel@lists.freedesktop.org, linux-pm@vger.kernel.org Subject: Re: [PATCH v5 19/21] riscv: dts: thead: Introduce power domain nodes with aon firmware Message-ID: References: <20250219140239.1378758-1-m.wilczynski@samsung.com> <20250219140239.1378758-20-m.wilczynski@samsung.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Mon, Apr 14, 2025 at 07:04:29PM -0700, Drew Fustini wrote: > On Wed, Feb 19, 2025 at 03:02:37PM +0100, Michal Wilczynski wrote: > > The DRM Imagination GPU requires a power-domain driver. In the T-HEAD > > TH1520 SoC implements power management capabilities through the E902 > > core, which can be communicated with through the mailbox, using firmware > > protocol. > > > > Add AON node, which servers as a power-domain controller. > > > > Signed-off-by: Michal Wilczynski > > --- > > arch/riscv/boot/dts/thead/th1520.dtsi | 8 ++++++++ > > 1 file changed, 8 insertions(+) > > > > diff --git a/arch/riscv/boot/dts/thead/th1520.dtsi b/arch/riscv/boot/dts/thead/th1520.dtsi > > index 197df1f32b25..474f31576a1b 100644 > > --- a/arch/riscv/boot/dts/thead/th1520.dtsi > > +++ b/arch/riscv/boot/dts/thead/th1520.dtsi > > @@ -6,6 +6,7 @@ > > > > #include > > #include > > +#include > > > > / { > > compatible = "thead,th1520"; > > @@ -229,6 +230,13 @@ stmmac_axi_config: stmmac-axi-config { > > snps,blen = <0 0 64 32 0 0 0>; > > }; > > > > + aon: aon { > > + compatible = "thead,th1520-aon"; > > + mboxes = <&mbox_910t 1>; > > + mbox-names = "aon"; > > + #power-domain-cells = <1>; > > + }; > > + > > soc { > > compatible = "simple-bus"; > > interrupt-parent = <&plic>; > > -- > > 2.34.1 > > > > Reviewed-by: Drew Fustini > > I tested this on top of 6.15-rc1 and found no issues. > > -Drew I've applied to thead-dt-for-next: https://github.com/pdp7/linux/commit/2bae46e3de2a64fe3a619d61b16da0c01b8df2a1 Michal - are there any other dts patches that I should consider for 6.16 PR? I would probably send to Arnd around 6.15-rc3 or 6.15-rc4. Thanks, Drew