From: Abel Vesa <abel.vesa@linaro.org>
To: Christopher Obbard <christopher.obbard@linaro.org>
Cc: Douglas Anderson <dianders@chromium.org>,
Neil Armstrong <neil.armstrong@linaro.org>,
Jessica Zhang <quic_jesszhan@quicinc.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org, Johan Hovold <johan@kernel.org>,
Rui Miguel Silva <rui.silva@linaro.org>,
devicetree@vger.kernel.org
Subject: Re: [PATCH v2 4/4] drm/dp: fallback to maximum when PWM bit count is zero
Date: Thu, 27 Mar 2025 10:04:56 +0200 [thread overview]
Message-ID: <Z+UGqItLubQ9kwF+@linaro.org> (raw)
In-Reply-To: <20250325-wip-obbardc-qcom-t14s-oled-panel-v2-4-e9bc7c9d30cc@linaro.org>
On 25-03-25 19:21:29, Christopher Obbard wrote:
> Some eDP devices report DP_EDP_PWMGEN_BIT_COUNT as 0, but still provide
> valid non-zero MIN and MAX values. This patch reworks the logic to
> fallback to the max value in such cases, ensuring correct backlight PWM
> configuration even when the bit count value is not explicitly set.
>
> This improves compatibility with eDP panels (e.g. Samsung ATNA40YK20
> used on the Lenovo T14s Gen6 Snapdragon with OLED panel) which reports
> DP_EDP_PWMGEN_BIT_COUNT as 0 but still provides valid non-zero MIN/MAX
> values.
>
Nit-pick: AFAICT, there is no relationship between this patch and the
rest. So it should've probably not be part of this patchset.
next prev parent reply other threads:[~2025-03-27 8:05 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-25 19:21 [PATCH v2 0/4] Add support for OLED panel used on Snapdragon Lenovo T14s Gen6 Christopher Obbard
2025-03-25 19:21 ` [PATCH v2 1/4] dt-bindings: display: panel: samsung,atna40yk20: document ATNA40YK20 Christopher Obbard
2025-03-26 8:08 ` Krzysztof Kozlowski
2025-03-27 15:54 ` Doug Anderson
2025-03-25 19:21 ` [PATCH v2 2/4] arm64: dts: qcom: x1e78100-t14s: add hpd gpio to LCD panel Christopher Obbard
2025-03-26 23:20 ` Bryan O'Donoghue
2025-03-27 7:51 ` Abel Vesa
2025-03-27 13:20 ` Christopher Obbard
2025-03-25 19:21 ` [PATCH v2 3/4] arm64: dts: qcom: x1e78100-t14s-oled: add eDP panel Christopher Obbard
2025-03-25 22:58 ` Dmitry Baryshkov
2025-03-25 19:21 ` [PATCH v2 4/4] drm/dp: fallback to maximum when PWM bit count is zero Christopher Obbard
2025-03-25 22:53 ` Dmitry Baryshkov
2025-03-26 15:08 ` Christopher Obbard
2025-03-26 17:17 ` Dmitry Baryshkov
2025-03-27 8:04 ` Abel Vesa [this message]
2025-03-27 13:19 ` Christopher Obbard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z+UGqItLubQ9kwF+@linaro.org \
--to=abel.vesa@linaro.org \
--cc=airlied@gmail.com \
--cc=andersson@kernel.org \
--cc=christopher.obbard@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=johan@kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=quic_jesszhan@quicinc.com \
--cc=robh@kernel.org \
--cc=rui.silva@linaro.org \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).