From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f45.google.com (mail-ed1-f45.google.com [209.85.208.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 279CC213E67 for ; Fri, 28 Mar 2025 09:22:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743153739; cv=none; b=WOBShSbxtBLv0vifaco4nNYhH0LATduusmDuOH7KCRtVteY8Df/vACoRujJIa5F2nWh/AEQvqFcMziZjNFrsDNfQYVy6r1g+C5FroJU87oAcWPhxSXyYqIUybdJuv+ul6CfsiPvYMJ+mgHHTAxuY8+xokdHDaAxQ7wVDf7ZKZ5A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743153739; c=relaxed/simple; bh=3n5NcSWbMxNV65pkiH8xO7XiulAHfo9FuvZJ/52Zbn0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=brpdNJoCYBqjjAZqDNAiQV1+iBVlxz3VRjV/GKBVfW1vl0rbEkB8Li2LVAFRf8T2/cuf60Fk2fdNhq1FcAB7ABJ6i6Ysq8q2H1W2srTDhC8twmEVfd1fkLgkqdTcPQGVdnVHJaJDVLtb31mRufxNCdoREI+E35piAdlQuKC+1q0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=Nw6sNeId; arc=none smtp.client-ip=209.85.208.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Nw6sNeId" Received: by mail-ed1-f45.google.com with SMTP id 4fb4d7f45d1cf-5e5c7d6b96fso3596513a12.3 for ; Fri, 28 Mar 2025 02:22:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1743153734; x=1743758534; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=S8F6/Mi5t6CvVa6NbJV7qdkNj8IUB4iUseQrodXPdQU=; b=Nw6sNeIdeMenm31Ozp9zvLFT4ZPDxWlDC0/xuDM4AlHNphNItUXe8s+cE5Ten/Jf69 lTK8JwKSd7JXPFYmWERLVFTRRn4LGyUbgnkKXaiqaazYrFgvrwzKyuMEgiz7m4chXGAU 5N20ifyoLnKHscaGLth7Y9yFv7HumouRleXmhuRc3yhhJm67NE7tijwNiHeOd0tn6u1m cdkjp+A+a7jA0ktPZ+DV5kX0+hXu5Ro1/0OA0mc17+iwFk06Vb4P88Lv703IcLwJn/NQ PYqvyMTjeJIf+TChxT+uTbJDOvMEFRCW4YwP41mlxLSPqR+XHMWjY0UjmkRJjKKqbAMQ b3gg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743153734; x=1743758534; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=S8F6/Mi5t6CvVa6NbJV7qdkNj8IUB4iUseQrodXPdQU=; b=aWinDNt+dB12MqlSekx69LUJUM/2euiNAnRQ4G3aDdqAT5ULsu57BWHrPYMLSBquE3 ibBwpoVHDt4o+IqqCts0Akct1iwORpsxrlLSr6Q5fME9K1fpXR39CLlJ6dgIYIg6xXrq 8MunwAc25heRC3W9l5naD0O3eOQRBTlBE31wxhAwbDhkzw6Su8Lyh2yMdxCjLD6PfzzO W2xgtUujNicNMqcMiu4iJHDFarb0+aWr3tymnZjYfc9Y5X0Yfb05n7tgdDCniGgVgrnM /1/ZMw1gC5xQJwd4vpFlIECvpFigKDJfemODZyfhgGlCqrDOMAGI6EXdZDCpY0l7wXre yPGA== X-Forwarded-Encrypted: i=1; AJvYcCV6ue/HBGGEuWI5+pX9BdV+caBjOCXgrqyabZNS6NrmceIhF8F3nsRotahUlStR9e2Wi/KdKRnmF2L1@vger.kernel.org X-Gm-Message-State: AOJu0Yz3tgHYRiT43dB5WXGtcjvyVwveQ5bvTYyatw6t1R4FD3C+l+FL Mh2PgchHFkutf6G4M4UqlRj0sgzP05In9/y5CTh6/qTqj/8ciPyvdFzJWJV3N7zjRvsCBvkFzOM k X-Gm-Gg: ASbGncudYQL0T7pCodDRFYhz2dzyPQTt2ZxcRgkkKVsXkBI+k3x1R3BhxCkwr6Ws9D8 QHbPuVBcV9WCawkogpDWKCc3OSClSbpc9Cpy58wXF3ig0Y+nan2vRF69fgiRRJFzqKd/TDZ0LpI F2Trz1txXa5mAqLRaKqZCfr9sVyqdMBOSBGR4BHfJDyeC1mUIqNxdJTKTZ9MnGCv65XLKGg3JLm nYDhOPtCwHHMCecYklq9TMfs3iTWShZIhSF7XscdgZeHxy1+uMoDVtYNVA4e7+eZadRluf6gPF6 CPl3oVplTY0fjCkiK8I4BzNpLGo7Aps8iMsRfjNj7Q== X-Google-Smtp-Source: AGHT+IGqVO5GOBdKSR0UHnmKwqXfKTUeeVTD7NtsjeXDRVx37M2iiHUK4xT403SV1qcakAEOpZYu7A== X-Received: by 2002:a17:906:c153:b0:ac3:4227:139c with SMTP id a640c23a62f3a-ac6faf2eefemr758055966b.24.1743153734352; Fri, 28 Mar 2025 02:22:14 -0700 (PDT) Received: from linaro.org ([62.231.96.41]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ac71971bf3fsm126205666b.182.2025.03.28.02.22.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Mar 2025 02:22:13 -0700 (PDT) Date: Fri, 28 Mar 2025 11:22:11 +0200 From: Abel Vesa To: Johan Hovold Cc: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jens Glathe , Stephan Gerhold , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] arm64: dts: qcom: x1e80100-hp-x14: drop bogus USB retimer Message-ID: References: <20250328084154.16759-1-johan+linaro@kernel.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250328084154.16759-1-johan+linaro@kernel.org> On 25-03-28 09:41:54, Johan Hovold wrote: > Jens reported that the sanity checks added to the new ps883x USB retimer > driver breaks USB and display on the HP X14. Turns out the X14 only has > a retimer on one of the ports, but this initially went unnoticed due to > the missing sanity check (and error handling) in the retimer driver. > > Drop the non-existing retimer from the devicetree to enable the second > USB port and the display subsystem. > > Note that this also matches the ACPI tables. > > Fixes: 6f18b8d4142c ("arm64: dts: qcom: x1e80100-hp-x14: dt for HP Omnibook X Laptop 14") > Cc: Jens Glathe > Signed-off-by: Johan Hovold Reviewed-by: Abel Vesa