From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.zeus03.de (zeus03.de [194.117.254.33]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EE3D71F12F1 for ; Thu, 3 Apr 2025 09:07:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=194.117.254.33 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743671239; cv=none; b=tVjvygKcjYhO0AxPqbTokY8DJ3l9qjEnwT8+J4BdZ5BcUu9MGQtRS5Ko0iwgZnSJ8mqH3BpzM/C//AoW/zKHE/YURMOSdle4dJHP2w0q2nvC/TFcr0X4nntGaSiwTcIEy/JpvC4I/5K+BoJo15IoVsVCgtLY3lajJ+0ZHswFR6I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743671239; c=relaxed/simple; bh=l8gTnU2dtKYUn276KVsPVVWPeUSFCVu4U25a1SBfu9c=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=GQGZ5ayazd2j0JwPauYQodb6H4nVzoEvfYELOfbU2xf2NNdKC6vKYWzRfq+Xl9phlztsb+jIj98uwyDyUJrY0VeaqVXj4bfGYc28PK+XEzf979exZfDysiPe3OAq9TsmP5LpuJVb61E0wXf+wWDcMsHLlYRZkS6O6j3KWNPTeks= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=sang-engineering.com; spf=pass smtp.mailfrom=sang-engineering.com; dkim=pass (2048-bit key) header.d=sang-engineering.com header.i=@sang-engineering.com header.b=BjQUw+rR; arc=none smtp.client-ip=194.117.254.33 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=sang-engineering.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sang-engineering.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sang-engineering.com header.i=@sang-engineering.com header.b="BjQUw+rR" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= sang-engineering.com; h=date:from:to:cc:subject:message-id :references:mime-version:content-type:in-reply-to; s=k1; bh=VXvi 2mNF8xXuVLVH/4vQtoyPsrTNcyZMvZgZD0MbxLo=; b=BjQUw+rRjZdBNmlicGLL MEXXNZfsdDO2rmu/p3p9d16VYoRxwH8ZukjIw0Put+Y1iiqJ1k6VVWlnGkY7swZO VZNrGgNj3e8mOrwn0nz9lR9oJOP9hmrF0CG3glmM9IRJp2v90WNaoDqXkm0hvRJD YLmdTCr+FHDoefwAmE9fsC22Yr4U46dEmnM0vc0jRJdQdmAiH15f1QHrQ1SwPUnS C7KYqzQnGf6HwtRYbXfa5j+viZc/eNvsiMlCVgmXYg6RQ+jXuN9vbykajnCmyX6q YdQfCxiKj7H8Tv2VX/HlOLay+Zd/qbJbd4o5mmu96ziIQBblKq+oMTWam0VOJmUN xg== Received: (qmail 2312070 invoked from network); 3 Apr 2025 11:07:15 +0200 Received: by mail.zeus03.de with UTF8SMTPSA (TLS_AES_256_GCM_SHA384 encrypted, authenticated); 3 Apr 2025 11:07:15 +0200 X-UD-Smtp-Session: l3s3148p1@Tw+ZGNwx9I4gAwDPXwaqAEtIN5mYkFJw Date: Thu, 3 Apr 2025 11:07:15 +0200 From: Wolfram Sang To: Herve Codina Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Luca Ceresoli , Thomas Petazzoni Subject: Re: [RFC PATCH 2/3] i2c: i2c-core-of: Move children registration in a dedicated function Message-ID: Mail-Followup-To: Wolfram Sang , Herve Codina , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Luca Ceresoli , Thomas Petazzoni References: <20250205173918.600037-1-herve.codina@bootlin.com> <20250205173918.600037-3-herve.codina@bootlin.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="UrlhrmKKNv6iAndD" Content-Disposition: inline In-Reply-To: <20250205173918.600037-3-herve.codina@bootlin.com> --UrlhrmKKNv6iAndD Content-Type: text/plain; charset=us-ascii Content-Disposition: inline > -void of_i2c_register_devices(struct i2c_adapter *adap) > +static void of_i2c_register_children(struct i2c_adapter *adap, > + struct device_node *bus) Could you kindly add a little kdoc so it is easy to understand the difference between of_i2c_register_children() and of_i2c_register_devices()? It is not too obvious from the names alone. --UrlhrmKKNv6iAndD Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAmfuT8MACgkQFA3kzBSg KbY0nRAAplNQaeD5IqrGZw/9auueghG82ZwrE/bCrjUDJWPyChvWw9Bd/b9SC/a7 7YXifYW/ID8EejvdxNsfyQyI++a/bkXJMptt30SZZGtAHkJ3riiVC3NvUwRxbdud SsOSSOUbEY+7BGZMvnYjmLzw3PGSX8ezFkD3izMyBYNnBmA6wPYkTstI6qxFCBoi dJIe7GrLx0CJehgvhDGUPw1snQSizqGJGSjjTbNv/2RD/Y6ntJ4DZ84PNE+DBBGG /wApN+pgb/IzawZ8GaofQzKlfViG9Og/GxfWYXoYvId5FoUAw2yF/OLSJ5CV2T7m cmn1UYvmwyow//irO9G9SUB7EdXrGLhd1c6gYf4KlA66Cqd+DnU9shJqiaMCfSru beBPRcxk6Ss7oVIuC4r3dMi81DRsFc8XGeW+jXtDG8dUqkd6Gpc8wpb4fDODmuXM SHIWEDszgoWW9SDH4i2IhiHUO+uVXIJhMLMqzvJrV5eLzBuvCvD9+DdkYliRnZlP nUMV/eRXvjyPtbnOgsaB8osXw5/eG7tJX1ozoyFMf5YwdD4hd1w20LEvfQR+HjMQ OdgFdgKnl6cGYDnQ22FZsRrjJBLiL0EMmR2GiItlGwnj8P+x4jEKRzx5tgiW7qJq JvDrf6FevO1UyaeVeVxInxKW7d4fcw/ZHtLlsWA1Xx+RsTDCBeY= =aFtT -----END PGP SIGNATURE----- --UrlhrmKKNv6iAndD--