From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Mathieu Dubois-Briand <mathieu.dubois-briand@bootlin.com>
Cc: "Lee Jones" <lee@kernel.org>, "Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Kamel Bouhara" <kamel.bouhara@bootlin.com>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Bartosz Golaszewski" <brgl@bgdev.pl>,
"Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
"Uwe Kleine-König" <ukleinek@kernel.org>,
"Michael Walle" <mwalle@kernel.org>,
"Mark Brown" <broonie@kernel.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
"Danilo Krummrich" <dakr@kernel.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-gpio@vger.kernel.org, linux-input@vger.kernel.org,
linux-pwm@vger.kernel.org,
"Grégory Clement" <gregory.clement@bootlin.com>,
"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>
Subject: Re: [PATCH v5 08/11] gpio: max7360: Add MAX7360 gpio support
Date: Tue, 25 Mar 2025 17:57:00 +0200 [thread overview]
Message-ID: <Z-LSTM48_u3FJLNZ@smile.fi.intel.com> (raw)
In-Reply-To: <D8PFFWYR3ASD.YEZIXPNVZS4I@bootlin.com>
On Tue, Mar 25, 2025 at 03:46:20PM +0100, Mathieu Dubois-Briand wrote:
> On Wed Mar 19, 2025 at 12:50 PM CET, Andy Shevchenko wrote:
> > On Tue, Mar 18, 2025 at 05:26:24PM +0100, Mathieu Dubois-Briand wrote:
...
> > > + /*
> > > + * Port GPIOs with interrupt-controller property: add IRQ
> > > + * controller.
> > > + */
> > > + gpio_config.regmap_irq_flags = IRQF_TRIGGER_LOW | IRQF_ONESHOT | IRQF_SHARED;
> >
> > But why is this being overridden? The DT or another firmware description has to
> > provide the correct settings, no?
>
> Ok, thinking about it, yes, IRQF_TRIGGER_LOW shoud come from firmware
> description. But IRQF_ONESHOT and IRQF_SHARED should still come from
> here, no?
This is my view as well.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2025-03-25 15:57 UTC|newest]
Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-18 16:26 [PATCH v5 00/11] Add support for MAX7360 Mathieu Dubois-Briand
2025-03-18 16:26 ` [PATCH v5 01/11] dt-bindings: mfd: gpio: Add MAX7360 Mathieu Dubois-Briand
2025-03-18 17:39 ` Rob Herring
2025-03-19 16:43 ` Mathieu Dubois-Briand
2025-03-31 8:47 ` Mathieu Dubois-Briand
2025-03-18 16:26 ` [PATCH v5 02/11] mfd: Add max7360 support mathieu.dubois-briand
2025-03-19 11:10 ` Andy Shevchenko
2025-03-25 16:26 ` Mathieu Dubois-Briand
2025-03-25 16:40 ` Andy Shevchenko
2025-03-18 16:26 ` [PATCH v5 03/11] pinctrl: Add MAX7360 pinctrl driver Mathieu Dubois-Briand
2025-03-19 11:13 ` Linus Walleij
2025-03-19 11:35 ` Andy Shevchenko
2025-03-18 16:26 ` [PATCH v5 04/11] pwm: max7360: Add MAX7360 PWM support mathieu.dubois-briand
2025-03-19 11:18 ` Andy Shevchenko
2025-03-20 7:50 ` Uwe Kleine-König
2025-03-20 10:48 ` Andy Shevchenko
2025-03-25 14:37 ` Mathieu Dubois-Briand
2025-03-25 15:56 ` Andy Shevchenko
2025-03-26 14:44 ` Mathieu Dubois-Briand
2025-03-26 15:49 ` Andy Shevchenko
2025-03-26 17:46 ` Uwe Kleine-König
2025-03-27 9:30 ` Andy Shevchenko
2025-03-27 14:28 ` Mathieu Dubois-Briand
2025-03-27 17:50 ` Andy Shevchenko
2025-03-28 8:13 ` Mathieu Dubois-Briand
2025-03-28 12:35 ` Andy Shevchenko
2025-03-25 14:29 ` Mathieu Dubois-Briand
2025-03-25 15:41 ` Andy Shevchenko
2025-03-19 12:57 ` kernel test robot
2025-03-20 2:25 ` kernel test robot
2025-03-18 16:26 ` [PATCH v5 05/11] regmap: irq: Add support for chips without separate IRQ status Mathieu Dubois-Briand
2025-03-18 16:39 ` Andy Shevchenko
2025-03-20 8:45 ` Mathieu Dubois-Briand
2025-03-20 11:00 ` Andy Shevchenko
2025-03-18 16:26 ` [PATCH v5 06/11] gpio: regmap: Allow to allocate regmap-irq device Mathieu Dubois-Briand
2025-03-18 16:52 ` Andy Shevchenko
2025-03-20 7:55 ` Mathieu Dubois-Briand
2025-03-20 10:50 ` Andy Shevchenko
2025-03-19 7:15 ` Michael Walle
2025-03-20 8:35 ` Mathieu Dubois-Briand
2025-03-20 10:55 ` Andy Shevchenko
2025-03-25 8:03 ` Michael Walle
2025-03-25 7:50 ` Michael Walle
2025-03-26 11:00 ` Mathieu Dubois-Briand
2025-03-28 9:23 ` Michael Walle
2025-03-18 16:26 ` [PATCH v5 07/11] gpio: regmap: Allow to provide init_valid_mask callback Mathieu Dubois-Briand
2025-03-18 16:53 ` Andy Shevchenko
2025-03-20 8:48 ` Mathieu Dubois-Briand
2025-03-19 7:02 ` Michael Walle
2025-03-20 8:49 ` Mathieu Dubois-Briand
2025-03-18 16:26 ` [PATCH v5 08/11] gpio: max7360: Add MAX7360 gpio support Mathieu Dubois-Briand
2025-03-19 11:50 ` Andy Shevchenko
2025-03-25 14:46 ` Mathieu Dubois-Briand
2025-03-25 15:57 ` Andy Shevchenko [this message]
2025-03-19 14:12 ` kernel test robot
2025-03-19 22:34 ` kernel test robot
2025-03-18 16:26 ` [PATCH v5 09/11] input: keyboard: Add support for MAX7360 keypad Mathieu Dubois-Briand
2025-03-19 12:02 ` Andy Shevchenko
2025-03-25 14:57 ` Mathieu Dubois-Briand
2025-03-25 15:58 ` Andy Shevchenko
2025-03-19 15:15 ` kernel test robot
2025-03-18 16:26 ` [PATCH v5 10/11] input: misc: Add support for MAX7360 rotary Mathieu Dubois-Briand
2025-03-19 12:11 ` Andy Shevchenko
2025-03-25 15:56 ` Mathieu Dubois-Briand
2025-03-25 16:11 ` Andy Shevchenko
2025-03-19 16:31 ` kernel test robot
2025-03-20 0:29 ` kernel test robot
2025-03-18 16:26 ` [PATCH v5 11/11] MAINTAINERS: Add entry on MAX7360 driver Mathieu Dubois-Briand
2025-03-19 12:12 ` [PATCH v5 00/11] Add support for MAX7360 Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z-LSTM48_u3FJLNZ@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=brgl@bgdev.pl \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=dakr@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=gregory.clement@bootlin.com \
--cc=kamel.bouhara@bootlin.com \
--cc=krzk+dt@kernel.org \
--cc=lee@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=mathieu.dubois-briand@bootlin.com \
--cc=mwalle@kernel.org \
--cc=rafael@kernel.org \
--cc=robh@kernel.org \
--cc=thomas.petazzoni@bootlin.com \
--cc=ukleinek@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).