From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Christian Marangi <ansuelsmth@gmail.com>
Cc: "Andrew Lunn" <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Heiner Kallweit" <hkallweit1@gmail.com>,
"Florian Fainelli" <florian.fainelli@broadcom.com>,
"Broadcom internal kernel review list"
<bcm-kernel-feedback-list@broadcom.com>,
"Marek Behún" <kabel@kernel.org>,
"Andrei Botila" <andrei.botila@oss.nxp.com>,
"Sabrina Dubroca" <sd@queasysnail.net>,
"Daniel Golle" <daniel@makrotopia.org>,
"Eric Woudstra" <ericwouds@gmail.com>,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [net-next RFC PATCH v4 1/6] net: phy: pass PHY driver to .match_phy_device OP
Date: Fri, 28 Mar 2025 08:24:44 +0000 [thread overview]
Message-ID: <Z-ZczBztZbnc8XPa@shell.armlinux.org.uk> (raw)
In-Reply-To: <20250327224529.814-2-ansuelsmth@gmail.com>
On Thu, Mar 27, 2025 at 11:45:12PM +0100, Christian Marangi wrote:
> Pass PHY driver pointer to .match_phy_device OP in addition to phydev.
> Having access to the PHY driver struct might be useful to check the
> PHY ID of the driver is being matched for in case the PHY ID scanned in
> the phydev is not consistent.
>
> A scenario for this is a PHY that change PHY ID after a firmware is
> loaded, in such case, the PHY ID stored in PHY device struct is not
> valid anymore and PHY will manually scan the ID in the match_phy_device
> function.
>
> Having the PHY driver info is also useful for those PHY driver that
> implement multiple simple .match_phy_device OP to match specific MMD PHY
> ID. With this extra info if the parsing logic is the same, the matching
> function can be generalized by using the phy_id in the PHY driver
> instead of hardcoding.
>
> Suggested-by: Reviewed-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
Too much copy'n'pasting?
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2025-03-28 8:25 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-27 22:45 [net-next RFC PATCH v4 0/6] net: phy: Add support for new Aeonsemi PHYs Christian Marangi
2025-03-27 22:45 ` [net-next RFC PATCH v4 1/6] net: phy: pass PHY driver to .match_phy_device OP Christian Marangi
2025-03-28 8:24 ` Russell King (Oracle) [this message]
2025-03-28 8:29 ` Christian Marangi
2025-03-27 22:45 ` [net-next RFC PATCH v4 2/6] net: phy: bcm87xx: simplify " Christian Marangi
2025-03-27 22:45 ` [net-next RFC PATCH v4 3/6] net: phy: nxp-c45-tja11xx: " Christian Marangi
2025-03-28 8:31 ` Russell King (Oracle)
2025-03-27 22:45 ` [net-next RFC PATCH v4 4/6] net: phy: introduce genphy_match_phy_device() Christian Marangi
2025-03-27 22:45 ` [net-next RFC PATCH v4 5/6] net: phy: Add support for Aeonsemi AS21xxx PHYs Christian Marangi
2025-03-27 22:45 ` [net-next RFC PATCH v4 6/6] dt-bindings: net: Document support for Aeonsemi PHYs Christian Marangi
2025-03-31 20:40 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z-ZczBztZbnc8XPa@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=andrei.botila@oss.nxp.com \
--cc=andrew+netdev@lunn.ch \
--cc=ansuelsmth@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=conor+dt@kernel.org \
--cc=daniel@makrotopia.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=ericwouds@gmail.com \
--cc=florian.fainelli@broadcom.com \
--cc=hkallweit1@gmail.com \
--cc=kabel@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=robh@kernel.org \
--cc=sd@queasysnail.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).