From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DE7EC1E1022; Mon, 31 Mar 2025 11:00:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743418808; cv=none; b=UyeV4e9Jj/Df2V1IlXZUExHkcxNqbERiG8OkrPsHn6AioB/5nKNbvE8lu78At9jStT3qN48pels5qkCULXOKgDqd9qiX+8vu2Kpfj6zizQNCEu9xVz+YIyBHbzx+VijpHqn1nUyhR2FaY5Nhqrn3Y15b0F2YVEM4rkWFz53uh4Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743418808; c=relaxed/simple; bh=cld3lKxTDUu1Y017kQ5wCwIuFGJrB2vDX2SYmnv1YDE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=XtEXfeJxOqeuWwynuN1w7GqE/ijkwtghDPt0/1GeeOCrvtwqkf/WWwTH3/fvQrOEgtsWJMDrsE7w7ADajizfaKu2u6N0QaAP9NEtcCwwmRTvmPpKAAw7LYkB78z4/VKWLIELueXLTDRxt23T9z7krvZuj3v851GVW5/DSqae34U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=g2NDbTtm; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="g2NDbTtm" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 47B86C4CEE3; Mon, 31 Mar 2025 11:00:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1743418806; bh=cld3lKxTDUu1Y017kQ5wCwIuFGJrB2vDX2SYmnv1YDE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=g2NDbTtm2fnQtfkndR19AJeXfOsg0aKBR2zhOLRbu/9G8MGRZ1S7rQHaG6x9vRzTy i3af8JbkRk75lFo8ihOyRc0MVCUuvUa8AujywyGInIhU+fKBi8VIrwUqZ7GjjkDd1c V7eYlKTZ+yvSEromo+SjihkEQY+NkhlsEtXc0RSyDGUtnuTQjmnORHU3InLe2ziFYx phqxJ12Hh7ynoTlbCRghVk9JXld7NPMhl2TsXaY6Vm3kAAYNRFtMpitT+LUGQoMlwa LmwWYmAI1sL5Eq8sEjFKyoVN1k1MzPHQIOjYO6veyU1OZbm8043mv5cZpZzdD3FbcY G+5t4zgAyjO1Q== Received: from johan by xi.lan with local (Exim 4.97.1) (envelope-from ) id 1tzCsC-000000006dk-0laY; Mon, 31 Mar 2025 13:00:08 +0200 Date: Mon, 31 Mar 2025 13:00:08 +0200 From: Johan Hovold To: Aleksandrs Vinarskis Cc: "Tudor, Laurentiu" , Bryan O'Donoghue , Bjorn Andersson , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , dmitry.baryshkov@oss.qualcomm.com, Stephan Gerhold Subject: Re: [PATCH v2 1/1] arm64: dts: qcom: x1e80100-dell-xps-9345: Add WiFi/BT pwrseq Message-ID: References: <20250331073423.3184322-1-alex.vinarskis@gmail.com> <20250331073423.3184322-2-alex.vinarskis@gmail.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Mon, Mar 31, 2025 at 11:38:25AM +0200, Aleksandrs Vinarskis wrote: > On Mon, 31 Mar 2025 at 10:09, Johan Hovold wrote: > > > > [ +CC: Stephan ] > > > > On Mon, Mar 31, 2025 at 08:33:47AM +0100, Aleksandrs Vinarskis wrote: > > > Add the WiFi/BT nodes for XPS and describe the regulators for the WCN7850 > > > combo chip using the new power sequencing bindings. All voltages are > > > derived from chained fixed regulators controlled using a single GPIO. > > > > > > Based on the commit d09ab685a8f5 ("arm64: dts: qcom: x1e80100-qcp: Add > > > WiFi/BT pwrseq"). > > > > Are you sure this is correct and that you don't need to worry about the > > "how do we model the supplies to an M.2 card" issue? > > > > See > > > > https://lore.kernel.org/lkml/Z-KuG0aOwEnxuhp9@linaro.org/ > > Dell XPS 9345 does not have an M.2 card, WLAN package is soldered > directly onboard, hence I am quite sure this is similar to QCP. > To be certain, perhaps @Tudor, Laurentiu or @Bryan O'Donoghue (if you > have it?) could confirm from schematics? I checked now, it seems you are correct. Highly annoying that we need all this guess-work boiler plate (about chip internal details) for what is effectively just two supplies. Hopefully we can drop that again going forward, but that's a separate discussion. > > > With that fixed commit f5b788d0e8cd ("arm64: dts: qcom: Add support for > > > X1-based Dell XPS 13 9345") > > > > Not sure what happened here. > > Bluetooth and WLAN definitions were missing, as at the time I only > knew the UART port being used for bluetooth, and was missing > everything else to describe it. Ah, ok. The above sentence looked like some left-over copy paste. I guess you don't need to mention it at all since this does not seem to warrant a proper Fixes tag. Johan