Re: [PATCH v1 1/3] dt-bindings: iio: pressure: bmp085: Add SPI interface

Vasileios Amoiridis
2024-11-29T23:51:52Z

On Fri, Nov 29, 2024 at 08:22:00AM +0100, Krzysztof Kozlowski wrote:
> On Fri, Nov 29, 2024 at 12:24:48AM +0100, Vasileios Amoiridis wrote:
> > @@ -73,6 +77,19 @@ allOf:
> > then:
> > properties:
> > interrupts: false
> > + - if:
> > + properties:
> > + compatible:
> > + not:
> > + contains:
> > + enum:
>
> You have just two variants in this "not-containts", so invert your
> clause. Easier code.
>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> Best regards,
> Krzysztof
>

Hi Krzysztof,

Thank you very much for the review! I will fix it in the next version.

Cheers,
Vasilis