Re: [PATCH v1 1/3] dt-bindings: iio: pressure: bmp085: Add SPI interface

Vasileios Amoiridis
2024-12-02T22:04:38Z

On Mon, Dec 02, 2024 at 02:46:13PM -0600, Rob Herring (Arm) wrote:
>
> On Mon, 02 Dec 2024 19:19:05 +0100, Vasileios Amoiridis wrote:
> > The BMP{2,3,5}80 and BME280 devices have an SPI interface, so include it
> > in the device-tree.
> >
> > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> > Signed-off-by: Vasileios Amoiridis <vassilisamir@gmail.com>
> > ---
> > .../bindings/iio/pressure/bmp085.yaml | 32 +++++++++++++++++++
> > 1 file changed, 32 insertions(+)
> >
>
> My bot found errors running 'make dt_binding_check' on your patch:
>
> yamllint warnings/errors:
>
> dtschema/dtc warnings/errors:
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/iio/pressure/bmp085.example.dtb: pressure@0: interrupts: False schema does not allow [[25, 1]]

Hi Rob, Krzysztof,

The error is in the example, I put the tree from the I2C example to SPI
but I used bmp280 which is not supporting interrupts. Will be fixed.

Cheers,
Vasilis

> from schema $id: http://devicetree.org/schemas/iio/pressure/bmp085.yaml#
>
> doc reference errors (make refcheckdocs):
>
> See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20241202181907.21471-2-vassilisamir@gmail.com
>
> The base for the series is generally the latest rc1. A different dependency
> should be noted in *this* patch.
>
> If you already ran 'make dt_binding_check' and didn't see the above
> error(s), then make sure 'yamllint' is installed and dt-schema is up to
> date:
>
> pip3 install dtschema --upgrade
>
> Please check and re-submit after running the above command yourself. Note
> that DT_SCHEMA_FILES can be set to your schema file to speed up checking
> your schema. However, it must be unset to test all examples with your schema.
>