From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f42.google.com (mail-ej1-f42.google.com [209.85.218.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 391DE14B077 for ; Fri, 29 Nov 2024 16:27:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732897670; cv=none; b=HuNdHHS6JAJ3lMa8EkJJcZTxIgNVbwcura72PRcJTEISngAyDGwTbJ7wPA29V/rOQ15opq8E834qVZi7Vqrj6+55PRPuy72BW69k91f2BcqCmkgnojnjSIW+gerUl4clypJWBW+wofLm6+4GVrM5bOCxzseFx3NUTMUM3vCb45k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732897670; c=relaxed/simple; bh=5w1O89chOqgyMhWZqb9VM6E+m7Ixqgv0RFEj+OZES/M=; h=From:Date:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=DUTMy85AOAt/2m5AZo75O/HdNwe8UrOaoc0KVbRKVL8NsaBWQVwReBT6RIh/E6YOmagrGeX2zOPZ0OJvoPlHLwl+5gfonn4aP3E0YKWKa4hHgXMetTgCYRvamY36uIhCngDkDDNPOwqS4Q3gZLFJIrfOWCyp250VHuRPg7F+/Ik= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=SXKYN/KE; arc=none smtp.client-ip=209.85.218.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="SXKYN/KE" Received: by mail-ej1-f42.google.com with SMTP id a640c23a62f3a-aa578d10d50so328171266b.1 for ; Fri, 29 Nov 2024 08:27:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1732897666; x=1733502466; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=OwH5v+3GE18kFTNrayT4BgfE0WPSq36ccL8dVwg+Yh0=; b=SXKYN/KEOyynrFJcDSY9fKinPxPtzm7uWRAULf7byMbXWKz2zCJu6+aQnV0Ep6+Wpz UWoux77G37vEbXIdP0h95EneTQqw8W2nAx5UaY/ePqEfSOrxE9elLbGEcs/ZIqsv6bqF Y6Ukh96oPrRmCQvTdqpOU/xxQW0kIQIsYqzpkA823EiuH7tr+sBr8y/aZY7OEBoPuO07 4yeVObIAAL64qCdwaLxiXHktmKeQrd/sagClP4y8JbCRwV36elsRVvcFRCncLiiHcx1g NDURsOThUhktc//Il1++bMjEk9NqtJYNbliGeWiyN9/7LaoAe4Js8NNjnaRwr1ql/4DY EUwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732897666; x=1733502466; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=OwH5v+3GE18kFTNrayT4BgfE0WPSq36ccL8dVwg+Yh0=; b=lMVH+Nm+N7gCdhaM3HfkPATPomlWs+YiBtlNIFfVPn4mLzPzEmjd0d4boMiFtANIVr vNa1tZ0/R6NFf0B+IoEnI91eCLPbc60IST7bfx8ngBDN1FSr2Qge6TQOj+owyaojYRk6 qQCPE2It6rfiubiTrGx8du8qINs93k5WgYe6vXZ2vAjGAdvaX5B8f0TCN9nOJhNmmSUM LbPeOP9yWRou2/18I6pWg7WVIR2WM+5trde4G/NOIuTpPrClmZiojT+cD9r8BFAOQ/d0 042iOhnB4yUlGK9ej0XgQoRo6hqJ0DlcJRzOrMKoOVsPf5opzyMNCuMWjNSWd+iTUoE1 uJjQ== X-Forwarded-Encrypted: i=1; AJvYcCXpNDcnbIaE054/39K0q2swgy2r3hjUfqi0Z8pGeE19//2JfnuPtYhmuE+tsl9zg3lqQ/stCTrUWhEH@vger.kernel.org X-Gm-Message-State: AOJu0YySpUspPq/Km+YbVe3kNoTPK+0Nx9nUGhzfpZDUyLOCNUjUhaGC DOcOvsPsh08HWhC46nd6bzlOSIDn5aiOOC472fm/Zwos1YBc+FhPvd3+i7dGd9A= X-Gm-Gg: ASbGncsIV5ZwHpavKX/NKSIpRRAhJUrtvjJZSPyOURiGwe8sqeagzRjrVShTyDF6SIM aFvlVCeLIy7sqzMpzobUpWhQOJFwum6okzJWCBekfEjMwbLLEipsyl7lHlYr+XX6yZj67+lfPCz fOjim8vdxXNippE7PMH9eJGPVoBPeaEsLBw+X9XUNhQba9b8iJSuKL8WROSqy1Fo4glBooCrnOO uSiEYchpGLwKfdaHQXfSE1Oty5BqZhLamT+FdRuJ7Zln7IzCW7GsJl9Jsv//jihwdfIAcH40BV3 Au4xFsgU5JerCmeSMe9K X-Google-Smtp-Source: AGHT+IFdG9GOu7z7VbF3RaWxqyGcxIpQuKws1pr8ZUhjgAPYuz3ueFSPxNUGdj5E67EBohC3LgYQSw== X-Received: by 2002:a17:906:318d:b0:aa5:1957:3431 with SMTP id a640c23a62f3a-aa580edfbfcmr1150158266b.1.1732897666347; Fri, 29 Nov 2024 08:27:46 -0800 (PST) Received: from localhost (host-79-49-220-127.retail.telecomitalia.it. [79.49.220.127]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-aa5996c193asm189510666b.38.2024.11.29.08.27.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 Nov 2024 08:27:45 -0800 (PST) From: Andrea della Porta X-Google-Original-From: Andrea della Porta Date: Fri, 29 Nov 2024 17:28:19 +0100 To: Stefan Wahren Cc: Andrea della Porta , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Florian Fainelli , Broadcom internal kernel review list , Lorenzo Pieralisi , Krzysztof Wilczynski , Manivannan Sadhasivam , Bjorn Helgaas , Linus Walleij , Catalin Marinas , Will Deacon , Bartosz Golaszewski , Derek Kiernan , Dragan Cvetic , Arnd Bergmann , Greg Kroah-Hartman , Saravana Kannan , linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, linux-gpio@vger.kernel.org, Masahiro Yamada , Herve Codina , Luca Ceresoli , Thomas Petazzoni , Andrew Lunn Subject: Re: [PATCH v4 08/10] misc: rp1: RaspberryPi RP1 misc driver Message-ID: References: Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Hi Stephan, On 19:35 Mon 25 Nov , Stefan Wahren wrote: > Hi Andrea, > > Am 24.11.24 um 11:51 schrieb Andrea della Porta: > > The RaspberryPi RP1 is a PCI multi function device containing > > peripherals ranging from Ethernet to USB controller, I2C, SPI > > and others. > > ... > > + Support the RP1 peripheral chip found on Raspberry Pi 5 board. > > + controller, USB controller, I2C, SPI and UART. > > + > > + The driver is responsible for enabling the DT node once the PCIe > > + endpoint has been configured, and handling interrupts. > > + > > + This driver uses an overlay to load other drivers to support for > > + RP1 internal sub-devices. > Please fix up the leading whitespace here Ack. > > diff --git a/drivers/misc/rp1/Makefile b/drivers/misc/rp1/Makefile > > new file mode 100644 > > index 000000000000..508b4cb05627 > > --- /dev/null > > +++ b/drivers/misc/rp1/Makefile > > @@ -0,0 +1,3 @@ > > +# SPDX-License-Identifier: GPL-2.0-only ... > > +#define RP1_INT_SYSCFG 58 > > +#define RP1_INT_CLOCKS_DEFAULT 59 > > +#define RP1_INT_VBUSCTRL 60 > > +#define RP1_INT_PROC_MISC 57 > > +#define RP1_INT_END 61 > > + > > +struct rp1_dev { > > + struct pci_dev *pdev; > > + struct irq_domain *domain; > > + struct irq_data *pcie_irqds[64]; > > + void __iomem *bar1; > > + int ovcs_id; > /* overlay changeset id */ Ack. > > + bool level_triggered_irq[RP1_INT_END]; > > +}; > > + > > +static void msix_cfg_set(struct rp1_dev *rp1, unsigned int hwirq, u32 value) > > +{ ... > > + struct device_node *rp1_node; > > + struct rp1_dev *rp1; > > + int err = 0; > Please remove the extra space after err Ack. > > + int i; > > + > > + rp1_node = dev_of_node(dev); > > + if (!rp1_node) { > > + dev_err(dev, "Missing of_node for device\n"); > > + return -EINVAL; > > + } > > + > > + rp1 = devm_kzalloc(&pdev->dev, sizeof(*rp1), GFP_KERNEL); > > + if (!rp1) > > + return -ENOMEM; > > + > > + rp1->pdev = pdev; ... > > + err = pci_alloc_irq_vectors(pdev, RP1_INT_END, RP1_INT_END, > > + PCI_IRQ_MSIX); > > + if (err < 0) > > + return dev_err_probe(&pdev->dev, err, > > + "pci_alloc_irq_vectors failed"); > > + else if (err != RP1_INT_END) { > Please add braces for the if case Ack. Many thanks, Andrea > > + dev_err(&pdev->dev, "Cannot allocate enough interrupts\n"); > > + return -EINVAL; > > + } > > + > >