From: Vasileios Amoiridis <vassilisamir@gmail.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: jic23@kernel.org, lars@metafoo.de, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org,
andriy.shevchenko@linux.intel.com, linux-iio@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 1/3] dt-bindings: iio: bosch,bme680: Move from trivial-devices and add supplies
Date: Sat, 30 Nov 2024 00:49:06 +0100 [thread overview]
Message-ID: <Z0pS8sQOfkQBKEId@vamoirid-laptop> (raw)
In-Reply-To: <wdtkd73brhfotps4crpbpgdvtzrc25xr3bq2au2d3uzrl5pwz2@7ssawm3gyyfo>
On Fri, Nov 29, 2024 at 08:12:21AM +0100, Krzysztof Kozlowski wrote:
> On Thu, Nov 28, 2024 at 08:32:44PM +0100, Vasileios Amoiridis wrote:
> > + - |
> > + i2c {
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > +
> > + bme680@77 {
>
> Node names should be generic. See also an explanation and list of
> examples (not exhaustive) in DT specification:
> https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
>
> E.g. gas-sensor
>
> Same in other places.
>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> Best regards,
> Krzysztof
>
Hi Krzysztof,
Thank you very much for the review! I will fix it in the next version.
Cheers,
Vasilis
next prev parent reply other threads:[~2024-11-29 23:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-28 19:32 [PATCH v4 0/3] iio: chemical bme680: 2nd round of cleanup Vasileios Amoiridis
2024-11-28 19:32 ` [PATCH v4 1/3] dt-bindings: iio: bosch,bme680: Move from trivial-devices and add supplies Vasileios Amoiridis
2024-11-29 7:12 ` Krzysztof Kozlowski
2024-11-29 23:49 ` Vasileios Amoiridis [this message]
2024-11-28 19:32 ` [PATCH v4 2/3] iio: chemical: bme680: add regulators Vasileios Amoiridis
2024-11-29 14:33 ` Andy Shevchenko
2024-11-30 14:26 ` Jonathan Cameron
2024-12-02 18:26 ` Vasileios Amoiridis
2024-11-28 19:32 ` [PATCH v4 3/3] iio: chemical: bme680: add power management Vasileios Amoiridis
2024-11-29 14:32 ` Andy Shevchenko
2024-11-29 23:50 ` Vasileios Amoiridis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z0pS8sQOfkQBKEId@vamoirid-laptop \
--to=vassilisamir@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox