From: Richard Acayan <mailingradian@gmail.com>
To: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Cc: Bjorn Andersson <andersson@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Robert Foss <rfoss@kernel.org>, Todor Tomov <todor.too@gmail.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org, linux-media@vger.kernel.org,
Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>
Subject: Re: [PATCH v7 5/5] arm64: dts: qcom: sdm670: add camss and cci
Date: Sat, 14 Dec 2024 00:24:55 -0500 [thread overview]
Message-ID: <Z10Wpwhp_ulC2KhF@radian> (raw)
In-Reply-To: <Z10FkmBq95HQkOgv@radian>
On Fri, Dec 13, 2024 at 11:12:02PM -0500, Richard Acayan wrote:
> On Wed, Dec 11, 2024 at 11:24:30AM +0000, Bryan O'Donoghue wrote:
> > On 11/12/2024 00:30, Richard Acayan wrote:
> > > > I think you sorted the regs, interrupts but forgot the clocks ?
> > > Do you mean the first three clocks placed first? The order was suggested
> > > by Vladimir in [1], but I can undo it.
> > >
> > > [1]https://lore.kernel.org/r/40cd7a52-1c60-40dc-aee6-730b5247b216@linaro.org
> >
> > We've had a long, long discussion on ordering subsequent.
> >
> > Have a look at the sc7280 and align your ordering with that.
>
> Ok, it seems SC7280 renames the CSID clocks to change their alphabetical
> sorting so I'll rename them as well.
>
> csi0 -> vfe0_csid
> csi1 -> vfe1_csid
> csi2 -> vfe_lite_csid
Let's not do this, the "csiX" clock names are also used in camss-csid.c
and would need deeper driver changes.
prev parent reply other threads:[~2024-12-14 5:25 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-10 23:35 [PATCH v7 0/5] Add SDM670 camera subsystem Richard Acayan
2024-12-10 23:35 ` [PATCH v7 1/5] dt-bindings: clock: qcom,sdm845-camcc: add sdm670 compatible Richard Acayan
2024-12-10 23:35 ` [PATCH v7 2/5] dt-bindings: media: camss: Add qcom,sdm670-camss Richard Acayan
2024-12-10 23:45 ` Bryan O'Donoghue
2024-12-10 23:35 ` [PATCH v7 3/5] media: qcom: camss: add support for SDM670 camss Richard Acayan
2024-12-10 23:46 ` Bryan O'Donoghue
2024-12-10 23:35 ` [PATCH v7 4/5] arm64: dts: qcom: sdm670: add camcc Richard Acayan
2024-12-10 23:35 ` [PATCH v7 5/5] arm64: dts: qcom: sdm670: add camss and cci Richard Acayan
2024-12-10 23:49 ` Bryan O'Donoghue
2024-12-11 0:30 ` Richard Acayan
2024-12-11 11:24 ` Bryan O'Donoghue
2024-12-14 4:12 ` Richard Acayan
2024-12-14 5:24 ` Richard Acayan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z10Wpwhp_ulC2KhF@radian \
--to=mailingradian@gmail.com \
--cc=andersson@kernel.org \
--cc=bryan.odonoghue@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=mturquette@baylibre.com \
--cc=rfoss@kernel.org \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=todor.too@gmail.com \
--cc=vladimir.zapolskiy@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).