[PATCH v3 0/2] Add support for J722S CSI BCDMA

[PATCH v3 0/2] Add support for J722S CSI BCDMA

[Vaishnav Achath]

This series adds support for CSI Block Copy DMA (BCDMA) instance on J722S,
the BCDMA instance is similar to other CSI BCDMA found in rest of TI
devices like J721S2, AM62A. It supports both RX (CSI2RX) and TX (CSITX)
channels and is identical to J721S2 CSIRX BCDMA but has slight integration
difference in the PSIL base thread ID which is currently handled in the 
k3-udma driver from the match_data, introduce a new compatible to support
J722S BCDMA.

Changelog:
  V2->V3:
    * Added missing compatible entry missed in v2.
    * Address Krzysztof's review comments to not wrap commit
    message too early.

  V1->V2:
    * Address review from Conor to add new J722S compatible
    * J722S BCDMA is more similar to J721S2 in terms of RX/TX support,
    add an entry alongside J721S2 instead of modifying AM62A.

V1: https://lore.kernel.org/all/20241125083914.2934815-1-vaishnav.a@ti.com/
V2: https://lore.kernel.org/all/20241126125158.37744-1-vaishnav.a@ti.com/

CSI2RX capture test results on J722S EVM with 4 x IMX219:
https://gist.github.com/vaishnavachath/e2eaed62ee8f53428ee9b830aaa02cc3

Branch with all the DT changes on top of this integrated:
https://github.com/vaishnavachath/linux/tree/j722scsi

Vaishnav Achath (2):
  dt-bindings: dma: ti: k3-bcdma: Add J722S CSI BCDMA
  dmaengine: ti: k3-udma: Add support for J722S CSI BCDMA

 .../devicetree/bindings/dma/ti/k3-bcdma.yaml     |  5 ++++-
 drivers/dma/ti/k3-udma.c                         | 16 ++++++++++++++++
 2 files changed, 20 insertions(+), 1 deletion(-)

-- 
2.34.1

[PATCH v3 1/2] dt-bindings: dma: ti: k3-bcdma: Add J722S CSI BCDMA

[Vaishnav Achath]

J722S CSI BCDMA is similar to J721S2 CSI BCDMA and supports both RX and TX
channels but has a different PSIL thread base ID which is currently
handled in k3-udma driver. Add an entry for J722S CSIRX BCDMA.

Signed-off-by: Vaishnav Achath <vaishnav.a@ti.com>
---

V2->V3:
  * Added missing compatible entry missed in v2.
  * Address Krzysztof's review comments to not wrap commit
  message too early.

V1->V2:
  * Address review from Conor to add new J722S compatible
  * J722S BCDMA is more similar to J721S2 in terms of RX/TX support,
  add an entry alongside J721S2 instead of modifying AM62A.

 Documentation/devicetree/bindings/dma/ti/k3-bcdma.yaml | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/dma/ti/k3-bcdma.yaml b/Documentation/devicetree/bindings/dma/ti/k3-bcdma.yaml
index 27b8e1636560..b5bc842c5a0e 100644
--- a/Documentation/devicetree/bindings/dma/ti/k3-bcdma.yaml
+++ b/Documentation/devicetree/bindings/dma/ti/k3-bcdma.yaml
@@ -34,6 +34,7 @@ properties:
       - ti,am62a-dmss-bcdma-csirx
       - ti,am64-dmss-bcdma
       - ti,j721s2-dmss-bcdma-csi
+      - ti,j722s-dmss-bcdma-csi
 
   reg:
     minItems: 3
@@ -196,7 +197,9 @@ allOf:
       properties:
         compatible:
           contains:
-            const: ti,j721s2-dmss-bcdma-csi
+            enum:
+              - ti,j721s2-dmss-bcdma-csi
+              - ti,j722s-dmss-bcdma-csi
     then:
       properties:
         ti,sci-rm-range-bchan: false
-- 
2.34.1

[PATCH v3 2/2] dmaengine: ti: k3-udma: Add support for J722S CSI BCDMA

[Vaishnav Achath]

J722S CSI BCDMA is similar to J721S2 CSI BCDMA but there are slight
integration differences like different PSIL thread base ID which is
currently handled in the driver based on udma_of_match data. Add an
entry to support J722S CSIRX.

Signed-off-by: Vaishnav Achath <vaishnav.a@ti.com>
---

V2->V3 : Minor edit in commit message.

V1->V2:
	* Add new compatible for J722S instead of modifying AM62A

 drivers/dma/ti/k3-udma.c | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

diff --git a/drivers/dma/ti/k3-udma.c b/drivers/dma/ti/k3-udma.c
index b3f27b3f9209..7ed1956b4642 100644
--- a/drivers/dma/ti/k3-udma.c
+++ b/drivers/dma/ti/k3-udma.c
@@ -4404,6 +4404,18 @@ static struct udma_match_data j721s2_bcdma_csi_data = {
 	.soc_data = &j721s2_bcdma_csi_soc_data,
 };
 
+static struct udma_match_data j722s_bcdma_csi_data = {
+	.type = DMA_TYPE_BCDMA,
+	.psil_base = 0x3100,
+	.enable_memcpy_support = false,
+	.burst_size = {
+		TI_SCI_RM_UDMAP_CHAN_BURST_SIZE_64_BYTES, /* Normal Channels */
+		0, /* No H Channels */
+		0, /* No UH Channels */
+	},
+	.soc_data = &j721s2_bcdma_csi_soc_data,
+};
+
 static const struct of_device_id udma_of_match[] = {
 	{
 		.compatible = "ti,am654-navss-main-udmap",
@@ -4435,6 +4447,10 @@ static const struct of_device_id udma_of_match[] = {
 		.compatible = "ti,j721s2-dmss-bcdma-csi",
 		.data = &j721s2_bcdma_csi_data,
 	},
+	{
+		.compatible = "ti,j722s-dmss-bcdma-csi",
+		.data = &j722s_bcdma_csi_data,
+	},
 	{ /* Sentinel */ },
 };
 MODULE_DEVICE_TABLE(of, udma_of_match);
-- 
2.34.1

Re: [PATCH v3 1/2] dt-bindings: dma: ti: k3-bcdma: Add J722S CSI BCDMA

[Rob Herring (Arm)]

On Wed, 27 Nov 2024 15:46:26 +0530, Vaishnav Achath wrote:
> J722S CSI BCDMA is similar to J721S2 CSI BCDMA and supports both RX and TX
> channels but has a different PSIL thread base ID which is currently
> handled in k3-udma driver. Add an entry for J722S CSIRX BCDMA.
> 
> Signed-off-by: Vaishnav Achath <vaishnav.a@ti.com>
> ---
> 
> V2->V3:
>   * Added missing compatible entry missed in v2.
>   * Address Krzysztof's review comments to not wrap commit
>   message too early.
> 
> V1->V2:
>   * Address review from Conor to add new J722S compatible
>   * J722S BCDMA is more similar to J721S2 in terms of RX/TX support,
>   add an entry alongside J721S2 instead of modifying AM62A.
> 
>  Documentation/devicetree/bindings/dma/ti/k3-bcdma.yaml | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 

Reviewed-by: Rob Herring (Arm) <robh@kernel.org>

Re: [PATCH v3 2/2] dmaengine: ti: k3-udma: Add support for J722S CSI BCDMA

[Vinod Koul]

On 27-11-24, 15:46, Vaishnav Achath wrote:
> J722S CSI BCDMA is similar to J721S2 CSI BCDMA but there are slight
> integration differences like different PSIL thread base ID which is
> currently handled in the driver based on udma_of_match data. Add an
> entry to support J722S CSIRX.
> 
> Signed-off-by: Vaishnav Achath <vaishnav.a@ti.com>
> ---
> 
> V2->V3 : Minor edit in commit message.
> 
> V1->V2:
> 	* Add new compatible for J722S instead of modifying AM62A
> 
>  drivers/dma/ti/k3-udma.c | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
> 
> diff --git a/drivers/dma/ti/k3-udma.c b/drivers/dma/ti/k3-udma.c
> index b3f27b3f9209..7ed1956b4642 100644
> --- a/drivers/dma/ti/k3-udma.c
> +++ b/drivers/dma/ti/k3-udma.c
> @@ -4404,6 +4404,18 @@ static struct udma_match_data j721s2_bcdma_csi_data = {
>  	.soc_data = &j721s2_bcdma_csi_soc_data,
>  };
>  
> +static struct udma_match_data j722s_bcdma_csi_data = {
> +	.type = DMA_TYPE_BCDMA,
> +	.psil_base = 0x3100,
> +	.enable_memcpy_support = false,
> +	.burst_size = {
> +		TI_SCI_RM_UDMAP_CHAN_BURST_SIZE_64_BYTES, /* Normal Channels */
> +		0, /* No H Channels */
> +		0, /* No UH Channels */

Why are these zeros? we expect valid size...

> +	},
> +	.soc_data = &j721s2_bcdma_csi_soc_data,
> +};
> +
>  static const struct of_device_id udma_of_match[] = {
>  	{
>  		.compatible = "ti,am654-navss-main-udmap",
> @@ -4435,6 +4447,10 @@ static const struct of_device_id udma_of_match[] = {
>  		.compatible = "ti,j721s2-dmss-bcdma-csi",
>  		.data = &j721s2_bcdma_csi_data,
>  	},
> +	{
> +		.compatible = "ti,j722s-dmss-bcdma-csi",
> +		.data = &j722s_bcdma_csi_data,
> +	},
>  	{ /* Sentinel */ },
>  };
>  MODULE_DEVICE_TABLE(of, udma_of_match);
> -- 
> 2.34.1

-- 
~Vinod

Re: [PATCH v3 2/2] dmaengine: ti: k3-udma: Add support for J722S CSI BCDMA

[Vaishnav Achath]

Hi Vinod,

On 04/12/24 18:00, Vinod Koul wrote:
> On 27-11-24, 15:46, Vaishnav Achath wrote:
>> J722S CSI BCDMA is similar to J721S2 CSI BCDMA but there are slight
>> integration differences like different PSIL thread base ID which is
>> currently handled in the driver based on udma_of_match data. Add an
>> entry to support J722S CSIRX.
>>
>> Signed-off-by: Vaishnav Achath <vaishnav.a@ti.com>
>> ---
>>
>> V2->V3 : Minor edit in commit message.
>>
>> V1->V2:
>> 	* Add new compatible for J722S instead of modifying AM62A
>>
>>   drivers/dma/ti/k3-udma.c | 16 ++++++++++++++++
>>   1 file changed, 16 insertions(+)
>>
>> diff --git a/drivers/dma/ti/k3-udma.c b/drivers/dma/ti/k3-udma.c
>> index b3f27b3f9209..7ed1956b4642 100644
>> --- a/drivers/dma/ti/k3-udma.c
>> +++ b/drivers/dma/ti/k3-udma.c
>> @@ -4404,6 +4404,18 @@ static struct udma_match_data j721s2_bcdma_csi_data = {
>>   	.soc_data = &j721s2_bcdma_csi_soc_data,
>>   };
>>   
>> +static struct udma_match_data j722s_bcdma_csi_data = {
>> +	.type = DMA_TYPE_BCDMA,
>> +	.psil_base = 0x3100,
>> +	.enable_memcpy_support = false,
>> +	.burst_size = {
>> +		TI_SCI_RM_UDMAP_CHAN_BURST_SIZE_64_BYTES, /* Normal Channels */
>> +		0, /* No H Channels */
>> +		0, /* No UH Channels */
> 
> Why are these zeros? we expect valid size...
> 

Sorry for the delay in response, this instance does not have High 
capacity/Ultra high capacity channels, the burst_size for normal 
channels is non-zero in the above, this is done similar to other 
instances supported in the driver:

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/dma/ti/k3-udma.c#n4363

Please let me know if something need to be fixed.

Thanks and Regards,
Vaishnav

>> +	},
>> +	.soc_data = &j721s2_bcdma_csi_soc_data,
>> +};
>> +
>>   static const struct of_device_id udma_of_match[] = {
>>   	{
>>   		.compatible = "ti,am654-navss-main-udmap",
>> @@ -4435,6 +4447,10 @@ static const struct of_device_id udma_of_match[] = {
>>   		.compatible = "ti,j721s2-dmss-bcdma-csi",
>>   		.data = &j721s2_bcdma_csi_data,
>>   	},
>> +	{
>> +		.compatible = "ti,j722s-dmss-bcdma-csi",
>> +		.data = &j722s_bcdma_csi_data,
>> +	},
>>   	{ /* Sentinel */ },
>>   };
>>   MODULE_DEVICE_TABLE(of, udma_of_match);
>> -- 
>> 2.34.1
> 

Re: [PATCH v3 2/2] dmaengine: ti: k3-udma: Add support for J722S CSI BCDMA

[Péter Ujfalusi]

On 11/27/24 12:16 PM, Vaishnav Achath wrote:
> J722S CSI BCDMA is similar to J721S2 CSI BCDMA but there are slight
> integration differences like different PSIL thread base ID which is
> currently handled in the driver based on udma_of_match data. Add an
> entry to support J722S CSIRX.

Acked-by: Peter Ujfalusi <peter.ujfalusi@gmail.com>

> 
> Signed-off-by: Vaishnav Achath <vaishnav.a@ti.com>
> ---
> 
> V2->V3 : Minor edit in commit message.
> 
> V1->V2:
> 	* Add new compatible for J722S instead of modifying AM62A
> 
>  drivers/dma/ti/k3-udma.c | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
> 
> diff --git a/drivers/dma/ti/k3-udma.c b/drivers/dma/ti/k3-udma.c
> index b3f27b3f9209..7ed1956b4642 100644
> --- a/drivers/dma/ti/k3-udma.c
> +++ b/drivers/dma/ti/k3-udma.c
> @@ -4404,6 +4404,18 @@ static struct udma_match_data j721s2_bcdma_csi_data = {
>  	.soc_data = &j721s2_bcdma_csi_soc_data,
>  };
>  
> +static struct udma_match_data j722s_bcdma_csi_data = {
> +	.type = DMA_TYPE_BCDMA,
> +	.psil_base = 0x3100,
> +	.enable_memcpy_support = false,
> +	.burst_size = {
> +		TI_SCI_RM_UDMAP_CHAN_BURST_SIZE_64_BYTES, /* Normal Channels */
> +		0, /* No H Channels */
> +		0, /* No UH Channels */
> +	},
> +	.soc_data = &j721s2_bcdma_csi_soc_data,
> +};
> +
>  static const struct of_device_id udma_of_match[] = {
>  	{
>  		.compatible = "ti,am654-navss-main-udmap",
> @@ -4435,6 +4447,10 @@ static const struct of_device_id udma_of_match[] = {
>  		.compatible = "ti,j721s2-dmss-bcdma-csi",
>  		.data = &j721s2_bcdma_csi_data,
>  	},
> +	{
> +		.compatible = "ti,j722s-dmss-bcdma-csi",
> +		.data = &j722s_bcdma_csi_data,
> +	},
>  	{ /* Sentinel */ },
>  };
>  MODULE_DEVICE_TABLE(of, udma_of_match);

-- 
Péter

Re: [PATCH v3 0/2] Add support for J722S CSI BCDMA

[Vinod Koul]

On Wed, 27 Nov 2024 15:46:25 +0530, Vaishnav Achath wrote:
> This series adds support for CSI Block Copy DMA (BCDMA) instance on J722S,
> the BCDMA instance is similar to other CSI BCDMA found in rest of TI
> devices like J721S2, AM62A. It supports both RX (CSI2RX) and TX (CSITX)
> channels and is identical to J721S2 CSIRX BCDMA but has slight integration
> difference in the PSIL base thread ID which is currently handled in the
> k3-udma driver from the match_data, introduce a new compatible to support
> J722S BCDMA.
> 
> [...]

Applied, thanks!

[1/2] dt-bindings: dma: ti: k3-bcdma: Add J722S CSI BCDMA
      commit: 775363772f5e72b984a883e22d510fec5357477a
[2/2] dmaengine: ti: k3-udma: Add support for J722S CSI BCDMA
      commit: d0301fdbb50dfc99215b0f999d4ff7ab0a7675d9

Best regards,
-- 
~Vinod