From: CL Wang <cl634@andestech.com>
To: Rob Herring <robh@kernel.org>
Cc: <alexandre.belloni@bootlin.com>, <krzk+dt@kernel.org>,
<conor+dt@kernel.org>, <devicetree@vger.kernel.org>,
<linux-rtc@vger.kernel>, <linux-kernel@vger.kernel.org>,
<tim609@andestech.com>, <ycliang@andestech.com>,
<cl634@andestech.com>
Subject: Re: [PATCH V4 RESEND 2/3] dt-bindings: rtc: Add support for ATCRTC100 RTC
Date: Thu, 5 Dec 2024 17:15:44 +0800 [thread overview]
Message-ID: <Z1FvQEu-5Z68vJc2@swlinux02> (raw)
In-Reply-To: <20241203170651.GA1955995-robh@kernel.org>
Hi Rob,
Thank you for your review and comments.
I will include the reviewer's tag in the next version of the patch.
As you mentioned, if a tag is received and a resend is necessary,
I will include the tags and update the revision to v5.
Thank you again for your reminder.
Best regards,
CL
On Tue, Dec 03, 2024 at 11:06:51AM -0600, Rob Herring wrote:
> [EXTERNAL MAIL]
>
> On Wed, Nov 27, 2024 at 10:19:38PM +0800, CL Wang wrote:
> > Document Device Tree bindings for the Andes ATCRTC100 Real-Time Clock.
> >
> > Signed-off-by: CL Wang <cl634@andestech.com>
> >
> > ---
> > Changes for v2:
> > - First version of devicetree bindings for the Andes ATCRTC100 Real-Time Clock.
> >
> > Changes for v3:
> > - Used compatible as the filename.
> > - Placed allOf after maintainers.
> > - Replaced additionalProperties: false with unevaluatedProperties: false.
> > - Added descriptions for interrupts.
> >
> > Changes for v4:
> > - Removed wakeup-source attribute.
> > ---
> > .../bindings/rtc/andestech,atcrtc100.yaml | 43 +++++++++++++++++++
> > 1 file changed, 43 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/rtc/andestech,atcrtc100.yaml
>
> Missing Conor's tag from the 1st resend. If you got tags and need to
> resend, that's not a resend. You need to add the tags and it is v5.
>
> But don't just go send v5 now for that. Alexandre can add the tag.
>
> Rob
next prev parent reply other threads:[~2024-12-05 9:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-27 14:19 [PATCH V4 RESEND 0/3] rtc: atcrtc100: Add Andes ATCRTC100 RTC driver CL Wang
2024-11-27 14:19 ` [PATCH V4 RESEND 1/3] rtc: atcrtc100: Add " CL Wang
2024-11-27 14:19 ` [PATCH V4 RESEND 2/3] dt-bindings: rtc: Add support for ATCRTC100 RTC CL Wang
2024-12-03 17:06 ` Rob Herring
2024-12-05 9:15 ` CL Wang [this message]
2024-11-27 14:19 ` [PATCH V4 RESEND 3/3] MAINTAINERS: Add entry for ATCRTC100 RTC driver CL Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z1FvQEu-5Z68vJc2@swlinux02 \
--to=cl634@andestech.com \
--cc=alexandre.belloni@bootlin.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel \
--cc=robh@kernel.org \
--cc=tim609@andestech.com \
--cc=ycliang@andestech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).