From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f178.google.com (mail-pf1-f178.google.com [209.85.210.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B29A72AE66 for ; Fri, 13 Dec 2024 02:56:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734058590; cv=none; b=JzmTz3LefUzth1194HSrmoTOkz+j7QDr793YHB75g1LgMh82T8h2rvTh42UN4p/nkNsYJO9gn0xtATkWUWdX8vwOjn5PVzx0zfJ1q/wvXRXkjosrQFg3ZtWAGPBOttyzrnJIlE8rQAckounA5iDvjca6Kfa5U5KZ/BOBp9uE0dI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734058590; c=relaxed/simple; bh=msoRIi6q5Znx8858jCOffc0xZv9/XrVwI2YD5q+19zs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=p3AI3YPzgLCm4ayAKBR0bx5LfHmeEAyl3V7X2h1C2fOI1NNtYKfEk0+TFIJffszBONbVW89OAUvaEqqF5WWo/+mJP4DqR8/eNsFM/TZjSlNuZEloPefmBGr6vwm4Ljo/OWsA3497ONq5EEzmpfv4WoBEO+L5noE4DF5f924XzII= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=tenstorrent.com; spf=pass smtp.mailfrom=tenstorrent.com; dkim=pass (2048-bit key) header.d=tenstorrent.com header.i=@tenstorrent.com header.b=ZeINtLiG; arc=none smtp.client-ip=209.85.210.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=tenstorrent.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=tenstorrent.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=tenstorrent.com header.i=@tenstorrent.com header.b="ZeINtLiG" Received: by mail-pf1-f178.google.com with SMTP id d2e1a72fcca58-725ce7b82cbso1480263b3a.0 for ; Thu, 12 Dec 2024 18:56:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tenstorrent.com; s=google; t=1734058588; x=1734663388; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=JyBVz9J4Iy1oVqyEvOxvCgnZn06m2Dd6z78eSL9EpLM=; b=ZeINtLiGLETXt6eo6oPd6eCZL0+2c3XHq5gu6dWwL6vz96wJk4VvDepQZF2c2kLbRO +r37Y1nfEj+p8u501rT3tXZGUsvZBWRMN59rOt/TaSL2XPb5QGe5a5+9/KBRuWFfBnaQ IURl1Jt/WBOKl6CxCJXgXA3I7XAbMGCnVAwevn98VSQHXkQUUGrgnWjwQrTNbQBTTc09 9u9zZeu6f/7Z8qGI/GbFllqvFHbfHjAQf6GgDcgjJukst7dx7mXBk/EL2Vlc6huMyPiz PYb6JFk+QDlSmqKvlmfOnIrpZXgkJkTVPcwRnNeczZt8AhkD2wcRdm6KJJLvblp3mEzz oaLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734058588; x=1734663388; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=JyBVz9J4Iy1oVqyEvOxvCgnZn06m2Dd6z78eSL9EpLM=; b=FVh+ddiqKGwv5ehd2Yr7qNWUENrq3PtiugdPzIaX90wJ/iTpgfpzR3TY+xqXrdB85I ZZl/r3TEKjs590I0UeSE9/dzPYyZBQK4MeoIuQZS2d2C4hUlVCD4GVmRvPzE80ZLIaLg cI7d2hrzyMlan7l34/65xDAUdj8FJaGoycfUdS6YpnS/0U23t78eS8idZFTFtmec87/3 3nIpAcl/01DzgufS3c9ny+6tQnvET9SR8f9xzMJWGglk+NmL3i8TeAiFgKOuEI85rYXj wy2/wE0cfu0ghRKbTquqIpCOIjp5LvT2JU8w3a9G5AL2F3MM+0J+DuSxZaw1rZwm1CKU QWtA== X-Forwarded-Encrypted: i=1; AJvYcCXJtuRp5wfPPAbeeWxClR76KUFwt63iNDmllMcF9CM2UEucpshoJYDK6NhH3NMFbTe03DGiMAqB8TLk@vger.kernel.org X-Gm-Message-State: AOJu0YytfnqZVEFnaL21pdPEqVR2sCwt9JW1KQ77hm39keQYYIBAllam edvF/ifwLwL5wURM+7XenoFN645tXeppaXaAnrywuYSNZykUFVc1BNxwpSK1kpA= X-Gm-Gg: ASbGncu3abQQy355mwthd6wblIDvEwn8FR+YQE/bNk6CnA2Ww1jX/zTP5lzH9ebocOl Ohobye/4CLg5/YAsWJDID4HHpW7FsutLFYtMYMqWwRF2N6XOsbT6meB8b5FlqiwibHsYYAiDl3k PBCA8hQVoztNazUhPO7WTOtcq7HSfhICaEh9gOYpossjL/dLyBAcGzmc9TfDH+KxjwzBb4YJ/DN 7biz1tjRt1Sg9S55jfu61+25KWZkyvbacUOPTt7ZwVO/9TMxcaR0e/73Kj1RbMNdSMyoJL8uDyg Zepj X-Google-Smtp-Source: AGHT+IE3GLEOuUBB1zehzAwY9Ah5/2jVDz+WIAO7JDxIdFk51hMlAke8a4l8rZumyuvII+YjSfeLwA== X-Received: by 2002:a05:6a00:4505:b0:725:e444:2505 with SMTP id d2e1a72fcca58-7290c0eea53mr1353429b3a.4.1734058587964; Thu, 12 Dec 2024 18:56:27 -0800 (PST) Received: from x1 (75-164-218-15.ptld.qwest.net. [75.164.218.15]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-725ea44c362sm8693583b3a.102.2024.12.12.18.56.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Dec 2024 18:56:27 -0800 (PST) Date: Thu, 12 Dec 2024 18:56:25 -0800 From: Drew Fustini To: Michal Wilczynski Cc: drew@pdp7.com, guoren@kernel.org, wefu@redhat.com, jassisinghbrar@gmail.com, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, m.szyprowski@samsung.com, samuel.holland@sifive.com, emil.renner.berthing@canonical.com, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, christophe.jaillet@wanadoo.fr Subject: Re: [PATCH v6 3/3] riscv: dts: thead: Add mailbox node Message-ID: References: <20241104100734.1276116-1-m.wilczynski@samsung.com> <20241104100734.1276116-4-m.wilczynski@samsung.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Wed, Dec 11, 2024 at 02:15:01PM -0800, Drew Fustini wrote: > On Mon, Nov 04, 2024 at 11:07:34AM +0100, Michal Wilczynski wrote: > > Add mailbox device tree node. This work is based on the vendor kernel [1]. > > > > Link: https://github.com/revyos/thead-kernel.git [1] > > > > Signed-off-by: Michal Wilczynski > > --- > > arch/riscv/boot/dts/thead/th1520.dtsi | 16 ++++++++++++++++ > > 1 file changed, 16 insertions(+) > > > > diff --git a/arch/riscv/boot/dts/thead/th1520.dtsi b/arch/riscv/boot/dts/thead/th1520.dtsi > > index 6992060e6a54..89de5634d3d3 100644 > > --- a/arch/riscv/boot/dts/thead/th1520.dtsi > > +++ b/arch/riscv/boot/dts/thead/th1520.dtsi > > @@ -520,6 +520,22 @@ timer7: timer@ffffc3303c { > > status = "disabled"; > > }; > > > > + mbox_910t: mailbox@ffffc38000 { > > + compatible = "thead,th1520-mbox"; > > + reg = <0xff 0xffc38000 0x0 0x6000>, > > + <0xff 0xffc40000 0x0 0x6000>, > > + <0xff 0xffc4c000 0x0 0x2000>, > > + <0xff 0xffc54000 0x0 0x2000>; > > + reg-names = "local", "remote-icu0", "remote-icu1", "remote-icu2"; > > + clocks = <&clk CLK_MBOX0>, <&clk CLK_MBOX1>, <&clk CLK_MBOX2>, > > + <&clk CLK_MBOX3>; > > + clock-names = "clk-local", "clk-remote-icu0", "clk-remote-icu1", > > + "clk-remote-icu2"; > > + interrupt-parent = <&plic>; > > + interrupts = <28 IRQ_TYPE_LEVEL_HIGH>; > > + #mbox-cells = <1>; > > + }; > > + > > ao_gpio0: gpio@fffff41000 { > > compatible = "snps,dw-apb-gpio"; > > reg = <0xff 0xfff41000 0x0 0x1000>; > > -- > > 2.34.1 > > > > Reviewed-by: Drew Fustini > > dt_binding_check and dtbs_check are clean when I apply this patch to > v6.13-rc1. There is trivial conflict due to the gpio node label having > changed. I'll resolve it when I apply the patch to thead-dt-for-next. I've applied this patch to thead-dt-for-next [1]. Thanks, Drew [1] https://github.com/pdp7/linux/commit/98064af36cbc0c216d0a2d11da5e3746a57ccce7